fix: SQL Lab tab events

[michael-s-molina]

SUMMARY

This adds a unique immutableId field to the QueryEditor type that persists throughout the tab's lifecycle, enabling reliable event filtering and tab identification for SQL Lab extensions while maintaining backward compatibility. Previously, SQL Lab tabs could only be identified by their mutable id field, which made it difficult for extensions to reliably track events and maintain stable references to specific editor instances across state changes and persistence operations.

The addition of immutableId for tabs might help improving the current logic that uses mutable id and tabViewId introduced in #34720 to reduce re-renders. I'll let @justinpark analyze the code and check if things can be improved in a follow-up PR.

TESTING INSTRUCTIONS

Check that the events are triggered for the correct tabs.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset-frontend/src/SqlLab/utils/reduxStateToLocalStorageHelper.ts	✅
superset-frontend/src/SqlLab/types.ts	✅
superset-frontend/src/SqlLab/reducers/getInitialState.ts	✅
superset-frontend/src/SqlLab/fixtures.ts	✅
superset-frontend/src/core/sqlLab.ts	✅
superset-frontend/src/SqlLab/actions/sqlLab.js	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[villebro]

LGTM with a minor test fixture comment. I'm curious, do you know wht the ids are mutable? I would have thought the main id would stay unchanged throughout the tab's lifecycle.

[michael-s-molina]

I'm curious, do you know why the ids are mutable?

I think it's because they are updated when the tab is saved on the server. @justinpark will probably know better but I'm hoping that we can improve the logic now that an immutable id is present and maybe keep the remote id in a separate variable.

[villebro]

Approving but hoping for remaining fixtures to also be updated!