chore: split UserProvider into two: User and Authentication - #31513
Merged
Conversation
|
dionisio-bot
Bot
added
stat: ready to merge
pierre-lehnen-rc
marked this pull request as ready for review
January 22, 2024 17:22
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #31513 +/- ##
===========================================
+ Coverage 49.53% 49.55% +0.01%
===========================================
Files 3315 3320 +5
Lines 81480 81532 +52
Branches 16737 16744 +7
===========================================
+ Hits 40365 40403 +38
- Misses 36408 36419 +11
- Partials 4707 4710 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
approved these changes
Jan 22, 2024
gabriellsh
requested changes
Jan 22, 2024
gabriellsh
left a comment
gabriellsh
left a comment
Member
There was a problem hiding this comment.
Please take a look at
packages/mock-providers/src/MockedAppRootBuilder.tsx
There are some unit tests that use these contexts
gabriellsh
approved these changes
Jan 22, 2024
gabriellsh
left a comment
gabriellsh
left a comment
Member
There was a problem hiding this comment.
Hadn't noticed you had removed it already
dionisio-bot
Bot
added
stat: ready to merge
tassoevan
approved these changes
Jan 22, 2024
gabriellsh
added a commit
that referenced
this pull request
Jan 23, 2024
* 'develop' of github.com:RocketChat/Rocket.Chat: (143 commits) fix: Marketplace apps installed as private showing as installed (#31514) test: fix messaging flaky test (#31512) fix: change the push sound sent when the push is from video conference (#30910) fix: ensure sessionId on Sessions documents (#31487) chore: handle rocket.cat creation and deletion (#31170) chore(agenda): Changes in Agenda API (#31427) refactor: Pay the debt of some TODO comments (#30338) feat: Room header keyboard navigability (#31516) fix: Cron job for clearing OEmbed cache isn't working (#31336) refactor(client): Handling of custom statuses (#31500) fix: Prevent `Fallback forward departments` feature to go on loop when configured as circular chain (#31328) feat: Add `push.test` endpoint (#31289) chore: split UserProvider into two: User and Authentication (#31513) fix: Can't remove channel's password to join (#31507) chore: convert CAS integration code to typescript (#31492) feat: Composer keyboard navigability (#31510) fix: Render warning in Logs - (MessageType.render is deprecated. Use MessageType.message instead) (#31426) feat: Convert emoji shortname to unicode on notification emails. (#31225) chore: Normalize `ButtonGroup` (#31499) chore: improve type definitions for login service configurations (#31491) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
I'm splitting #31385 into multiple smaller PRs. This one: