fix: Prevent Fallback forward departments feature to go on loop when configured as circular chain - #31328
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 0cbfc7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #31328 +/- ##
============================================
- Coverage 59.88% 49.55% -10.34%
============================================
Files 1793 3315 +1522
Lines 34897 81475 +46578
Branches 7263 16736 +9473
============================================
+ Hits 20898 40374 +19476
- Misses 12398 36397 +23999
- Partials 1601 4704 +3103
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
Bot
added
stat: ready to merge
lmauromb
approved these changes
Jan 11, 2024
lmauromb
previously approved these changes
Jan 16, 2024
MarcosSpessatto
previously requested changes
Jan 19, 2024
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
Contributor
There was a problem hiding this comment.
Would it be possible to add some test cases for the maximum number of depth?
KevLehman
commented
Jan 19, 2024
dionisio-bot
Bot
removed
the
stat: ready to merge
dionisio-bot
Bot
added
the
stat: ready to merge
Member
Author
|
Tests are definitely possible. The test would take some time however to create the number of departments required for properly testing depth, so at the end I didn't do it 🤔 I can include it on a separate PR too. |
lmauromb
approved these changes
Jan 22, 2024
dionisio-bot
Bot
added
stat: ready to merge
MarcosSpessatto
approved these changes
Jan 22, 2024
sampaiodiego
approved these changes
Jan 22, 2024
dionisio-bot
Bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jan 23, 2024
* 'develop' of github.com:RocketChat/Rocket.Chat: (143 commits) fix: Marketplace apps installed as private showing as installed (#31514) test: fix messaging flaky test (#31512) fix: change the push sound sent when the push is from video conference (#30910) fix: ensure sessionId on Sessions documents (#31487) chore: handle rocket.cat creation and deletion (#31170) chore(agenda): Changes in Agenda API (#31427) refactor: Pay the debt of some TODO comments (#30338) feat: Room header keyboard navigability (#31516) fix: Cron job for clearing OEmbed cache isn't working (#31336) refactor(client): Handling of custom statuses (#31500) fix: Prevent `Fallback forward departments` feature to go on loop when configured as circular chain (#31328) feat: Add `push.test` endpoint (#31289) chore: split UserProvider into two: User and Authentication (#31513) fix: Can't remove channel's password to join (#31507) chore: convert CAS integration code to typescript (#31492) feat: Composer keyboard navigability (#31510) fix: Render warning in Logs - (MessageType.render is deprecated. Use MessageType.message instead) (#31426) feat: Convert emoji shortname to unicode on notification emails. (#31225) chore: Normalize `ButtonGroup` (#31499) chore: improve type definitions for login service configurations (#31491) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUP-449
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments