Skip to content

chore: refactor the refresh oauth services function - #31385

Merged
ggazzo merged 40 commits into
developfrom
chore/refresh-oauth-services
Jan 23, 2024
Merged

chore: refactor the refresh oauth services function#31385
ggazzo merged 40 commits into
developfrom
chore/refresh-oauth-services

Conversation

@pierre-lehnen-rc

@pierre-lehnen-rc pierre-lehnen-rc commented Jan 5, 2024

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

This PR started as a big PR with several changes, but then I made several smaller PRs with parts of it that were all already merged. Some of the smaller changes here may still be a reflection of that.

@changeset-bot

changeset-bot Bot commented Jan 5, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 770052e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Jan 5, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (0c94ea3) 49.54% compared to head (a7b64a2) 49.53%.
Report is 1 commits behind head on develop.

❗ Current head a7b64a2 differs from pull request most recent head 770052e. Consider uploading reports for the commit 770052e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31385      +/-   ##
===========================================
- Coverage    49.54%   49.53%   -0.02%     
===========================================
  Files         3318     3324       +6     
  Lines        81689    81706      +17     
  Branches     16795    16807      +12     
===========================================
  Hits         40470    40470              
- Misses       36504    36520      +16     
- Partials      4715     4716       +1     
Flag Coverage Δ
e2e 53.11% <ø> (+0.03%) ⬆️
e2e-api 40.68% <28.16%> (-0.04%) ⬇️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc
pierre-lehnen-rc changed the base branch from develop to fix/login-buttons-not-hiding January 9, 2024 14:28
@pierre-lehnen-rc
pierre-lehnen-rc changed the base branch from fix/login-buttons-not-hiding to develop January 9, 2024 14:28
pierre-lehnen-rc and others added 2 commits January 18, 2024 18:27
…ion (#31452)

* moved the `service.configurations` request to a dedicated class

* removed duplicated utilitary function

* remove client references to service configuration collection

* fixed missing imports and invalid type

* Moved linkedin's requestCredential to meteorOverrides as the old meteor package can't reference loginServices directly
@pierre-lehnen-rc pierre-lehnen-rc changed the title chore: convert login services code to TS and refactor the refresh oauth services function chore: refactor the refresh oauth services function Jan 22, 2024
@pierre-lehnen-rc
pierre-lehnen-rc marked this pull request as ready for review January 23, 2024 17:16
@pierre-lehnen-rc
pierre-lehnen-rc requested review from a team as code owners January 23, 2024 17:16
@ggazzo
ggazzo merged commit 4cf5a70 into develop Jan 23, 2024
@ggazzo
ggazzo deleted the chore/refresh-oauth-services branch January 23, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants