fix: Render warning in Logs - (MessageType.render is deprecated. Use MessageType.message instead) - #31426
Merged
kodiakhq[bot] merged 2 commits intoJan 22, 2024
Conversation
|
Devansht420
force-pushed
the
warning-deprecation
branch
from
January 11, 2024 19:12
7142389 to
53a224a
Compare
KevLehman
previously approved these changes
Jan 12, 2024
dionisio-bot
Bot
added
stat: ready to merge
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #31426 +/- ##
===========================================
- Coverage 49.60% 47.44% -2.17%
===========================================
Files 3310 1819 -1491
Lines 81441 55729 -25712
Branches 16699 11162 -5537
===========================================
- Hits 40400 26439 -13961
+ Misses 36348 25748 -10600
+ Partials 4693 3542 -1151
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
|
@Devansht420 , thanks for your contribution :) it was on line to be merged but Prettier failed. Would you mind checking the lint issues and fix them? 🙏🏽 |
Contributor
Author
|
Sure @KevLehman I'll check the lint issues ASAP and amend the changes. |
Devansht420
force-pushed
the
warning-deprecation
branch
from
January 16, 2024 12:00
53a224a to
b8ebe59
Compare
dionisio-bot
Bot
added
stat: ready to merge
Contributor
Author
|
hey @KevLehman , I've fixed the lint issues and tested it, no more errors now. |
KevLehman
approved these changes
Jan 19, 2024
dionisio-bot
Bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jan 23, 2024
* 'develop' of github.com:RocketChat/Rocket.Chat: (143 commits) fix: Marketplace apps installed as private showing as installed (#31514) test: fix messaging flaky test (#31512) fix: change the push sound sent when the push is from video conference (#30910) fix: ensure sessionId on Sessions documents (#31487) chore: handle rocket.cat creation and deletion (#31170) chore(agenda): Changes in Agenda API (#31427) refactor: Pay the debt of some TODO comments (#30338) feat: Room header keyboard navigability (#31516) fix: Cron job for clearing OEmbed cache isn't working (#31336) refactor(client): Handling of custom statuses (#31500) fix: Prevent `Fallback forward departments` feature to go on loop when configured as circular chain (#31328) feat: Add `push.test` endpoint (#31289) chore: split UserProvider into two: User and Authentication (#31513) fix: Can't remove channel's password to join (#31507) chore: convert CAS integration code to typescript (#31492) feat: Composer keyboard navigability (#31510) fix: Render warning in Logs - (MessageType.render is deprecated. Use MessageType.message instead) (#31426) feat: Convert emoji shortname to unicode on notification emails. (#31225) chore: Normalize `ButtonGroup` (#31499) chore: improve type definitions for login service configurations (#31491) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR aims to resolve the issue where a warning related to render function was logged which was -
MessageType.render is deprecated. Use MessageType.message instead.
Before:
After:
Issue(s)
fixes #28384
Steps to test or reproduce
Further comments