Skip to content

refactor(client): Handling of custom statuses - #31500

Merged
ggazzo merged 3 commits into
developfrom
refactor/client-startup-1
Jan 22, 2024
Merged

refactor(client): Handling of custom statuses#31500
ggazzo merged 3 commits into
developfrom
refactor/client-startup-1

Conversation

@tassoevan

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Jan 20, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a863408

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Jan 20, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (ca44595) 49.57% compared to head (a863408) 49.58%.
Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #31500   +/-   ##
========================================
  Coverage    49.57%   49.58%           
========================================
  Files         3314     3312    -2     
  Lines        81507    81495   -12     
  Branches     16714    16715    +1     
========================================
+ Hits         40406    40408    +2     
+ Misses       36398    36388   -10     
+ Partials      4703     4699    -4     
Flag Coverage Δ
e2e 53.20% <60.78%> (+0.04%) ⬆️
e2e-api 40.69% <100.00%> (-0.01%) ⬇️
unit 76.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan
tassoevan marked this pull request as ready for review January 20, 2024 19:29
@tassoevan
tassoevan requested review from a team as code owners January 20, 2024 19:29
@tassoevan tassoevan added this to the 6.6 milestone Jan 20, 2024
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 22, 2024
@ggazzo
ggazzo merged commit ec285f7 into develop Jan 22, 2024
@ggazzo
ggazzo deleted the refactor/client-startup-1 branch January 22, 2024 21:35
gabriellsh added a commit that referenced this pull request Jan 23, 2024
* 'develop' of github.com:RocketChat/Rocket.Chat: (143 commits)
  fix: Marketplace apps installed as private showing as installed (#31514)
  test: fix messaging flaky test (#31512)
  fix: change the push sound sent when the push is from video conference (#30910)
  fix: ensure sessionId on Sessions documents (#31487)
  chore: handle rocket.cat creation and deletion (#31170)
  chore(agenda): Changes in Agenda API (#31427)
  refactor: Pay the debt of some TODO comments (#30338)
  feat: Room header keyboard navigability (#31516)
  fix: Cron job for clearing OEmbed cache isn't working (#31336)
  refactor(client): Handling of custom statuses (#31500)
  fix: Prevent `Fallback forward departments` feature to go on loop when configured as circular chain (#31328)
  feat: Add `push.test` endpoint (#31289)
  chore: split UserProvider into two: User and Authentication (#31513)
  fix: Can't remove channel's password to join (#31507)
  chore: convert CAS integration code to typescript (#31492)
  feat: Composer keyboard navigability (#31510)
  fix: Render warning in Logs - (MessageType.render is deprecated. Use MessageType.message instead) (#31426)
  feat: Convert emoji shortname to unicode on notification emails. (#31225)
  chore: Normalize `ButtonGroup` (#31499)
  chore: improve type definitions for login service configurations (#31491)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants