Repository navigation
evidence(OMN-12438): OCC contract for consumer.py max_tokens regression fix - #1927
Closed
jonahgabriel wants to merge 227 commits into
Closed
jonahgabriel wants to merge 227 commits into
jonahgabriel wants to merge 227 commits into
Conversation
* contracts(OMN-11994): add infra handler wiring evidence to dev * fix(OMN-11994): bind dev OCC evidence PR
* contracts(OMN-11958): add infra duplicate discovery evidence * fix(OMN-11958): bind OCC evidence PR
* contracts(OMN-11975): add infra consumer startup evidence * fix(OMN-11975): bind OCC evidence PR
…omnimarket rehome (#1605) * contracts(OMN-11816): SEA swarm quarantine — remove src/swarm/ after omnimarket rehome Binds OMN-11816 contract to OCC. SEA PR #129 removes src/swarm/ (6 files, 1014 lines) and 3 swarm test files. All logic rehomed to omnimarket nodes OMN-11809–OMN-11815. * contracts(OMN-11816): add dod-occ-pr receipt for OCC PR #1605 * contracts(OMN-11816): add contract_sha256 to all three receipts (OMN-10421) * style(OMN-11816): apply yamlfmt to OCC evidence * contracts(OMN-11816): refresh receipt contract hashes
* contracts(OMN-11513): bind infra pricing PR receipt * contracts(OMN-11513): bind OCC PR receipt * contracts(OMN-11513): declare infra PR receipt bindings * contracts(OMN-11513): update infra PR #1735 receipt to latest head commit
…1608) * contracts(OMN-11828,OMN-11972): add self agent PR evidence (#1597) * contracts(OMN-11828,OMN-11972): add self agent PR evidence * fix(OMN-11828): bind OCC evidence PR * contracts(OMN-11994): add infra handler wiring evidence (#1599) * contracts(OMN-11994): add infra handler wiring evidence * fix(OMN-11994): bind OCC evidence PR * contracts(OMN-11513): bind infra pricing PR receipt * contracts(OMN-11513): bind OCC PR receipt * contracts(OMN-11513): declare infra PR receipt bindings * contracts(OMN-11513): update infra PR #1735 receipt to latest head commit * contracts(OMN-11513): add receipt binding for infra PR #1739 (renames PR #1735) * contracts(OMN-11513): add deploy evidence for infra PR 1739
…ory (#1606) * chore(OMN-11998): register 082_swarm_runs.sql in OCC migration inventory Adds the swarm_runs migration entry to the omnibase_infra migration set so the inventory stays in sync with the new forward migration. * contracts(OMN-11998): add swarm migration evidence * contracts(OMN-11998): stage deploy evidence before inventory
) * contracts(OMN-11997): add infra PG16 migration index fix evidence Evidence for omnibase_infra PR #1738 — removes non-IMMUTABLE ::date functional index from intelligence migrations 024/025 that caused migration-gate container failures on PG 16.14. * contracts(OMN-11997): add occ-pr receipt for PR #1609 * contracts(OMN-11997): fix receipt contract_sha256 after yamlfmt reformatting
…9 fix PRs (#1610) * contracts(OMN-11996,OMN-12001): add OCC evidence for delegate-skill B9 fix PRs Adds contract evidence for omnibase_infra PR #1736 (missing DispatchResultApplier for node_delegate_skill_orchestrator) and omnimarket PR #848 (missing event_model block in handler_routing). Both are required to unblock B9 quality gate delegation CLI tests. * receipts(OMN-11996,OMN-12001): add DoD receipts for delegate-skill B9 fix PRs Adds PASS receipts for all dod_evidence items in OMN-11996.yaml and OMN-12001.yaml. These receipts are required by the OCC eligibility check before the receipt gate will pass for PR #1741. * receipts(OMN-11996,OMN-12001): fix receipt runner/verifier and PR binding Update receipts to use distinct runner/verifier (codex-cli/codex) so they are not downgraded from PASS to ADVISORY by the self-attestation invariant. Update OMN-11996 receipts to bind to PR #1741 (the active arch-invariants follow-up PR). OMN-12001 receipts remain bound to the merged PR #848 with its actual commit SHA. * fix(OMN-11996): repair delegate skill OCC receipts * fix(OMN-11996): align OCC self receipt head * fix(OMN-11996): bind OCC receipt to infra PR 1741
* contracts(OMN-11997): add deploy assessment evidence * contracts(OMN-11997): bind deploy evidence OCC PR
* contracts(OMN-12002): add OCC evidence for async dispatch fix * contracts(OMN-12002): bind OCC evidence PR * contracts(OMN-12002): stabilize OCC PR receipt
) * contracts(OMN-12114): add OCC evidence for ci_watch auto-fix loop Central contract for omnimarket PR #854 (OMN-12114). No live deploy required; node_ci_watch is a workflow package consumed at call time. * receipts(OMN-12114): add dod evidence receipts for ci_watch auto-fix loop Adds three PASS receipts for OMN-12114: - dod-omnimarket-pr-854: omnimarket PR #854 merged - dod-deploy-assessment: no live deploy required (workflow package) - dod-occ-pr: this OCC PR #1616 * fix(OMN-12114): set verifier != runner in dod receipts to avoid self-attestation ADVISORY downgrade * contracts(OMN-12114): repair OCC receipt evidence
…lementation (#1629) * contracts(OMN-11591): add OCC evidence for generate_reverse_patch implementation Adds contract YAML and dod_receipts for OMN-11591. omnibase_core PR #1154 implements the previously-stubbed generate_reverse_patch method in ContractDiffComputer. Required to satisfy the receipt gate on PR #1154. * contracts(OMN-11591): bind OCC PR #1629 receipt Adds dod-occ-pr receipt referencing PR #1629 (this PR) to complete the evidence chain for OMN-11591. * contracts(OMN-11591): add contract_sha256 to all receipts (OMN-10421) All four receipt files were missing the required contract_sha256 field. Hash value: sha256:aed523e3b25f851e2313d33cf87eae8a7793d2aba63e401be3f93b4897d45831 * fix(OMN-11591): align OCC evidence checks
* contracts(OMN-12120): add subtask reducer gate evidence * contracts(OMN-12120): bind OCC evidence PR
* contracts(OMN-12128): add handler routing evidence * contracts(OMN-12128): bind OCC evidence PR
* contracts(OMN-12128): use valid interface kinds * contracts(OMN-12128): bind schema repair PR
* contracts(OMN-12061): add model registry evidence * contracts(OMN-12061): bind OCC evidence PR
…ility-backend rewrite (#1635) * contracts(OMN-12006): add OCC contract and receipts for bifrost capability-backend rewrite Documents OMN-12006 — the bifrost_delegation.yaml rewrite that: - Sets model_name: null for all local backends (PR #853) - Renames backends to capability-named IDs (local-coder, local-reasoner, etc.) (PR #856) - Restores capability names after PR #851 merge-conflict revert (PR #871) Includes receipts for all three omnimarket PRs and the OCC self-binding receipt. * contracts(OMN-12006): repair receipt schema bindings * contracts(OMN-12006): bind receipts to contract hash * chore(OMN-12131): register log entries migration
* contracts(OMN-12129): bind compat min success rate evidence * contracts(OMN-12129): bind OCC self receipt
* contracts(OMN-12129): fix receipt check paths * contracts(OMN-12129): bind compliance path PR receipt
* contracts(OMN-11973): add migrate image deploy evidence * contracts(OMN-11973): bind OCC PR receipt
… max_subtasks and cost fields (#1641) * contracts(OMN-12084,OMN-12086): add deploy DoD evidence for swarm FSM max_subtasks and cost fields OCC contracts for omnimarket PR #886 (B5-T2/T4): - OMN-12084: max_subtasks=6 threaded through swarm dispatch FSM - OMN-12086: cost/savings/speedup fields added to completed payload * contracts(OMN-12084,OMN-12086): add receipts for swarm FSM max_subtasks and cost fields Adds DoD receipts for omnimarket PR #886 evidence items: - OMN-12084: dod-omnimarket-pr-886 + dod-deploy-assessment - OMN-12086: dod-omnimarket-pr-886 + dod-deploy-assessment * contracts(OMN-12084,OMN-12086): fix receipt commit_sha to OCC PR head
…#1640) * contracts(OMN-12079): add B3 convergence fixture evidence for PR #132 Covers OMN-12078, OMN-12079, OMN-12080, OMN-12081 (B3 convergence demonstration — cost curve, provenance labels, ledger column, language constraint). * fix(OMN-12079): clear interfaces_touched when interface_change is false, run yamlfmt Contract validator requires interfaces_touched: [] when interface_change: false. Also apply yamlfmt formatting to dod-deploy-assessment receipt. * fix(OMN-12079): add dod-occ-pr-1640 self-receipt so verify/verify binds to OCC PR Receipt gate requires a PASS receipt whose pr_number matches the OCC PR itself (#1640). Add dod-occ-pr-1640 receipt + corresponding dod_evidence entry in the contract. * fix(OMN-12079): update all receipt contract_sha256 to match current contract hash Contract hash changed after adding dod-occ-pr-1640 evidence item and fixing interfaces_touched. New hash: sha256:5054a185...
…ssion fix (#1642) * contracts(OMN-12151): add OCC evidence for result-applier None-suppression fix Adds central OCC evidence for the two-repo fix that suppresses premature terminal event publication from DispatchResultApplier when handle_async returns None (multi-step FSM orchestrators). Evidence bundle: - contracts/OMN-12151.yaml: contract with dod_evidence items - dod-infra-pr-1745: omnibase_infra PR #1745 fix receipt - dod-omnimarket-pr-884: omnimarket PR #884 fix receipt - dod-tests-pass: unit test pass receipt for both repos - dod-runtime-deploy: deploy gate evidence (Build Runtime Image CI job) - dod-occ-pr: this OCC PR receipt * contracts(OMN-12151): update PR reference from #884 to #887 * fix(OMN-12151): correct contract schema and receipt directory name - Remove invalid 'runtime' from interfaces_touched (only protocols/events/topics/envelopes/public_api allowed) - Rename receipt dir dod-omnimarket-pr-884 → dod-omnimarket-pr-887 to match actual PR and contract id - Update receipt evidence_item_id, check_value, probe_command, and probe_stdout to reference PR #887 - Fix summary text: PR #884 → PR #887 * fix(OMN-12151): add missing commit_sha to dod-occ-pr receipt ModelDodReceipt requires commit_sha; the receipt was missing this field, causing OCC eligibility check to fail with a Pydantic validation error. * fix(OMN-12151): remove extra notes field from dod-runtime-deploy receipt ModelDodReceipt has extra="forbid"; the notes field is not in the schema and caused OCC eligibility to reject the receipt. * ci: retrigger to pick up updated PR body with Evidence-Ticket * fix(OMN-12151): add contract_sha256 to all receipts (OMN-10421) Receipts produced after 2026-04-30 must include contract_sha256 per OMN-10421 policy. Add the sha256 of contracts/OMN-12151.yaml to all 5 receipts so the receipt gate accepts them.
…ler node (#1645) * contracts(OMN-12146): add OCC contract for node_dispatch_request_handler node * fix(OMN-12146): apply yamlfmt formatting to OCC contract * receipts(OMN-12146): add dod_receipts for node_dispatch_request_handler node * receipts(OMN-12146): add contract_sha256 to all dod_receipts
…fra#469 (#1650) * contracts(OMN-12153): add OCC contract + receipts binding omninode_infra#469 omninode_infra PR #469 (MERGED) removed --unsafe-bypass-fsync from the shared data-plane Redpanda overlay, eliminating data loss risk under node failure. The flag remains correctly scoped in k8s/dev/redpanda/statefulset.yaml. Resolves OMN-1961. * contracts(OMN-12153): fix OCC receipt validity * contracts(OMN-12153): bind receipts to contract hash
…rowing (#1649) * contracts(OMN-12156): add OCC contract for Postgres NetworkPolicy narrowing Central evidence for omninode_infra PR #470: narrows netpol-allow-onex-dev.yaml from broad namespace access to specific podSelector on onex-api. Resolves OMN-2338. * contracts(OMN-12156): add receipts and update check_value to self-referential pattern omninode_infra PR #470 merged (state: MERGED). Receipts prove: - PR state MERGED at commit 71276779 - Validate NetworkPolicies CI check passed * contracts(OMN-12156): add hash-bound OCC receipts
* evidence(OMN-12447): bind DoD evidence checkout auth * evidence(OMN-12447): refresh DoD checkout auth receipts
* evidence(OMN-12433): bind omniclaude deploy gate receipts * evidence(OMN-12433): self-bind omniclaude receipt publication
* evidence(OMN-12448): bind event bus startup receipts * evidence(OMN-12448): bind OCC publication receipt
* fix(OMN-12448): use contract interface categories * evidence(OMN-12448): bind OCC schema fix receipt
* style(OMN-12448): apply OCC yaml formatting * evidence(OMN-12448): bind OCC yamlfmt receipt
* chore(OMN-12448): bind OCC yamlfmt follow-up * chore(OMN-12448): bind OCC self receipt
…ket-node fixes (#1907) * evidence(OMN-12449): central contract + DoD receipts for hot-load market-node fixes Pairs with omnibase_infra PR #1796. Carries the OMN-12449 ticket contract and canonical DoD receipts (omnibase_infra PR head evidence, 4 descriptor-parser tests, materializer namespace-gate test) so the Receipt-Gate on #1796 can resolve Evidence-Source against this OCC commit. * evidence(OMN-12449): add self-referencing OCC PR #1907 receipt + pin contract to OCC PR number * evidence(OMN-12449): record contract_sha256 on all receipts (OMN-10421)
…e market-node hot-load adapter (#1908) * evidence(OMN-12463): central contract + DoD receipts for producer-side market-node hot-load adapter Publishes the OMN-12463 ticket contract and DoD receipts proving the omnimarket producer-side adapter (PR #997) emits a ModelHandlerContract-shaped registration payload for market node hot-load. Receipts cover the omnimarket PR state, the 8 adapter unit tests (incl. ContractYamlParser.parse round-trip), and the 17 node_contract_registry handler tests (adapted contract_yaml + ADAPTER_FAILURE). The dod-occ self-binding receipt is added in a follow-up commit once this OCC PR number is known. * evidence(OMN-12463): self-bind OCC PR #1908 receipt and refresh contract hashes Adds the dod-occ-pr-1908 self-binding receipt and points the contract's dod-occ evidence item at PR #1908, refreshing all receipt contract_sha256 to the committed contract hash.
…ime-path changes (#1909) omnimarket PR #997 touches src/omnimarket/nodes/ runtime paths, so the deploy-gate requires a deploy-flavored dod_evidence item. Add dod-deploy-gate recording that post-merge runtime deploy + integration sweep remain required; the LIVE golden-chain proof (publish market node contract -> new Stable consumer group) is gated on OMN-12449 deploying its consumer-side fixes to a runtime. Payload-shape correctness is already proven by the adapter unit tests and the ContractYamlParser.parse round-trip.
…-gate contract (#1910) * evidence(OMN-12463): align receipt contract hashes with merged deploy-gate contract OCC #1909 merged the dod-deploy-gate item (contract hash 121fb382) before the companion receipt-hash refresh landed, leaving four OMN-12463 receipts pinned to the prior hash 2fd75183. Refresh them so the OCC merge-eligibility validator (contract_hash match) passes for OMN-12463. * evidence(OMN-12463): self-bind OCC PR #1910 and align all receipt hashes Add dod-occ-pr-1910 self-binding receipt so the OCC merge-eligibility validator finds a PASS receipt bound to this PR (I8), and refresh all six OMN-12463 receipt contract_sha256 to the final contract hash (b82de414) after adding the binding item.
* ci(OMN-12448): pin reusable guard uv setup * evidence(OMN-12448): bind guard hotfix PRs * test(OMN-12448): type workflow YAML loader
…y promotion) (#1915) * ci(OMN-12477): remove hotfix/* bypass from main-target-guard Main now accepts only dev promotion PRs (with promotion-receipt: OCC-N). Deletes the hotfix/* allow-block and updates error messaging to drop hotfix references. OMN-12477 * docs(OMN-12477): add receipt-gate evidence * evidence(OMN-12477): align receipt contract hashes * ci(OMN-12477): refresh receipt gate metadata
* evidence(OMN-12477): bind infra PR 1797 receipt * evidence(OMN-12477): bind OCC PR 1918 receipt
…ce (#1919) Extends the OMN-12477 contract + receipts to cover the 7 code PRs not yet bound: omniclaude #1715, omnibase_core #1182, omniintelligence #694, omnimarket #999, omnidash #167, omnibase_spi #231, omnibase_compat #123. Each receipt records the PR head SHA and status: PASS so Receipt Gate and the DoD Evidence materializer bind every guard PR to this ticket. OMN-12477
…lity-test (#1925) Diagnosis: recon mis-targeted the DB. savings_estimates already materializes in omnibase_infra (the DB the runtime savings projection and projection API use per contract db_io.database=omnibase_infra / OMNIBASE_INFRA_DB_URL) -- 31 positive-savings rows, total $1.2209. The empty table in recon is a vestigial omnidash_analytics copy no writer targets. Reprocessed three genuine recorded delegate-skill-completed events through the running runtime consumer; each emitted projection-savings-applied {projected:true} with correlation binding to delegation_events. No code change, no runtime restart. Defensively reconciled the vestigial omnidash_analytics schema.
…ens regression fix (#1923) * evidence(OMN-12438): add contract and receipt for consumer.py max_tokens regression fix Binds onex-self-extending-agent PR #168 (restore max_tokens=8192 in consumer.py, add test_call_llm_sends_max_tokens_8192 regression guard) to central OCC evidence. * fix(OMN-12438): correct receipt contract_sha256 to valid digest Receipt had 'sha256:pending'; replaced with real digest of OMN-12438.yaml so OCC Eligibility check passes. * fix(OMN-12438): add dod-occ-pr receipt and fix contract_sha256 in all receipts OCC Eligibility was failing because dod-occ-pr receipt was missing and contract_sha256 values were stale. All three files now carry the correct digest aa9861a0ce4b00e07c27317d75f95d7b63bf3b108a3142ba9fbb0de160ee9a5d.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
Superseded by #2012 which is rebased cleanly onto main HEAD. |
jonahgabriel
added a commit
that referenced
this pull request
Jul 28, 2026
…obes The in-repo Receipt Gate (invariant I3) requires a committed PASS receipt per dod_evidence item; the five appended entries had none, so occ-preflight and verify were correctly RED. Not a flake and not a gate to weaken. Each receipt records a REAL execution: the probe was run against the live GitHub API at the durable squash commit 0747500e (exit 0) and at its parent 848d3333 (exit 1). Nothing is asserted that was not observed. commit_sha binds the product squash commit, not a branch head. Dogfoods the fix being evidenced: the first generation pass emitted probe_stdout as a quoted multi-line scalar and yamlfmt corrupted it into #magic___^_^___line markers -- the exact OMN-14714 failure mode, reproduced in this PR own artifact. Regenerated with a literal block-scalar dumper, the remedy #1927 shipped. yamlfmt is now a byte-exact no-op on all five receipts. Refs OMN-14714
jonahgabriel
added a commit
that referenced
this pull request
Jul 28, 2026
…commit, retire the hollow entries (#5272) * evidence(OMN-14714): bind #1927 deliverables at the durable squash commit, retire the hollow entries OMN-14714 previously carried three non-falsifiable entries from autobind companion OCC#5260 (PR-existence probes) and one content probe from OCC#5269 pinned to ad56a5ad -- the unmerged feature-branch head of omnimarket#1927. PR #1927 merged 2026-07-28T06:19:19Z as squash commit 0747500e682c903301bc1bd9eb56578c6dad72af on omnimarket dev. Append five probes bound to that durable ref, one per actual deliverable: - _BlockScalarDumper present (the load-bearing half of the fix) - width=_OCC_YAMLFMT_MAX_LINE_LENGTH present (the second coupled cause) - width=1_000_000, absent, anchored to the code form - pytest.mark.xfail absent from the test module (the acceptance-marker flip) - test_yamlfmt_does_not_corrupt_supersession_multiline_scalars present Each verified by execution 2026-07-28 against the live GitHub API: exit 0 at 0747500e, exit 1 at parent 848d3333553b5838d9ad1635be89e9d89f0f850b. Each classified falsifiable by the gate own classifier (validate_pr_deploy_required.classify_check_value), which reports the three OCC#5260 entries vacuous. Three of the five carry supersedes_dod_evidence markers retiring the hollow entries. Append-only: no existing entry is edited or removed. Refs OMN-14714 * evidence(OMN-14714): retire occ-self-bind-pr-5260 from a product-bound entry No replacement self-bind is minted. Any check reading this PR own contract or diff matches OCC _is_inert_check and the deploy-gate SELF_REFERENTIAL_PATTERNS, so a falsifiable self-bind is a contradiction in terms; the candidate gh api .../pulls/5272/files --jq .patch | grep ... was written, executed (exit 0 while open) and REJECTED on classifying INERT. Retiring the hollow entry from an already-falsifiable product-bound probe is the honest form. Refs OMN-14714 * evidence(OMN-14714): commit PASS receipts for the five durable-ref probes The in-repo Receipt Gate (invariant I3) requires a committed PASS receipt per dod_evidence item; the five appended entries had none, so occ-preflight and verify were correctly RED. Not a flake and not a gate to weaken. Each receipt records a REAL execution: the probe was run against the live GitHub API at the durable squash commit 0747500e (exit 0) and at its parent 848d3333 (exit 1). Nothing is asserted that was not observed. commit_sha binds the product squash commit, not a branch head. Dogfoods the fix being evidenced: the first generation pass emitted probe_stdout as a quoted multi-line scalar and yamlfmt corrupted it into #magic___^_^___line markers -- the exact OMN-14714 failure mode, reproduced in this PR own artifact. Regenerated with a literal block-scalar dumper, the remedy #1927 shipped. yamlfmt is now a byte-exact no-op on all five receipts. Refs OMN-14714
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OCC contract and receipts for OMN-12438 (restore consumer.py max_tokens=8192, add regression guard).
contracts/OMN-12438.yaml: ticket contractdrift/dod_receipts/OMN-12438/dod-sea-pr-168/command.yaml: receipt for onex-self-extending-agent PR chore(contracts): backfill ModelTicketContract for 50 tickets [OMN-8637 wave 6] #168drift/dod_receipts/OMN-12438/dod-occ-pr/command.yaml: receipt for this OCC PROMN-12438