Repository navigation
contract(OMN-10936,10940,10941,10942,10944,10949): add OCC contracts and receipt bundle for 6 tickets - #999
Merged
Conversation
…ra PRs 1586 and 1587 - OMN-10940: add dod-omnibase-infra-pr-1586 evidence binding PR #1586 (E2E golden-chain task-delegated event test) to the OMN-10940 contract - OMN-10941: new contract + receipt for PR #1587 (max_tokens propagation regression tests) Both receipts are required for the receipt-gate Evidence-Source check on PRs 1586 and 1587.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds six contract YAMLs or extends one, plus many drift/dod_receipts command.yaml evidence records; a few receipts had contract_sha256 updates and a migration conflict suppression entry was added. ChangesContract and Evidence Definitions for Regression Tests
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jonahgabriel
enabled auto-merge (squash)
May 13, 2026 21:30
…r 10940/10941/10949 - Add contracts for OMN-10936 (reviewdog-caller omniclaude), OMN-10942 (contract routing policy), OMN-10944 (dashboard projection API contract) - Update OMN-10949 contract to cover infra PR #1588 and market PR #622 in addition to market #616 - Fix contract_sha256 in OMN-10940 receipts (pr-1580, pr-1586) — contract was updated with pr-1586 evidence item, changing the hash - Add contract_sha256 to OMN-10941 pr-1587 receipt (was missing) - Update OMN-10949 pr-616 receipt contract_sha256 to reflect expanded contract - Add receipts: OMN-10936/pr-1582, OMN-10942/pr-621, OMN-10944/pr-620, OMN-10949/pr-1588, OMN-10949/pr-622
- Add deploy-evidence-pricing-version dod_evidence item to satisfy deploy-gate (pricing_manifest_version is additive schema field, no runtime restart needed) - Update contract_sha256 in all OMN-10949 receipts (pr-616, pr-1588, pr-622) to reflect updated contract hash
…ha256 hashes - Add dod-occ-pr-999 evidence items to all 6 ticket contracts (OMN-10936/10940/10941/10942/10944/10949) - Create dod-occ-pr-999/command.yaml self-binding receipts for each ticket - Update all downstream receipt contract_sha256 fields to reflect updated contract hashes - Fixes OCC eligibility pr_ticket_mismatch failure (receipts now bind to OCC PR #999)
jonahgabriel
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
drift/dod_receipts/OMN-10949/dod-occ-pr-999/command.yaml (1)
1-22:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd missing
contract_sha256to this receipt.This receipt is the outlier in OMN-10949
command.yamlentries: all 3 sibling command receipts in the same ticket includecontract_sha256, but this one is missing it. The field is standard across all command receipts in the repository and required for contract-binding checks.🔧 Proposed fix
working_dir: /workspace/onex_change_control +contract_sha256: "sha256:e514df5524d63f95f212050b7676719fcf583a034b9ce1f751cd64d58ed2905d"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@drift/dod_receipts/OMN-10949/dod-occ-pr-999/command.yaml` around lines 1 - 22, Add a top-level contract_sha256 field to this receipt (same place as schema_version/ticket_id/etc.) with the hex SHA-256 string used by the other OMN-10949 command receipts so the file binds to the contract; update the YAML to include contract_sha256: "<actual-64-char-hex>" (matching the exact value used by the sibling receipts) and ensure quoting/spacing matches the existing YAML style and CI schema.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-10942/dod-omnimarket-pr-621/command.yaml`:
- Around line 12-15: The recorded probe_stdout is missing the headRefName field
that probe_command requested; update the probe_stdout JSON to include
"headRefName" with the branch name value (matching the branch recorded later) so
it reflects the --json fields requested by probe_command and keeps
headRefName/headRefOid consistent (refer to probe_command, probe_stdout,
headRefName and headRefOid).
In `@drift/dod_receipts/OMN-10944/dod-omnimarket-pr-620/command.yaml`:
- Around line 12-15: The probe_stdout is missing the headRefName field requested
by probe_command; update the probe_stdout JSON to include
"headRefName":"jonah/omn-10944-dashboard-projection-api-contract" so it matches
the probe_command fields (number,state,headRefName,headRefOid) and the known
branch name, ensuring the probe_stdout object contains headRefName alongside
headRefOid, number, and state.
---
Outside diff comments:
In `@drift/dod_receipts/OMN-10949/dod-occ-pr-999/command.yaml`:
- Around line 1-22: Add a top-level contract_sha256 field to this receipt (same
place as schema_version/ticket_id/etc.) with the hex SHA-256 string used by the
other OMN-10949 command receipts so the file binds to the contract; update the
YAML to include contract_sha256: "<actual-64-char-hex>" (matching the exact
value used by the sibling receipts) and ensure quoting/spacing matches the
existing YAML style and CI schema.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 91d8fe19-fa6b-4ca3-aa32-794b95818e40
📒 Files selected for processing (21)
contracts/OMN-10936.yamlcontracts/OMN-10940.yamlcontracts/OMN-10941.yamlcontracts/OMN-10942.yamlcontracts/OMN-10944.yamlcontracts/OMN-10949.yamldrift/dod_receipts/OMN-10936/dod-occ-pr-999/command.yamldrift/dod_receipts/OMN-10936/dod-omniclaude-pr-1582/command.yamldrift/dod_receipts/OMN-10940/dod-occ-pr-999/command.yamldrift/dod_receipts/OMN-10940/dod-omnibase-infra-pr-1580/command.yamldrift/dod_receipts/OMN-10940/dod-omnibase-infra-pr-1586/command.yamldrift/dod_receipts/OMN-10941/dod-occ-pr-999/command.yamldrift/dod_receipts/OMN-10941/dod-omnibase-infra-pr-1587/command.yamldrift/dod_receipts/OMN-10942/dod-occ-pr-999/command.yamldrift/dod_receipts/OMN-10942/dod-omnimarket-pr-621/command.yamldrift/dod_receipts/OMN-10944/dod-occ-pr-999/command.yamldrift/dod_receipts/OMN-10944/dod-omnimarket-pr-620/command.yamldrift/dod_receipts/OMN-10949/dod-occ-pr-999/command.yamldrift/dod_receipts/OMN-10949/dod-omnibase-infra-pr-1588/command.yamldrift/dod_receipts/OMN-10949/dod-omnimarket-pr-616/command.yamldrift/dod_receipts/OMN-10949/dod-omnimarket-pr-622/command.yaml
The Migration Conflict Check on PR #999 flagged delegation_events as a NAME_CONFLICT between omnibase_infra/078_create_delegation_events.sql (Postgres projection, 22 cols, UUID PK) and omniclaude/001_create_delegation_tables.sql (SQLite hook-side capture, 15 cols, INTEGER PK). Different databases, different access patterns. The omnibase_infra side is the canonical projection consumed by HandlerProjectionDelegation from onex.evt.omniclaude.task-delegated.v1 (OMN-10526). The omniclaude side is the local hook-side store pinned to the projection contract (OMN-10604). Neither shares a Postgres instance with the other. Suppress the conflict using the existing schema_evolution reason — the same pattern already used for llm_call_metrics and savings_estimates, which have an identical infra-vs-omniclaude split. No code changes; this is a CI suppressions update only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dod-omnibase-infra-pr-1586evidence binding omnibase_infra PR contracts(OMN-11985): Wave 3C OCC evidence for omnimarket PRs #800 #801 #802 #803 #1586 (E2E golden-chain test for task-delegated event emission); fixes contract_sha256 in pr-1580 and pr-1586 receiptsOMN-10940
OMN-10941
OMN-10936
OMN-10942
OMN-10944
OMN-10949
Summary by CodeRabbit