Repository navigation
contracts(OMN-12120): add subtask reducer gate evidence - #1631
Merged
Merged
Conversation
|
Warning Review limit reached
More reviews will be available in 30 minutes and 13 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
andywu42
pushed a commit
to andywu42/onex_change_control
that referenced
this pull request
Jun 10, 2026
…de hooks PRs (OmniNode-ai#1317) * evidence(OMN-10837,OMN-8020): add contracts and dod receipts for omniclaude hooks PRs OMN-10837 (PR OmniNode-ai#1630): route tool-content emission through node_emit_daemon - Add contracts/OMN-10837.yaml with enriched dod_evidence - Add receipts: dod-pr-1630-open, dod-focused-tests (113 passed), dod-occ-self OMN-8020 (PR OmniNode-ai#1631): add handler_session_cost_emitter Python handler - Update contracts/OMN-8020.yaml stub -> enriched with real PR + test evidence - Add receipts: dod-pr-1631-open, dod-focused-tests (8 passed), dod-occ-self * fix(OMN-10837,OMN-8020): replace sha256:pending with computed contract hashes * fix(OMN-10837,OMN-8020): replace pending-occ-pr-sha placeholder in self-binding receipts
jonahgabriel
added a commit
that referenced
this pull request
Jul 7, 2026
… landed fix) omnimarket PR #1631 added nested handler{name,module} blocks to node_kb_adr_publisher and node_kreuzberg_parse_effect, clearing their missing_handler_routing violations. Independently re-scanned both handlers via cross_reference() with allowlisted_paths=frozenset() (ignoring the allowlist entirely): both now report zero violations, verdict=compliant. Dropped the two now-stale allowlist entries. Re-ran check-imperative-contracts --repo-root omnimarket --scan-freestanding before/after: compliant_count 180->182 (+2), allowlisted_count 256->254 (-2), new_violation_count 0->0 (unchanged, still green). This is a pure allowlist deletion (zero source-code change) tied directly to the already-landed batch-1 fix -- not a self-authored OCC evidence companion (OMN-14055 out of scope here; the DoD receipts under drift/dod_receipts/OMN-14000/ are untouched). Ref: OMN-14000
jonahgabriel
added a commit
that referenced
this pull request
Jul 7, 2026
…-1 (handler_routing) (#3643) * evidence(OMN-14000): OCC companion for omnimarket #1631 ratchet batch-1 (handler_routing) Adds central OCC evidence for OMN-14000 batch 1 so omnimarket PR #1631 can satisfy Receipt Gate: contracts/OMN-14000-batch1.yaml plus PASS receipts for the gate-verification delta (336->338 compliant) and the omnimarket PR binding. * fix(OMN-14000): rename contract file to match ticket ID exactly The receipt-gate/occ-preflight resolve the pinned contract by exact filename match (contracts/OMN-14000.yaml), not a suffixed variant. Renamed from OMN-14000-batch1.yaml — content and hash unchanged. * fix(OMN-14000): bind OCC companion receipt * evidence(OMN-14000): add deploy scope receipt * evidence(OMN-14000): mark deploy-scope check for gate * ci(OMN-14000): retrigger orphaned runner checks * evidence(OMN-14000): refresh formatted receipt hashes * fix(OMN-14000): drop 2 gate-verified-stale allowlist entries (batch-1 landed fix) omnimarket PR #1631 added nested handler{name,module} blocks to node_kb_adr_publisher and node_kreuzberg_parse_effect, clearing their missing_handler_routing violations. Independently re-scanned both handlers via cross_reference() with allowlisted_paths=frozenset() (ignoring the allowlist entirely): both now report zero violations, verdict=compliant. Dropped the two now-stale allowlist entries. Re-ran check-imperative-contracts --repo-root omnimarket --scan-freestanding before/after: compliant_count 180->182 (+2), allowlisted_count 256->254 (-2), new_violation_count 0->0 (unchanged, still green). This is a pure allowlist deletion (zero source-code change) tied directly to the already-landed batch-1 fix -- not a self-authored OCC evidence companion (OMN-14055 out of scope here; the DoD receipts under drift/dod_receipts/OMN-14000/ are untouched). Ref: OMN-14000 * fix(OMN-14000): drop 40 gate-verified-stale missing_handler_routing entries (slice-1 batch A) Zero-LLM stale-entry sweep per the phase-2 plan (docs/plans/2026-07-06-omn-14000-ratchet-burndown-phase2-plan.md Slice 1). Directly scanned every omnimarket node handler via cross_reference(node_dir, allowlisted_paths=frozenset()) -- i.e. ignoring the allowlist entirely -- and found 157 of the 260 current entries produce ZERO live violations today (the underlying missing_handler_routing debt was already fixed upstream by a prior handler_routing migration; the allowlist line was never pruned). This commit drops the first 40 of those 157 gate-confirmed-stale entries (file order, cap per phase-2 execution slice). No source code touched -- pure allowlist deletion. Verified before/after with the full gate: check-imperative-contracts --repo-root omnimarket --scan-freestanding compliant_count: 182 -> 222 (+40) allowlisted_count: 254 -> 214 (-40) new_violation_count: 0 -> 0 (unchanged, still green) Remaining ~117 gate-confirmed-stale entries are left for a follow-up slice (same method, not yet applied -- avoiding a mega-PR per the plan's guardrails). Ref: OMN-14000 * evidence(OMN-14000): bind omnimarket pr 1641 receipt * ci(OMN-14000): refresh OCC queued checks * ci(OMN-14000): refresh OCC checks after queue drain * ci(OMN-14000): harden OCC standards uv sync * evidence(OMN-14000): make deploy-scope receipt CI-checkable * test(OMN-14103): disambiguate supersession hardening test * ci(OMN-14000): retrigger stale queued checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification