Repository navigation
contracts(OMN-11591): add OCC evidence for generate_reverse_patch implementation - #1629
Merged
Merged
Conversation
|
Warning Review limit reached
More reviews will be available in 43 minutes and 16 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR adds definition-of-done (DoD) evidence collection for ticket OMN-11591. A contract file defines the ticket metadata and four required DoD checks, while three evidence receipt files record that deployment assessment, local validation (mypy + pytest), and upstream PR verification have all passed. ChangesOMN-11591 DoD Evidence Collection
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Adds dod-occ-pr receipt referencing PR #1629 (this PR) to complete the evidence chain for OMN-11591.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@contracts/OMN-11591.yaml`:
- Around line 25-26: The contract's check_value requests headRefOid but the
recorded receipt is missing it; either remove headRefOid from the contract's
check_value to match the recorded output, or update the receipt so the
probe_command and probe_stdout include headRefOid (re-run the command to capture
the actual JSON output) ensuring the contract's check_value, the receipt's
probe_command, and probe_stdout all contain the same JSON fields.
In `@drift/dod_receipts/OMN-11591/dod-local-validation/command.yaml`:
- Around line 19-20: The contract grep is looking for the literal substring '830
passed' but the receipt's actual_output value contains "830/830 contracts suite
passing" (and "10 passed" earlier), so the pattern never matches; either update
the actual_output entry named actual_output to include the exact phrase the
contract expects (e.g., change the string to include "830 passed") or (better)
update the contract's grep pattern that currently searches for '830 passed' in
OMN-11591.yaml to match the real output (for example match "830/830" or "830/830
contracts suite passing"); modify whichever is appropriate so the grep and the
actual_output string align.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 19b9aa16-b105-4438-8c9b-21f82d9f0675
📒 Files selected for processing (4)
contracts/OMN-11591.yamldrift/dod_receipts/OMN-11591/dod-deploy-assessment/command.yamldrift/dod_receipts/OMN-11591/dod-local-validation/command.yamldrift/dod_receipts/OMN-11591/dod-omnibase-core-pr-1154/command.yaml
All four receipt files were missing the required contract_sha256 field. Hash value: sha256:aed523e3b25f851e2313d33cf87eae8a7793d2aba63e401be3f93b4897d45831
andywu42
pushed a commit
to andywu42/onex_change_control
that referenced
this pull request
Jun 10, 2026
…ts for 10 omnibase_infra PRs (OmniNode-ai#1121) * evidence(OMN-11188): batch OCC contracts + receipts for 10 omnibase_infra PRs Unblocks receipt-gate for omnibase_infra closeout batch. Each contract binds to its consumer PR via a dod-infra-pr-<num> receipt with the live head SHA (captured 2026-05-18) verified via gh pr view. Tickets (all part of OMN-11188 platform hardening epic except 11066/11072): - OMN-11066 -> infra OmniNode-ai#1629 (pattern-b-dispatch topic plugin_managed) - OMN-11072 -> infra OmniNode-ai#1628 (omnibase_compat pin guard test) - OMN-11196 -> infra OmniNode-ai#1638 (runtime manifest emission) - OMN-11197 -> infra OmniNode-ai#1641 (runtime_manifests projection) - OMN-11198 -> infra OmniNode-ai#1640 (/v1/introspection/manifest endpoint) - OMN-11199 -> infra OmniNode-ai#1637 (projection contract declarations) - OMN-11200 -> infra OmniNode-ai#1642 (projection freshness SLA monitor) - OMN-11201 -> infra OmniNode-ai#1639 (data_provenance migration) - OMN-11207 -> infra OmniNode-ai#1645 (evidence bundle writer) - OMN-11208 -> infra OmniNode-ai#1643 (seed provenance enforcement, advisory) OMN-7601, OMN-11069, OMN-11142, OMN-11185 are excluded: their OCC contracts already exist on main; they only need Evidence-Source PR body updates (handled separately on each infra PR). * chore: retrigger CI with updated PR body (drop epic mention) * chore: retrigger CI with updated PR title (drop OMN-11188 epic from title) * evidence(OMN-7601): replace placeholder contract with PR-bound contract+receipt Existing OMN-7601 contract on main used placeholder dod-001..dod-004 evidence with no on-disk receipts (validator returns missing_receipt). Replace with a single concrete dod-infra-pr-1632 evidence item plus a real PASS receipt bound to omnibase_infra PR OmniNode-ai#1632 head SHA b1770ada (verified live). Unblocks omnibase_infra PR OmniNode-ai#1632 receipt-gate alongside the other 10 contracts in this batch. * evidence(OMN-11196,OMN-11197,OMN-11198): add dod-occ-pr-1121 self-binding receipts PR 1121's verify failed with pr_ticket_mismatch — receipts only bound to downstream infra PRs (1638/1641/1640). Receipt-gate requires at least one PASS receipt bound to the OCC PR's own number per [[reference_occ_receipt_binding]]. Adds self-binding receipts for the 3 tickets cited in this OCC PR's title.
andywu42
pushed a commit
to andywu42/onex_change_control
that referenced
this pull request
Jun 10, 2026
…#1311) * docs(OMN-7980): bind omniclaude PR 1629 receipt evidence Adds drift/dod_receipts/OMN-7980/dod-omniclaude-pr-1629/command.yaml with a PASS receipt binding to omniclaude PR OmniNode-ai#1629 (feat(OMN-7980): wire OpenRouter delegation backend, head SHA: a55a8f91708ec205deb780d8ff6f905b0a75ab74). Updates contracts/OMN-7980.yaml to add the dod-omniclaude-pr-1629 evidence item so the receipt gate can resolve the binding. [skip-receipt-gate: occ-self-evidence] * docs(OMN-7980): add self-binding OCC PR 1311 receipt for receipt gate Adds drift/dod_receipts/OMN-7980/dod-occ-pr-1311/command.yaml and updates contracts/OMN-7980.yaml so OCC PR OmniNode-ai#1311's own receipt gate can verify that a PASS receipt exists binding to this PR. Also fixes yamlfmt formatting on contracts/OMN-7980.yaml from the first commit. * docs(OMN-7980): add contract_sha256 to all receipts per OMN-10421 All four OMN-7980 receipts (dod-wave-local-evidence, dod-occ-pr-1204, dod-omniclaude-pr-1629, dod-occ-pr-1311) were produced after 2026-04-30 and require the contract_sha256 field per OMN-10421. contract_sha256: sha256:0dd4dbe9b0adf6e2141183334d22617151b71c43df4cefeebc44e6c7e415de01
jonahgabriel
added a commit
that referenced
this pull request
Jul 7, 2026
…3642) * evidence(OMN-14001): add learning loop receipts * evidence(OMN-14001): bind OCC self receipt * evidence(OMN-14001): add deploy scope receipt * evidence(OMN-14001): bind OCC self receipt to PR * evidence(OMN-14001): mark deploy-scope check for gate * evidence(OMN-14001): make deploy-scope receipt check CI-safe * ci(OMN-14001): refresh stale imperative guard * evidence(OMN-14001): resolve receipt review findings * fix(OMN-14001): format OCC self receipt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contracts/OMN-11591.yamlcontract for the generate_reverse_patch decision gate ticketdrift/dod_receipts/OMN-11591/with receipts for: PR existence, local validation, deploy assessment, and this OCC PRverify / verifyreceipt gate on omnibase_core PR evidence(OMN-7465): add remote delegation receipts #1154Linked PR
omnibase_core PR #1154:
feat(OMN-11591): implement generate_reverse_patch decision gateEvidence
contract_diff_computer.pyEvidence-Source: OCC#1626
Summary by CodeRabbit