Repository navigation
contracts(OMN-12151): add OCC evidence for result-applier None-suppression fix - #1642
Merged
Merged
Conversation
…ssion fix Adds central OCC evidence for the two-repo fix that suppresses premature terminal event publication from DispatchResultApplier when handle_async returns None (multi-step FSM orchestrators). Evidence bundle: - contracts/OMN-12151.yaml: contract with dod_evidence items - dod-infra-pr-1745: omnibase_infra PR #1745 fix receipt - dod-omnimarket-pr-884: omnimarket PR #884 fix receipt - dod-tests-pass: unit test pass receipt for both repos - dod-runtime-deploy: deploy gate evidence (Build Runtime Image CI job) - dod-occ-pr: this OCC PR receipt
|
Warning Review limit reached
More reviews will be available in 41 minutes and 46 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
- Remove invalid 'runtime' from interfaces_touched (only protocols/events/topics/envelopes/public_api allowed) - Rename receipt dir dod-omnimarket-pr-884 → dod-omnimarket-pr-887 to match actual PR and contract id - Update receipt evidence_item_id, check_value, probe_command, and probe_stdout to reference PR #887 - Fix summary text: PR #884 → PR #887
ModelDodReceipt requires commit_sha; the receipt was missing this field, causing OCC eligibility check to fail with a Pydantic validation error.
ModelDodReceipt has extra="forbid"; the notes field is not in the schema and caused OCC eligibility to reject the receipt.
Receipts produced after 2026-04-30 must include contract_sha256 per OMN-10421 policy. Add the sha256 of contracts/OMN-12151.yaml to all 5 receipts so the receipt gate accepts them.
andywu42
pushed a commit
to andywu42/onex_change_control
that referenced
this pull request
Jun 10, 2026
…ts for 10 omnibase_infra PRs (OmniNode-ai#1121) * evidence(OMN-11188): batch OCC contracts + receipts for 10 omnibase_infra PRs Unblocks receipt-gate for omnibase_infra closeout batch. Each contract binds to its consumer PR via a dod-infra-pr-<num> receipt with the live head SHA (captured 2026-05-18) verified via gh pr view. Tickets (all part of OMN-11188 platform hardening epic except 11066/11072): - OMN-11066 -> infra OmniNode-ai#1629 (pattern-b-dispatch topic plugin_managed) - OMN-11072 -> infra OmniNode-ai#1628 (omnibase_compat pin guard test) - OMN-11196 -> infra OmniNode-ai#1638 (runtime manifest emission) - OMN-11197 -> infra OmniNode-ai#1641 (runtime_manifests projection) - OMN-11198 -> infra OmniNode-ai#1640 (/v1/introspection/manifest endpoint) - OMN-11199 -> infra OmniNode-ai#1637 (projection contract declarations) - OMN-11200 -> infra OmniNode-ai#1642 (projection freshness SLA monitor) - OMN-11201 -> infra OmniNode-ai#1639 (data_provenance migration) - OMN-11207 -> infra OmniNode-ai#1645 (evidence bundle writer) - OMN-11208 -> infra OmniNode-ai#1643 (seed provenance enforcement, advisory) OMN-7601, OMN-11069, OMN-11142, OMN-11185 are excluded: their OCC contracts already exist on main; they only need Evidence-Source PR body updates (handled separately on each infra PR). * chore: retrigger CI with updated PR body (drop epic mention) * chore: retrigger CI with updated PR title (drop OMN-11188 epic from title) * evidence(OMN-7601): replace placeholder contract with PR-bound contract+receipt Existing OMN-7601 contract on main used placeholder dod-001..dod-004 evidence with no on-disk receipts (validator returns missing_receipt). Replace with a single concrete dod-infra-pr-1632 evidence item plus a real PASS receipt bound to omnibase_infra PR OmniNode-ai#1632 head SHA b1770ada (verified live). Unblocks omnibase_infra PR OmniNode-ai#1632 receipt-gate alongside the other 10 contracts in this batch. * evidence(OMN-11196,OMN-11197,OMN-11198): add dod-occ-pr-1121 self-binding receipts PR 1121's verify failed with pr_ticket_mismatch — receipts only bound to downstream infra PRs (1638/1641/1640). Receipt-gate requires at least one PASS receipt bound to the OCC PR's own number per [[reference_occ_receipt_binding]]. Adds self-binding receipts for the 3 tickets cited in this OCC PR's title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Central OCC evidence for OMN-12151: two-repo fix that suppresses premature terminal event publication from
DispatchResultApplierwhenhandle_asyncreturnsNone.DispatchResultApplier.apply()to acceptModelDispatchResult | Nonehandle_asyncreturnNonefor non-terminal FSM statesEvidence Bundle
contracts/OMN-12151.yaml: contract with all dod_evidence itemsdod-infra-pr-1745: omnibase_infra PR evidence(OMN-12245): refresh omniintelligence release gates #1745 receiptdod-omnimarket-pr-887: omnimarket PR docs(OMN-10419): add dod-004 receipt binding omnibase_core#1055 to OMN-10419 #887 receiptdod-tests-pass: unit tests pass in both reposdod-runtime-deploy: deploy gate evidence (Build Runtime Image CI job passed on PR evidence(OMN-12245): refresh omniintelligence release gates #1745)dod-occ-pr: this OCC PR itself as evidenceEvidence-Source: OCC#1642
Evidence-Ticket: OMN-12151