top-level/stage: assert no by-name overwrites#483820
Open
qweered wants to merge 1 commit intoNixOS:masterfrom
Open
top-level/stage: assert no by-name overwrites#483820qweered wants to merge 1 commit intoNixOS:masterfrom
qweered wants to merge 1 commit intoNixOS:masterfrom
Conversation
This was referenced Jan 26, 2026
Merged
This was referenced Jan 31, 2026
Contributor
Author
|
Everything ready, we just need to merge those prs |
Contributor
Author
|
cc @mdaniels5757 @gepbird, would appreciate your review/merge for prs marked as unchecked |
Member
|
I'm subscribed to all of them, and merged the unmaintained ones or the ones approved by all maintainers. Per maintainers/README.md, I'll wait a week for the others. |
This comment was marked as resolved.
This comment was marked as resolved.
3 tasks
Contributor
I've gone ahead and merged some of the trivial ones early. Sorry to any maintainers who object; feel free to shout at me or open followup PRs if needed. |
2 tasks
qweered
force-pushed
the
no-by-name-overrides
branch
from
19b5914 to
ce81ca8
Compare
98 tasks
Contributor
Author
This asserts that no by-name packages are overwritten by definitions in all-packages.nix.
13 tasks
qweered
force-pushed
the
no-by-name-overrides
branch
from
ce81ca8 to
47c6688
Compare
2 tasks
13 tasks
mdaniels5757
added a commit
to mdaniels5757/nixpkgs
that referenced
this pull request
Mar 8, 2026
This is a step towards NixOS#483820, which will help enable checking for additional by-name directories (e.g. Python) in nixpkgs-vet. ## Things done <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. --> - [ ] 0 rebuilds. - [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs. [NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests [Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests [nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage [CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md [lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests [maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md [nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests [pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md [pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
2 tasks
Videl
pushed a commit
to Videl/nixpkgs
that referenced
this pull request
Mar 9, 2026
This is a step towards NixOS#483820, which will help enable checking for additional by-name directories (e.g. Python) in nixpkgs-vet. ## Things done <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. --> - [ ] 0 rebuilds. - [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs. [NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests [Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests [nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage [CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md [lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests [maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md [nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests [pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md [pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
stepbrobd
pushed a commit
to stepbrobd/nixpkgs
that referenced
this pull request
Mar 9, 2026
This is a step towards NixOS#483820, which will help enable checking for additional by-name directories (e.g. Python) in nixpkgs-vet. ## Things done <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. --> - [ ] 0 rebuilds. - [x] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs. [NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests [Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests [nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage [CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md [lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests [maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md [nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests [pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md [pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This asserts that no by-name packages are overwritten by definitions in all-packages.nix.
Resurrection of #454525
Remaining packages with overrides:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.