Skip to content

rescript-language-server: use scopes as arguments, remove all-packages.nix override#484594

Merged
gepbird merged 1 commit intoNixOS:masterfrom
mdaniels5757:rescript-language-server-override
Jan 28, 2026
Merged

rescript-language-server: use scopes as arguments, remove all-packages.nix override#484594
gepbird merged 1 commit intoNixOS:masterfrom
mdaniels5757:rescript-language-server-override

Conversation

@mdaniels5757
Copy link
Member

@mdaniels5757 mdaniels5757 commented Jan 28, 2026

Split from #474456.

This is a step towards #454525/#483820, which will help enable checking for additional by-name directories (e.g. Python) in nixpkgs-vet.

For more information, please see #483859 (comment).

Things done

@nixpkgs-ci nixpkgs-ci bot requested a review from RossSmyth January 28, 2026 01:02
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 28, 2026
Copy link
Contributor

@RossSmyth RossSmyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 28, 2026
@gepbird gepbird added this pull request to the merge queue Jan 28, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 28, 2026
Merged via the queue into NixOS:master with commit 54dfdcc Jan 28, 2026
37 of 39 checks passed
@mdaniels5757 mdaniels5757 deleted the rescript-language-server-override branch January 28, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants