Skip to content

bitwuzla: move override into package.nix#485692

Merged
MattSturgeon merged 1 commit intoNixOS:masterfrom
qweered:bitwuzla-move-overrides
Feb 3, 2026
Merged

bitwuzla: move override into package.nix#485692
MattSturgeon merged 1 commit intoNixOS:masterfrom
qweered:bitwuzla-move-overrides

Conversation

@qweered
Copy link
Contributor

@qweered qweered commented Jan 31, 2026

This is a step towards #454525, which will help enable checking for additional by-name directories (e.g. Python) in nixpkgs-vet.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@qweered qweered requested a review from mdaniels5757 January 31, 2026 19:02
@nixpkgs-ci nixpkgs-ci bot requested a review from symphorien January 31, 2026 19:03
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 31, 2026
@gepbird
Copy link
Contributor

gepbird commented Feb 2, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 485692
Commit: 4c848c75668a02edef8950a42c3d0877fbe47da7 (subsequent changes)
Merge: 94eb7456c50c6701e8db1d63dae716e5fdbcff33

Logs: https://github.com/gepbird/nixpkgs-review-gha/actions/runs/21573778487

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-485692-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://gepbird-nixpkgs-review-gha.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      gepbird-nixpkgs-review-gha.cachix.org-1:DXx7aJqJyRfrgSacf/SSVzEaPbrH3lych7ti/zUBol4=
      ' \
      /nix/store/cbsb7b142z2qk6r7ynnmrjfngn3qhalq-bitwuzla-0.8.2
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-485692-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://gepbird-nixpkgs-review-gha.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      gepbird-nixpkgs-review-gha.cachix.org-1:DXx7aJqJyRfrgSacf/SSVzEaPbrH3lych7ti/zUBol4=
      ' \
      /nix/store/gk1s63pik0scikkd2n68f3dqssndh5sn-bitwuzla-0.8.2
  • x86_64-darwin
    nix-store -r --add-root nixpkgs-pr-485692-x86_64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://gepbird-nixpkgs-review-gha.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      gepbird-nixpkgs-review-gha.cachix.org-1:DXx7aJqJyRfrgSacf/SSVzEaPbrH3lych7ti/zUBol4=
      ' \
      /nix/store/516w0wa4xfckbsc1fnv88yg1j3iwzz6y-bitwuzla-0.8.2
  • aarch64-darwin
    nix-store -r --add-root nixpkgs-pr-485692-aarch64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://gepbird-nixpkgs-review-gha.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      gepbird-nixpkgs-review-gha.cachix.org-1:DXx7aJqJyRfrgSacf/SSVzEaPbrH3lych7ti/zUBol4=
      ' \
      /nix/store/l8pb2cqr5bwh80q99m9jpc58ygh4xrw8-bitwuzla-0.8.2

x86_64-linux

✅ 1 package built:
  • bitwuzla

aarch64-linux

✅ 1 package built:
  • bitwuzla

x86_64-darwin (sandbox = relaxed)

✅ 1 package built:
  • bitwuzla

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • bitwuzla

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 2, 2026
gtest,
gmp,
cadical,
cadical' ? cadical.override { version = "2.1.3"; },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick. I usually avoid such ? defaults on callPackage args, however I think we can be confident a ' (prime) suffixed name won't get supplied from the auto-args pkgs.

@MattSturgeon MattSturgeon added this pull request to the merge queue Feb 3, 2026
Merged via the queue into NixOS:master with commit ef8e2de Feb 3, 2026
37 of 39 checks passed
@qweered qweered deleted the bitwuzla-move-overrides branch February 19, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants