Skip to content

cvc5: move override into package.nix, modernize#485691

Merged
MattSturgeon merged 1 commit intoNixOS:masterfrom
qweered:cvc5-move-overrides
Feb 3, 2026
Merged

cvc5: move override into package.nix, modernize#485691
MattSturgeon merged 1 commit intoNixOS:masterfrom
qweered:cvc5-move-overrides

Conversation

@qweered
Copy link
Contributor

@qweered qweered commented Jan 31, 2026

This is a step towards #454525, which will help enable checking for additional by-name directories (e.g. Python) in nixpkgs-vet.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@qweered qweered requested a review from mdaniels5757 January 31, 2026 19:01
@nixpkgs-ci nixpkgs-ci bot requested a review from shadaj January 31, 2026 19:03
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jan 31, 2026
@qweered
Copy link
Contributor Author

qweered commented Jan 31, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 485691
Commit: 0ee834e65514d0e171b65e343defb969efad79ae (subsequent changes)
Merge: 4376c8a1c059573995e8f2e6c92502e614cf76d6

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/21549397158


x86_64-linux

✅ 5 packages built:
  • cvc5
  • isabelle
  • isabelle-components.isabelle-linter
  • key
  • tlaps

aarch64-linux

✅ 5 packages built:
  • cvc5
  • isabelle
  • isabelle-components.isabelle-linter
  • key
  • tlaps

x86_64-darwin (sandbox = false)

❌ 1 package failed to build:
  • tlaps
✅ 4 packages built:
  • cvc5
  • isabelle
  • isabelle-components.isabelle-linter
  • key

Error logs: `x86_64-darwin`
tlaps
  cp zenon.bin zenon; \
        else \
  cp zenon.byt zenon; \
fi
: -q zenon.v
: -q zenon_coqbool.v
: -q zenon_equiv.v
: -q zenon_induct.v
: -q zenon_focal.v
mkdir -p "/nix/store/w95jbas4q7lz12j3z7a4y3949k4hnn36-tlaps-1.4.5/bin"
cp zenon "/nix/store/w95jbas4q7lz12j3z7a4y3949k4hnn36-tlaps-1.4.5/bin/"
mkdir -p "/nix/store/w95jbas4q7lz12j3z7a4y3949k4hnn36-tlaps-1.4.5/lib"
cp zenon.v zenon_coqbool.v zenon_equiv.v zenon_induct.v zenon_focal.v "/nix/store/w95jbas4q7lz12j3z7a4y3949k4hnn36-tlaps-1.4.5/lib/"
for i in zenon.vo zenon_coqbool.vo zenon_equiv.vo zenon_induct.vo zenon_focal.vo; \
  do [ ! -f $i ] || cp $i "/nix/store/w95jbas4q7lz12j3z7a4y3949k4hnn36-tlaps-1.4.5/lib/"; \
done
/nix/build/nix-14835-4239561832/tlaps-1.4.5
/nix/build/nix-14835-4239561832/tlaps-1.4.5/isabelle /nix/build/nix-14835-4239561832/tlaps-1.4.5
*** I/O error: /tmp/isabelle-/bash_timing14592739318769060706
*** The error(s) above occurred in session "Pure" (line 3 of "/nix/store/kybsi3jcab1mcd94nrzcfxrmxa5jqm7d-isabelle-2025-2/Isabelle2025-2/src/Pure/ROOT")

aarch64-darwin (sandbox = false)

❌ 2 packages failed to build:
  • key
  • tlaps
✅ 3 packages built:
  • cvc5
  • isabelle
  • isabelle-components.isabelle-linter

Error logs: `aarch64-darwin`
tlaps
  cp zenon.bin zenon; \
        else \
  cp zenon.byt zenon; \
fi
: -q zenon.v
: -q zenon_coqbool.v
: -q zenon_equiv.v
: -q zenon_induct.v
: -q zenon_focal.v
mkdir -p "/nix/store/cznnx1cvjvbj3ccwij8l1h40vrv2bn6b-tlaps-1.4.5/bin"
cp zenon "/nix/store/cznnx1cvjvbj3ccwij8l1h40vrv2bn6b-tlaps-1.4.5/bin/"
mkdir -p "/nix/store/cznnx1cvjvbj3ccwij8l1h40vrv2bn6b-tlaps-1.4.5/lib"
cp zenon.v zenon_coqbool.v zenon_equiv.v zenon_induct.v zenon_focal.v "/nix/store/cznnx1cvjvbj3ccwij8l1h40vrv2bn6b-tlaps-1.4.5/lib/"
for i in zenon.vo zenon_coqbool.vo zenon_equiv.vo zenon_induct.vo zenon_focal.vo; \
  do [ ! -f $i ] || cp $i "/nix/store/cznnx1cvjvbj3ccwij8l1h40vrv2bn6b-tlaps-1.4.5/lib/"; \
done
/nix/build/nix-4586-1711704025/tlaps-1.4.5
/nix/build/nix-4586-1711704025/tlaps-1.4.5/isabelle /nix/build/nix-4586-1711704025/tlaps-1.4.5
*** I/O error: /tmp/isabelle-/bash_timing5712103515772202431
*** The error(s) above occurred in session "Pure" (line 3 of "/nix/store/wmrgm1sywmb86qycynhmjhkzvy7wnpgs-isabelle-2025-2/Isabelle2025-2/src/Pure/ROOT")

Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, diff looks good!

Related: #178468

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 2, 2026
@gepbird
Copy link
Contributor

gepbird commented Feb 2, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 485691
Commit: 0ee834e65514d0e171b65e343defb969efad79ae


x86_64-linux

✅ 5 packages built:
  • cvc5
  • isabelle
  • isabelle-components.isabelle-linter
  • key
  • tlaps

@MattSturgeon MattSturgeon added this pull request to the merge queue Feb 3, 2026
Merged via the queue into NixOS:master with commit 22ac996 Feb 3, 2026
36 of 38 checks passed
@qweered qweered deleted the cvc5-move-overrides branch February 19, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants