Skip to content

openshadinglanguage: move override to package.nix#495553

Merged
mdaniels5757 merged 1 commit intoNixOS:masterfrom
mdaniels5757:remove-by-name-override-openshadinglanguage
Mar 1, 2026
Merged

openshadinglanguage: move override to package.nix#495553
mdaniels5757 merged 1 commit intoNixOS:masterfrom
mdaniels5757:remove-by-name-override-openshadinglanguage

Conversation

@mdaniels5757
Copy link
Member

@mdaniels5757 mdaniels5757 commented Mar 1, 2026

This is a step towards #483820, which will help enable checking for additional by-name directories (e.g. Python) in nixpkgs-vet.

For more information, please see https://github.com/NixOS/nixpkgs/pull/483859#issuecomment-3799768711.

Things done

This is a step towards https://github.com/NixOS/nixpkgs/pull/483820,
which will help enable checking for additional by-name directories
(e.g. Python) in nixpkgs-vet.

For more information, please see https://github.com/NixOS/nixpkgs/pull/483859#issuecomment-3799768711.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 1, 2026
@mdaniels5757 mdaniels5757 marked this pull request as ready for review March 1, 2026 17:13
@nixpkgs-ci nixpkgs-ci bot requested a review from Hodapp87 March 1, 2026 17:17
@mdaniels5757 mdaniels5757 requested review from gepbird and qweered March 1, 2026 17:30
Copy link
Contributor

@qweered qweered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff lgtm

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Mar 1, 2026
@mdaniels5757
Copy link
Member Author

Given that Hodapp87 has been inactive and not responding to PRs requesting their review for years, I don't think we need to wait a week.

@mdaniels5757 mdaniels5757 enabled auto-merge March 1, 2026 17:57
@mdaniels5757 mdaniels5757 disabled auto-merge March 1, 2026 17:58
@mdaniels5757 mdaniels5757 added this pull request to the merge queue Mar 1, 2026
Merged via the queue into NixOS:master with commit 0b2e2c1 Mar 1, 2026
32 checks passed
@mdaniels5757 mdaniels5757 deleted the remove-by-name-override-openshadinglanguage branch March 1, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants