top-level/stage: assert no callPackage with by-name paths#489120
Draft
qweered wants to merge 1 commit intoNixOS:masterfrom
Draft
top-level/stage: assert no callPackage with by-name paths#489120qweered wants to merge 1 commit intoNixOS:masterfrom
qweered wants to merge 1 commit intoNixOS:masterfrom
Conversation
This asserts that no packages in all-packages.nix use callPackage with
paths pointing to pkgs/by-name/. Instead, packages should use
<package>.override { } to customize by-name packages.
qweered
force-pushed
the
no-callpackage-by-name
branch
from
61b3929 to
bf7550d
Compare
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When packages are moved to
pkgs/by-name/, they should no longer be called usingcallPackageinall-packages.nix. Instead, variants and customizations should use<package>.override { }.Using
callPackagewith by-name paths:This PR adds an assertion that detects and reports all attributes in
all-packages.nixthat usecallPackagewith a path pointing topkgs/by-name/.This is the next step after #483820
Remaining packages (122 total)
How to fix
Replace:
With: