Skip to content

glib: move glib-untested overrides into package.nix#485673

Merged
gepbird merged 1 commit intoNixOS:masterfrom
qweered:glib-move-overrides
Feb 12, 2026
Merged

glib: move glib-untested overrides into package.nix#485673
gepbird merged 1 commit intoNixOS:masterfrom
qweered:glib-move-overrides

Conversation

@qweered
Copy link
Contributor

@qweered qweered commented Jan 31, 2026

Split from #474456. Diff is not scary actually, please review without whitespaces difference enabled in github ui

This is a step towards #454525, which will help enable checking for additional by-name directories (e.g. Python) in nixpkgs-vet.

Things done

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 31, 2026
@qweered qweered force-pushed the glib-move-overrides branch from 9bbec28 to f9a0c44 Compare January 31, 2026 17:46
@qweered qweered requested a review from mdaniels5757 January 31, 2026 18:05
@qweered qweered force-pushed the glib-move-overrides branch 2 times, most recently from 82fb300 to d8c932a Compare February 10, 2026 01:07
@nixpkgs-ci nixpkgs-ci bot requested a review from a team February 10, 2026 01:13
@qweered qweered force-pushed the glib-move-overrides branch 2 times, most recently from 82ed4ec to 6bc86e8 Compare February 10, 2026 01:28
Move the dbus, shared-mime-info, and desktop-file-utils overrides into
package.nix and remove the all-packages.nix entry

The glib-untested pattern is kept to break dependency cycles: these
packages depend on glib, so using them directly in nativeCheckInputs
would cause errors when building glib.tests.withChecks.
@qweered qweered force-pushed the glib-move-overrides branch from 6bc86e8 to 5f987f2 Compare February 10, 2026 01:36
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 10, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 10, 2026
@gepbird gepbird added this pull request to the merge queue Feb 12, 2026
Merged via the queue into NixOS:master with commit 11e0340 Feb 12, 2026
30 checks passed
@qweered qweered deleted the glib-move-overrides branch February 19, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants