gopro-tool: move overrides to package.nix, modernize

[qweered]

Split from #474456.

This is a step towards #454525, which will help enable checking for additional by-name directories (e.g. Python) in nixpkgs-vet.

Things done

• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

[qweered]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 485675
Commit: 550574761780f58f6e6e28ec2a4a40e6b28b275e

---

x86_64-linux

✅ 1 package built:

• gopro-tool

[MattSturgeon]

Compared with when I last reviewed, the commit now mixes several unrelated changes. Per the nixpkgs commit conventions, each logical change should be split into its own commit. That keeps the history clean and makes the review process much easier. In this case, it could be separated roughly as:

1. Moving the package into pkgs/by-name
2. Enabling strictDeps and structuredAttrs
3. Adding passthru.tests
4. Updating 0-unstable-2024-04-18 → 1.18

Once that's resolved, the overall diff looks good to me. However, since the scope has grown from “move to by-name” into a broader “update and cleanup,” I'd prefer to get the maintainer's ACK before merging.

[gepbird]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 485675 --package gopro-tool.tests
Commit: 662fd4baf42ff3ffe1fb8d61abcad16bb7e6d661

---

x86_64-linux

✅ 1 package built:

• gopro-tool.tests.gopro-tool

[gepbird]

Diff looks good.

The 1.18 tag points to the rev that we used previously :)