Skip to content

mkgmap, mkgmap-splitter: migrate to by-name, modernize#485710

Merged
gepbird merged 5 commits intoNixOS:masterfrom
qweered:mkgmap-by-name-v2
Feb 10, 2026
Merged

mkgmap, mkgmap-splitter: migrate to by-name, modernize#485710
gepbird merged 5 commits intoNixOS:masterfrom
qweered:mkgmap-by-name-v2

Conversation

@qweered
Copy link
Contributor

@qweered qweered commented Jan 31, 2026 •
edited
Loading

Things done

Final push towards #483820

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@qweered qweered mentioned this pull request Jan 31, 2026
Open
46 tasks
@nixpkgs-ci nixpkgs-ci bot requested a review from sikmir January 31, 2026 19:45
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jan 31, 2026
@qweered qweered changed the title mkgmap, mkgmap-splitter: migrate to by-name mkgmap, mkgmap-splitter: migrate to by-name, modernize Jan 31, 2026
gepbird
gepbird reviewed Feb 2, 2026
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please split the changes into separate commits. Most notably testinput.nix history is "lost" as there's a removed and added file. Updates to the patch, regenerating deps.nix, doing the by-name migration are a bit too much in a single commit.

@qweered qweered force-pushed the mkgmap-by-name-v2 branch 2 times, most recently from 6f12d9b to f6e470a Compare February 10, 2026 02:03
@qweered
Copy link
Contributor Author

qweered commented Feb 10, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 485710
Commit: f6e470a10a026c43811814e99b651efa42ac5ab9 (subsequent changes)
Merge: 3ad4f579c09ed672361316077c7793962aff2ae2

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/21848876401

x86_64-linux

✅ 2 packages built:
  • mkgmap
  • mkgmap-splitter

aarch64-linux

✅ 2 packages built:
  • mkgmap
  • mkgmap-splitter

x86_64-darwin (sandbox = false)

✅ 2 packages built:
  • mkgmap
  • mkgmap-splitter

aarch64-darwin (sandbox = false)

✅ 2 packages built:
  • mkgmap
  • mkgmap-splitter

gepbird
gepbird reviewed Feb 10, 2026
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, mostly looks good.

@qweered
Copy link
Contributor Author

qweered commented Feb 10, 2026

there is no tag support for fetchSvn sadly, implemented all other changes

gepbird
gepbird reviewed Feb 10, 2026
View reviewed changes
@gepbird
Copy link
Contributor

gepbird commented Feb 10, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 485710
Commit: 4c53d818c0fd053a690bc7a903a2f3037adcd4d0

x86_64-linux

✅ 2 packages built:
  • mkgmap
  • mkgmap-splitter

@gepbird gepbird added this pull request to the merge queue Feb 10, 2026
Merged via the queue into NixOS:master with commit 566326d Feb 10, 2026
26 checks passed
@qweered qweered deleted the mkgmap-by-name-v2 branch February 19, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gepbird gepbird gepbird approved these changes

@sikmir sikmir Awaiting requested review from sikmir

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qweered @gepbird