Skip to content

archisteamfarm: rename, move to by-name#485695

Merged
MattSturgeon merged 1 commit intoNixOS:masterfrom
qweered:archisteamfarm-move-overrides
Feb 3, 2026
Merged

archisteamfarm: rename, move to by-name#485695
MattSturgeon merged 1 commit intoNixOS:masterfrom
qweered:archisteamfarm-move-overrides

Conversation

@qweered
Copy link
Contributor

@qweered qweered commented Jan 31, 2026

This is a step towards #454525, which will help enable checking for additional by-name directories (e.g. Python) in nixpkgs-vet.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested a review from SuperSandro2000 January 31, 2026 19:03
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 31, 2026
@qweered qweered requested a review from mdaniels5757 January 31, 2026 19:03
@qweered
Copy link
Contributor Author

qweered commented Jan 31, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 485695
Commit: ae2192022faf4471107e7d93ffc70841e2836977 (subsequent changes)
Merge: 9b9cb4ed2eb58e9b291f60ee92533980de3a80d5

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/21549394371


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
❌ 1 package failed to build:
  • archisteamfarm

Error logs: `x86_64-linux`
archisteamfarm
Test Run Successful.
Total tests: 84
     Passed: 82
    Skipped: 2
 Total time: 1.2003 Seconds
Finished dotnetCheckHook
Running phase: installPhase
@nix { "action": "setPhase", "phase": "installPhase" }
Executing dotnetInstallHook
  ArchiSteamFarm -> /nix/store/qf8g0bh02avzkg3srfc8b1y7jb7xwyp1-archisteamfarm-6.3.1.6/lib/archisteamfarm/
Publishing plugin ArchiSteamFarm.OfficialPlugins.ItemsMatcher
  ArchiSteamFarm.OfficialPlugins.ItemsMatcher -> /nix/store/qf8g0bh02avzkg3srfc8b1y7jb7xwyp1-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/plugins/ArchiSteamFarm.OfficialPlugins.ItemsMatcher/
Publishing plugin ArchiSteamFarm.OfficialPlugins.MobileAuthenticator
  ArchiSteamFarm.OfficialPlugins.MobileAuthenticator -> /nix/store/qf8g0bh02avzkg3srfc8b1y7jb7xwyp1-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/plugins/ArchiSteamFarm.OfficialPlugins.MobileAuthenticator/
Publishing plugin ArchiSteamFarm.OfficialPlugins.Monitoring
  ArchiSteamFarm.OfficialPlugins.Monitoring -> /nix/store/qf8g0bh02avzkg3srfc8b1y7jb7xwyp1-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/plugins/ArchiSteamFarm.OfficialPlugins.Monitoring/
Publishing plugin ArchiSteamFarm.OfficialPlugins.SteamTokenDumper
  ArchiSteamFarm.OfficialPlugins.SteamTokenDumper -> /nix/store/qf8g0bh02avzkg3srfc8b1y7jb7xwyp1-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/plugins/ArchiSteamFarm.OfficialPlugins.SteamTokenDumper/
chmod: cannot access '/nix/store/qf8g0bh02avzkg3srfc8b1y7jb7xwyp1-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/ArchiSteamFarm.dll': No such file or directory

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
❌ 1 package failed to build:
  • archisteamfarm

Error logs: `aarch64-linux`
archisteamfarm
Test Run Successful.
Total tests: 84
     Passed: 82
    Skipped: 2
 Total time: 0.9946 Seconds
Finished dotnetCheckHook
Running phase: installPhase
@nix { "action": "setPhase", "phase": "installPhase" }
Executing dotnetInstallHook
  ArchiSteamFarm -> /nix/store/54f3fi78ndprgw2jmfg8ng8h0nc8kyjn-archisteamfarm-6.3.1.6/lib/archisteamfarm/
Publishing plugin ArchiSteamFarm.OfficialPlugins.ItemsMatcher
  ArchiSteamFarm.OfficialPlugins.ItemsMatcher -> /nix/store/54f3fi78ndprgw2jmfg8ng8h0nc8kyjn-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/plugins/ArchiSteamFarm.OfficialPlugins.ItemsMatcher/
Publishing plugin ArchiSteamFarm.OfficialPlugins.MobileAuthenticator
  ArchiSteamFarm.OfficialPlugins.MobileAuthenticator -> /nix/store/54f3fi78ndprgw2jmfg8ng8h0nc8kyjn-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/plugins/ArchiSteamFarm.OfficialPlugins.MobileAuthenticator/
Publishing plugin ArchiSteamFarm.OfficialPlugins.Monitoring
  ArchiSteamFarm.OfficialPlugins.Monitoring -> /nix/store/54f3fi78ndprgw2jmfg8ng8h0nc8kyjn-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/plugins/ArchiSteamFarm.OfficialPlugins.Monitoring/
Publishing plugin ArchiSteamFarm.OfficialPlugins.SteamTokenDumper
  ArchiSteamFarm.OfficialPlugins.SteamTokenDumper -> /nix/store/54f3fi78ndprgw2jmfg8ng8h0nc8kyjn-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/plugins/ArchiSteamFarm.OfficialPlugins.SteamTokenDumper/
chmod: cannot access '/nix/store/54f3fi78ndprgw2jmfg8ng8h0nc8kyjn-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/ArchiSteamFarm.dll': No such file or directory

x86_64-darwin (sandbox = false)

✅ 1 package built:
  • archisteamfarm

aarch64-darwin (sandbox = false)

✅ 1 package built:
  • archisteamfarm

Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, diff looks good!

@gepbird gepbird self-requested a review February 2, 2026 01:26
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build fails on here but passes on master and I'm not sure about why: nothing uses pname, maybe some dotnet implementation depends on it?

nixpkgs ❯ nix-diff /nix/store/hqhswprraa0n5m6l9vjrwrw1q65f49y3-ArchiSteamFarm-6.3.1.6.drv /nix/store/4acgqg14qa4kyywxyq3w5dcxa180wmwz-archisteamfarm-6.3.1.6.drv
- /nix/store/hqhswprraa0n5m6l9vjrwrw1q65f49y3-ArchiSteamFarm-6.3.1.6.drv:{out}
+ /nix/store/4acgqg14qa4kyywxyq3w5dcxa180wmwz-archisteamfarm-6.3.1.6.drv:{out}
• The environments do not match:
    name=ArchiSteamFarm-6.3.1.6 -> archisteamfarm-6.3.1.6
    pname=ArchiSteamFarm -> archisteamfarm

Old log:

Publishing plugin ArchiSteamFarm.OfficialPlugins.SteamTokenDumper
  ArchiSteamFarm.OfficialPlugins.SteamTokenDumper -> /nix/store/v944dvbv4psmnx6pmshh6a9pnp6s1jg4-ArchiSteamFarm-6.3.1.6/lib/ArchiSteamFarm/plugins/ArchiSteamFarm.OfficialPlugins.SteamToken>
installed wrapper to /nix/store/v944dvbv4psmnx6pmshh6a9pnp6s1jg4-ArchiSteamFarm-6.3.1.6/bin/ArchiSteamFarm
Finished dotnetInstallHook
Running phase: dotnetFixupPhase
@nix { "action": "setPhase", "phase": "dotnetFixupPhase" }
Running phase: fixupPhase
@nix { "action": "setPhase", "phase": "fixupPhase" }
shrinking RPATHs of ELF executables and libraries in /nix/store/v944dvbv4psmnx6pmshh6a9pnp6s1jg4-ArchiSteamFarm-6.3.1.6
checking for references to /build/ in /nix/store/v944dvbv4psmnx6pmshh6a9pnp6s1jg4-ArchiSteamFarm-6.3.1.6...
patching script interpreter paths in /nix/store/v944dvbv4psmnx6pmshh6a9pnp6s1jg4-ArchiSteamFarm-6.3.1.6

New log:

Publishing plugin ArchiSteamFarm.OfficialPlugins.SteamTokenDumper
  ArchiSteamFarm.OfficialPlugins.SteamTokenDumper -> /nix/store/qf8g0bh02avzkg3srfc8b1y7jb7xwyp1-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/plugins/ArchiSteamFarm.OfficialPlugins.SteamToken>
chmod: cannot access '/nix/store/qf8g0bh02avzkg3srfc8b1y7jb7xwyp1-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/ArchiSteamFarm.dll': No such file or directory

(Sorry for the early approval, I saw you checked the built on x86_64-linux box, I only checked if it builds after the review.)

@gepbird gepbird self-requested a review February 2, 2026 01:37
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 2, 2026
@mdaniels5757
Copy link
Member

mdaniels5757 commented Feb 2, 2026

maybe some dotnet implementation depends on it

Looks like it.

# The path to publish the project to. When unset, the directory "$out/lib/$pname" is used.
installPath ? null,

@qweered qweered force-pushed the archisteamfarm-move-overrides branch from ae21920 to fbc9413 Compare February 2, 2026 10:42
@qweered qweered force-pushed the archisteamfarm-move-overrides branch from fbc9413 to ed1d17f Compare February 2, 2026 10:53
@qweered
Copy link
Contributor Author

qweered commented Feb 2, 2026

fixed build

@qweered
Copy link
Contributor Author

qweered commented Feb 2, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 485695
Commit: ed1d17fad14c7e2d87c8a7f7c485ef59f0d4c6ee (subsequent changes)
Merge: 1ef89bd653146039d763e82b2cce19cf92333e3b

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/21587268708


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • archisteamfarm

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • archisteamfarm

x86_64-darwin (sandbox = false)

✅ 1 package built:
  • archisteamfarm

aarch64-darwin (sandbox = false)

✅ 1 package built:
  • archisteamfarm

@MattSturgeon MattSturgeon added this pull request to the merge queue Feb 3, 2026
Merged via the queue into NixOS:master with commit ba122df Feb 3, 2026
28 of 32 checks passed
@SuperSandro2000 SuperSandro2000 added the backport release-25.11 Backport PR automatically label Feb 3, 2026
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 3, 2026

Successfully created backport PR for release-25.11:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Feb 3, 2026
@qweered qweered deleted the archisteamfarm-move-overrides branch February 19, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants