archisteamfarm: rename, move to by-name#485695
Conversation
|
gepbird
left a comment
There was a problem hiding this comment.
Thanks, diff looks good!
There was a problem hiding this comment.
The build fails on here but passes on master and I'm not sure about why: nothing uses pname, maybe some dotnet implementation depends on it?
nixpkgs ❯ nix-diff /nix/store/hqhswprraa0n5m6l9vjrwrw1q65f49y3-ArchiSteamFarm-6.3.1.6.drv /nix/store/4acgqg14qa4kyywxyq3w5dcxa180wmwz-archisteamfarm-6.3.1.6.drv
- /nix/store/hqhswprraa0n5m6l9vjrwrw1q65f49y3-ArchiSteamFarm-6.3.1.6.drv:{out}
+ /nix/store/4acgqg14qa4kyywxyq3w5dcxa180wmwz-archisteamfarm-6.3.1.6.drv:{out}
• The environments do not match:
name=ArchiSteamFarm-6.3.1.6 -> archisteamfarm-6.3.1.6
pname=ArchiSteamFarm -> archisteamfarmOld log:
Publishing plugin ArchiSteamFarm.OfficialPlugins.SteamTokenDumper
ArchiSteamFarm.OfficialPlugins.SteamTokenDumper -> /nix/store/v944dvbv4psmnx6pmshh6a9pnp6s1jg4-ArchiSteamFarm-6.3.1.6/lib/ArchiSteamFarm/plugins/ArchiSteamFarm.OfficialPlugins.SteamToken>
installed wrapper to /nix/store/v944dvbv4psmnx6pmshh6a9pnp6s1jg4-ArchiSteamFarm-6.3.1.6/bin/ArchiSteamFarm
Finished dotnetInstallHook
Running phase: dotnetFixupPhase
@nix { "action": "setPhase", "phase": "dotnetFixupPhase" }
Running phase: fixupPhase
@nix { "action": "setPhase", "phase": "fixupPhase" }
shrinking RPATHs of ELF executables and libraries in /nix/store/v944dvbv4psmnx6pmshh6a9pnp6s1jg4-ArchiSteamFarm-6.3.1.6
checking for references to /build/ in /nix/store/v944dvbv4psmnx6pmshh6a9pnp6s1jg4-ArchiSteamFarm-6.3.1.6...
patching script interpreter paths in /nix/store/v944dvbv4psmnx6pmshh6a9pnp6s1jg4-ArchiSteamFarm-6.3.1.6New log:
Publishing plugin ArchiSteamFarm.OfficialPlugins.SteamTokenDumper
ArchiSteamFarm.OfficialPlugins.SteamTokenDumper -> /nix/store/qf8g0bh02avzkg3srfc8b1y7jb7xwyp1-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/plugins/ArchiSteamFarm.OfficialPlugins.SteamToken>
chmod: cannot access '/nix/store/qf8g0bh02avzkg3srfc8b1y7jb7xwyp1-archisteamfarm-6.3.1.6/lib/ArchiSteamFarm/ArchiSteamFarm.dll': No such file or directory(Sorry for the early approval, I saw you checked the built on x86_64-linux box, I only checked if it builds after the review.)
Looks like it. nixpkgs/pkgs/build-support/dotnet/build-dotnet-module/default.nix Lines 35 to 36 in fda024d |
ae21920 to
fbc9413
Compare
fbc9413 to
ed1d17f
Compare
|
fixed build |
|
|
Successfully created backport PR for |
This is a step towards #454525, which will help enable checking for additional by-name directories (e.g. Python) in nixpkgs-vet.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.