Add the reject list for station t/q observations for GSI based soil DA#35
Merged
CoryMartin-NOAA merged 4 commits intoApr 21, 2025
Merged
Conversation
Contributor
Author
22 tasks
CoryMartin-NOAA
previously approved these changes
Apr 21, 2025
Contributor
|
Will merge once @ClaraDraper-NOAA confirms it is just this one station that we need to reject. I believe this is the case now that we are not using type 183. |
ClaraDraper-NOAA
suggested changes
Apr 21, 2025
Contributor
ClaraDraper-NOAA
left a comment
ClaraDraper-NOAA
left a comment
There was a problem hiding this comment.
Can we please change the file name to rejectlist_global.txt?
CoryMartin-NOAA
approved these changes
Apr 21, 2025
Contributor
Author
Made the change. Thanks. |
ClaraDraper-NOAA
approved these changes
Apr 21, 2025
Contributor
|
Thanks @jiaruidong2017 |
5 tasks
KateFriedman-NOAA
pushed a commit
to NOAA-EMC/global-workflow
that referenced
this pull request
Apr 30, 2025
…n GSI based soil DA (#3599) Add the setting to read and apply the reject list for removing the t/q observations from prepbufr file in GSA based soil DA. Refs NOAA-EMC/GSI-fix#35 Resolves #3546
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We propose to develop a reject list for the GSI base soil DA contributing to GFSv17 implementation. The proposed reject list will remove the t/q measurements from prepbufr file. This serves a place holder with more stations to be added in the future.