Skip to content

Improve messaging to display clear warning when missing snogrb file #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KateFriedman-NOAA merged 18 commits into from
Mar 14, 2025
Merged

Improve messaging to display clear warning when missing snogrb file #3317

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
28c5fb3
Improve messaging for snogrb setting
KateFriedman-NOAA Feb 11, 2025
dad2758
Add FATAL ERROR exit and update COM variables
KateFriedman-NOAA Feb 11, 2025
e6c5e05
Move new INFO message inside if-block
KateFriedman-NOAA Feb 11, 2025
5a55a10
Resolve shellcheck warnings
KateFriedman-NOAA Feb 11, 2025
500aeca
Update new snow file messaging to clarify cycle
KateFriedman-NOAA Feb 11, 2025
742e376
Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373
KateFriedman-NOAA Feb 14, 2025
134ba21
Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373
KateFriedman-NOAA Feb 19, 2025
80ab616
Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373
KateFriedman-NOAA Feb 20, 2025
bfd9ff4
Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373
KateFriedman-NOAA Feb 24, 2025
d3c197f
Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373
KateFriedman-NOAA Feb 25, 2025
caf08c1
Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373
KateFriedman-NOAA Feb 25, 2025
136f338
Remove reference to getges
KateFriedman-NOAA Mar 10, 2025
cd86c5f
Remove getges and replace snoprv with FNSNOG
KateFriedman-NOAA Mar 10, 2025
6de1f91
Merge remote-tracking branch 'origin/develop' into feature/bugzilla_1373
KateFriedman-NOAA Mar 10, 2025
135930b
Change FATAL to WARNING
KateFriedman-NOAA Mar 12, 2025
1a3a727
Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373
KateFriedman-NOAA Mar 12, 2025
2cd7d9f
Merge branch 'NOAA-EMC:develop' into feature/bugzilla_1373
KateFriedman-NOAA Mar 13, 2025
c2d77ea
Merge branch 'develop' into feature/bugzilla_1373
KateFriedman-NOAA Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions jobs/JGDAS_ENKF_SFC
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,13 @@ export APREFIX_ENS="${RUN}.t${cyc}z."
export GPREFIX="${GDUMP}.t${gcyc}z."
export GPREFIX_ENS="${GDUMP_ENS}.t${gcyc}z."

RUN=${RUN/enkf} YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COM_OBS \
COM_ATMOS_ANALYSIS_DET:COM_ATMOS_ANALYSIS_TMPL
RUN=${RUN/enkf} YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \
COMIN_OBS:COM_OBS_TMPL \
COMIN_ATMOS_ANALYSIS_DET:COM_ATMOS_ANALYSIS_TMPL

RUN=${GDUMP} YMD=${gPDY} HH=${gcyc} declare_from_tmpl -rx \
COM_OBS_PREV:COM_OBS_TMPL \
COM_ATMOS_ANALYSIS_DET_PREV:COM_ATMOS_ANALYSIS_TMPL
COMIN_OBS_PREV:COM_OBS_TMPL \
COMIN_ATMOS_ANALYSIS_DET_PREV:COM_ATMOS_ANALYSIS_TMPL

###############################################################
# Run relevant script
Expand Down
52 changes: 33 additions & 19 deletions scripts/exgdas_enkf_sfc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,18 +78,32 @@ bPDY=${BDATE:0:8}
bcyc=${BDATE:8:2}

# Get dimension information based on CASE
res=${CASE:2:}
res=${CASE:1}
JCAP_CASE=$((res*2-2))
LATB_CASE=$((res*2))
LONB_CASE=$((res*4))

# Global cycle requires these files
export FNTSFA=${FNTSFA:-' '}
export FNACNA=${FNACNA:-${COM_OBS}/${OPREFIX}seaice.5min.blend.grb}
export FNSNOA=${FNSNOA:-${COM_OBS}/${OPREFIX}snogrb_t${JCAP_CASE}.${LONB_CASE}.${LATB_CASE}}
[[ ! -f $FNSNOA ]] && export FNSNOA="${COM_OBS}/${OPREFIX}snogrb_t1534.3072.1536"
FNSNOG=${FNSNOG:-${COM_OBS_PREV}/${GPREFIX}snogrb_t${JCAP_CASE}.${LONB_CASE}.${LATB_CASE}}
[[ ! -f $FNSNOG ]] && FNSNOG="${COM_OBS_PREV}/${GPREFIX}snogrb_t1534.3072.1536"
export FNACNA=${FNACNA:-${COMIN_OBS}/${OPREFIX}seaice.5min.blend.grb}
export FNSNOA=${FNSNOA:-${COMIN_OBS}/${OPREFIX}snogrb_t${JCAP_CASE}.${LONB_CASE}.${LATB_CASE}}
# Check if resolution specific FNSNOA exists, if not use t1534 version
[[ ! -f ${FNSNOA} ]] && export FNSNOA="${COMIN_OBS}/${OPREFIX}snogrb_t1534.3072.1536"
if [[ ! -f ${FNSNOA} ]]; then
echo "FATAL ERROR: Current cycle snow file ${FNSNOA} is missing. Exiting."
exit 1
Comment thread
KateFriedman-NOAA marked this conversation as resolved.
Outdated
else
echo "INFO: Current cycle snow file is ${FNSNOA}"
fi
export FNSNOG=${FNSNOG:-${COMIN_OBS_PREV}/${GPREFIX}snogrb_t${JCAP_CASE}.${LONB_CASE}.${LATB_CASE}}
# Check if resolution specific FNSNOG exists, if not use t1534 version
[[ ! -f ${FNSNOG} ]] && export FNSNOG="${COMIN_OBS_PREV}/${GPREFIX}snogrb_t1534.3072.1536"
if [[ ! -f ${FNSNOG} ]]; then
echo "FATAL ERROR: Previous cycle snow file ${FNSNOG} is missing. Exiting."
Comment thread
KateFriedman-NOAA marked this conversation as resolved.
Outdated
exit 1
else
echo "INFO: Previous cycle snow file is ${FNSNOG}"
fi

# Set CYCLVARS by checking grib date of current snogrb vs that of prev cycle
if [ ${RUN_GETGES:-"NO"} = "YES" ]; then
Expand All @@ -110,7 +124,7 @@ else
fi

if [ $DONST = "YES" ]; then
export NST_FILE=${NST_FILE:-${COM_ATMOS_ANALYSIS_DET}/${APREFIX}dtfanl.nc}
export NST_FILE=${NST_FILE:-${COMIN_ATMOS_ANALYSIS_DET}/${APREFIX}dtfanl.nc}
else
export NST_FILE="NULL"
fi
Expand Down Expand Up @@ -138,13 +152,13 @@ if [ $DOIAU = "YES" ]; then
memchar="mem$cmem"

MEMDIR=${memchar} YMD=${PDY} HH=${cyc} declare_from_tmpl \
COM_ATMOS_RESTART_MEM:COM_ATMOS_RESTART_TMPL
COMOUT_ATMOS_RESTART_MEM:COM_ATMOS_RESTART_TMPL

MEMDIR=${gmemchar} RUN=${GDUMP_ENS} YMD=${gPDY} HH=${gcyc} declare_from_tmpl \
COMIN_ATMOS_RESTART_MEM_PREV:COM_ATMOS_RESTART_TMPL

MEMDIR=${memchar} YMD=${PDY} HH=${cyc} declare_from_tmpl \
COM_ATMOS_ANALYSIS_MEM:COM_ATMOS_ANALYSIS_TMPL
COMIN_ATMOS_ANALYSIS_MEM:COM_ATMOS_ANALYSIS_TMPL

MEMDIR=${memchar} YMD=${PDY} HH=${cyc} declare_from_tmpl \
COMIN_SNOW_ANALYSIS_MEM:COM_SNOW_ANALYSIS_TMPL
Expand All @@ -156,7 +170,7 @@ if [ $DOIAU = "YES" ]; then
sfcdata_dir="${COMIN_ATMOS_RESTART_MEM_PREV}"
fi

[[ ${TILE_NUM} -eq 1 ]] && mkdir -p "${COM_ATMOS_RESTART_MEM}"
[[ ${TILE_NUM} -eq 1 ]] && mkdir -p "${COMOUT_ATMOS_RESTART_MEM}"
${NCP} "${sfcdata_dir}/${bPDY}.${bcyc}0000.sfc_data.tile${n}.nc" \
"${DATA}/fnbgsi.${cmem}"
${NCP} "${DATA}/fnbgsi.${cmem}" "${DATA}/fnbgso.${cmem}"
Expand All @@ -165,7 +179,7 @@ if [ $DOIAU = "YES" ]; then

if [[ ${GSI_SOILANAL} = "YES" ]]; then
FHR=6
${NCP} "${COM_ATMOS_ANALYSIS_MEM}/${APREFIX_ENS}sfci00${FHR}.nc" \
${NCP} "${COMIN_ATMOS_ANALYSIS_MEM}/${APREFIX_ENS}sfci00${FHR}.nc" \
"${DATA}/lnd_incr.${cmem}"
fi
done # ensembles
Expand All @@ -184,18 +198,18 @@ if [ $DOIAU = "YES" ]; then
memchar="mem$cmem"

MEMDIR=${memchar} YMD=${PDY} HH=${cyc} declare_from_tmpl \
COM_ATMOS_RESTART_MEM:COM_ATMOS_RESTART_TMPL
COMOUT_ATMOS_RESTART_MEM:COM_ATMOS_RESTART_TMPL

MEMDIR=${memchar} YMD=${PDY} HH=${cyc} declare_from_tmpl \
COM_ATMOS_ANALYSIS_MEM:COM_ATMOS_ANALYSIS_TMPL
COMIN_ATMOS_ANALYSIS_MEM:COM_ATMOS_ANALYSIS_TMPL

[[ ${TILE_NUM} -eq 1 ]] && mkdir -p "${COM_ATMOS_RESTART_MEM}"
cpfs "${DATA}/fnbgso.${cmem}" "${COM_ATMOS_RESTART_MEM}/${bPDY}.${bcyc}0000.sfcanl_data.tile${n}.nc"
[[ ${TILE_NUM} -eq 1 ]] && mkdir -p "${COMOUT_ATMOS_RESTART_MEM}"
cpfs "${DATA}/fnbgso.${cmem}" "${COMOUT_ATMOS_RESTART_MEM}/${bPDY}.${bcyc}0000.sfcanl_data.tile${n}.nc"


if [[ ${GSI_SOILANAL} = "YES" ]]; then
FHR=6
${NCP} "${COM_ATMOS_ANALYSIS_MEM}/${APREFIX_ENS}sfci00${FHR}.nc" \
${NCP} "${COMIN_ATMOS_ANALYSIS_MEM}/${APREFIX_ENS}sfci00${FHR}.nc" \
"${DATA}/lnd_incr.${cmem}"
fi
done # ensembles
Expand Down Expand Up @@ -254,11 +268,11 @@ if [ $DOSFCANL_ENKF = "YES" ]; then
memchar="mem${cmem}"

MEMDIR=${memchar} YMD=${PDY} HH=${cyc} declare_from_tmpl \
COM_ATMOS_RESTART_MEM:COM_ATMOS_RESTART_TMPL
COMOUT_ATMOS_RESTART_MEM:COM_ATMOS_RESTART_TMPL

[[ ! -d "${COM_ATMOS_RESTART_MEM}" ]] && mkdir -p "${COM_ATMOS_RESTART_MEM}"
[[ ! -d "${COMOUT_ATMOS_RESTART_MEM}" ]] && mkdir -p "${COMOUT_ATMOS_RESTART_MEM}"

cpfs "${DATA}/fnbgso.${cmem}" "${COM_ATMOS_RESTART_MEM}/${PDY}.${cyc}0000.sfcanl_data.tile${n}.nc"
cpfs "${DATA}/fnbgso.${cmem}" "${COMOUT_ATMOS_RESTART_MEM}/${PDY}.${cyc}0000.sfcanl_data.tile${n}.nc"

done

Expand Down
18 changes: 16 additions & 2 deletions scripts/exglobal_atmos_sfcanl.sh
View file
Open in desktop
Comment thread
KateFriedman-NOAA marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,23 @@ LONB_CASE=$((res*4))
export FNTSFA=${FNTSFA:-${COMIN_OBS}/${OPREFIX}rtgssthr.grb}
export FNACNA=${FNACNA:-${COMIN_OBS}/${OPREFIX}seaice.5min.blend.grb}
export FNSNOA=${FNSNOA:-${COMIN_OBS}/${OPREFIX}snogrb_t${JCAP_CASE}.${LONB_CASE}.${LATB_CASE}}
# Check if resolution specific FNSNOA exists, if not use t1534 version
[[ ! -f ${FNSNOA} ]] && export FNSNOA="${COMIN_OBS}/${OPREFIX}snogrb_t1534.3072.1536"
FNSNOG=${FNSNOG:-${COMIN_OBS_PREV}/${GPREFIX}snogrb_t${JCAP_CASE}.${LONB_CASE}.${LATB_CASE}}
[[ ! -f ${FNSNOG} ]] && FNSNOG="${COMIN_OBS_PREV}/${GPREFIX}snogrb_t1534.3072.1536"
if [[ ! -f ${FNSNOA} ]]; then
echo "FATAL ERROR: Current cycle snow file ${FNSNOA} is missing. Exiting."
exit 1
else
echo "INFO: Current cycle snow file is ${FNSNOA}"
fi
Comment thread
KateFriedman-NOAA marked this conversation as resolved.
export FNSNOG=${FNSNOG:-${COMIN_OBS_PREV}/${GPREFIX}snogrb_t${JCAP_CASE}.${LONB_CASE}.${LATB_CASE}}
# Check if resolution specific FNSNOG exists, if not use t1534 version
[[ ! -f ${FNSNOG} ]] && export FNSNOG="${COMIN_OBS_PREV}/${GPREFIX}snogrb_t1534.3072.1536"
if [[ ! -f ${FNSNOG} ]]; then
echo "FATAL ERROR: Previous cycle snow file ${FNSNOG} is missing. Exiting."
exit 1
else
echo "INFO: Previous cycle snow file is ${FNSNOG}"
fi

# Set CYCLVARS by checking grib date of current snogrb vs that of prev cycle
if [[ ${RUN_GETGES} = "YES" ]]; then
Expand Down