Sync develop -> dev/ufs-weather-model by JessicaMeixner-NOAA · Pull Request #1480 · NOAA-EMC/WW3

JessicaMeixner-NOAA · 2025-07-31T14:57:11Z

Pull Request Summary

Sync develop -> dev/ufs-weather-model

Description

Routine sync of develop to dev/ufs-weather-model.

No answer changes. Updates include:
-- Compiler warning fix Close #1455
-- Compiler warning fix Close #1431
-- Includes removal of all GOTOs
-- Updates standalone regression tests to spack-stack 1.9.2 and for Ursa

Issue(s) addressed

ufs-community/ufs-weather-model#2832

Commit Message

Sync develop as of 7-30-2025 to dev/ufs-weather-model

Check list

Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
Checked the checklist for a developer submitting to develop.
If a version number update is required, checked the updating version number checklist.
If a new feature was added, a regression test for testing the new feature is added.

Testing

How were these changes tested? a set of matrix was run to ensure completion, Then test ufs-weather-model rt tests were run. New input was needed, but then no answer changes.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) yes
Have the matrix regression tests been run (if yes, please note HPC and compiler)? intel ursa
Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

…bose=2 output (NOAA-EMC#1392) * Add a new Angular Distance distance calculation (in degrees) routine in w3servmd and use this method in ww3_bounc to more robustly calculate spherical distances between geographic locations. This commit also adds VERBOSE=2 diagnostic output. VERBOSE=2 was previously unused. * Corrected variable description --------- Co-authored-by: Ty Hesser <thesser1@gmail.com>

…1294) * This PR adds a write statement in ww3_grid.out and therefore will result in changes in all ww3_grid.out files in regtests. *add IC4_NUMERICS namelist to w3gdatmd.F90 * add IC4_NUMERICS namelist to w3gridmd.F90 * make ICNUMERICS namelist setting (to be put under MISC namelist) - Ic numerics fix should be applicable to ALL IC settings. * IC_NUMERICS Fix for All sea ice source terms * remove lines that modify timestep in sea ice * remove pointer on line 704 w3gdatmd.F90

--------- Co-authored-by: Matthew Masarik <Matthew.Masarik@noaa.gov>

Addition of regtest that turns on the IC_NUMERICS in IC4_M10 test case

…BJ (NOAA-EMC#1427) in w3sdb1md to resolve type conversion warnings for GNU 13.3. Remove unused variables local to subroutine w3sdb1 Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>

…NOAA-EMC#1430) * fix hang in wave model initialization * remove tabs

…la (NOAA-EMC#1435)

Avoided 'DSO missing from command line' error during the linking step through changing the order of compilation flags

…ut field (NOAA-EMC#1438)

) Co-authored-by: Saeideh.Banihashemi <saeideh.banihashemi@noaa.gov>

…MC#1472)

…ited JONSWAP(NOAA-EMC#1451) initialization manually in ww3_strt.inp

…G builds Co-authored-by: Brian Curtis <Brian.Curtis@noaa.gov>

Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com>

mingchen-NOAA · 2025-08-01T15:17:38Z

A WW3 standalone regression tests were conducted. No error was observed.

mingchen-NOAA · 2025-08-04T13:53:16Z

New baseline was created and used for matrix comparison. No unexpected difference was observed.

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UNO_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

mingchen-NOAA · 2025-08-04T13:54:07Z

Will merge after passing the ufs_wm regression tests.

…2ufs_20250730

jkbk2004 · 2025-08-19T12:48:58Z

All tests are done ok at ufs-community/ufs-weather-model#2852. @mingchen-NOAA can you merge this pr?

mingchen-NOAA · 2025-08-19T13:09:16Z

@jkbk2004 PR merged. Thank you!

dahonegger and others added 21 commits March 25, 2025 10:18

update scrip_remap_conservative to use MPI (NOAA-EMC#1268)

0a9e10f

--------- Co-authored-by: Matthew Masarik <Matthew.Masarik@noaa.gov>

Bug fix for NOAA-EMC#1412 for IC_NUMERICS (NOAA-EMC#1413)

d6c52ea

Addition of regtest that turns on the IC_NUMERICS in IC4_M10 test case

Define ETOT and FMEAN2 in double precision and use single precision C…

3e94f85

…BJ (NOAA-EMC#1427) in w3sdb1md to resolve type conversion warnings for GNU 13.3. Remove unused variables local to subroutine w3sdb1 Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>

develop: Fix hang bug by updating MPI bcast to be from 0 not IAPROC-1 (…

93ee103

…NOAA-EMC#1430) * fix hang in wave model initialization * remove tabs

correct bottom friction computation in BT4 based on CREST model formu…

5e7a41a

…la (NOAA-EMC#1435)

MPI flags always added when OASIS is compiled (NOAA-EMC#1437)

351119b

correction of lambda computation (NOAA-EMC#1439)

f27fe03

Changed order of statements in CMakeLists.txt (NOAA-EMC#1440)

0a0fccb

Avoided 'DSO missing from command line' error during the linking step through changing the order of compilation flags

correct field exchange for air density if provided as homogeneous inp…

e88ae71

…ut field (NOAA-EMC#1438)

New regtest matrix for the Met Office EX supercomputer (NOAA-EMC#1448)

6547023

Upgrade WW3 to Spack‑Stack 1.9.2 and add support for Ursa (NOAA-EMC#1462

1cca7c5

) Co-authored-by: Saeideh.Banihashemi <saeideh.banihashemi@noaa.gov>

Removal of labelled statements (NOAA-EMC#1457)

d6160ab

Fix uninitialized TRHO in W3IORS for consistent restart files (NOAA-E…

e7bacf5

…MC#1472)

Updates for SCOTCH 7.0.7

760af3b

adding the possibility to set the fetch that is used by the fetch-lim…

8c19f2e

…ited JONSWAP(NOAA-EMC#1451) initialization manually in ww3_strt.inp

Add -check all -check noarg_temp_created -ftrapuv flags to intel DEBU…

1d58d7c

…G builds Co-authored-by: Brian Curtis <Brian.Curtis@noaa.gov>

Fix 3/2 integer division in W3FLD1

aa7c2d7

Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com>

Merge remote-tracking branch 'origin/develop' into syncdev2ufs_20250730

61835c6

updates after merge

5a3eb1e

This was referenced Jul 31, 2025

Sync WW3 develop -> dev/ufs-weather-model ufs-community/ufs-weather-model#2841

Closed

Add -check all and -ftrapuv to all Intel DEBUG builds ufs-community/ufs-weather-model#2789

Merged

Fix uninitialized FLOGRR for consistent restart files (NOAA-EMC#1478)

c5780b8

mingchen-NOAA self-requested a review August 1, 2025 13:44

mingchen-NOAA approved these changes Aug 4, 2025

View reviewed changes

Merge branch 'NOAA-EMC:develop' into syncdev2ufs_20250730

ec083f1

Merge remote-tracking branch 'EMC/dev/ufs-weather-model' into syncdev…

dc3ad4a

…2ufs_20250730

NickSzapiro-NOAA mentioned this pull request Aug 15, 2025

Update CICE through 2025-07 and switch to ice history variables with expected ranges. Sync of WW3 develop to dev/ufs-weather-model ufs-community/ufs-weather-model#2852

Merged

14 tasks

mingchen-NOAA merged commit 1011de8 into NOAA-EMC:dev/ufs-weather-model Aug 19, 2025
3 of 6 checks passed

This was referenced Aug 21, 2025

Bring in nco DEBUG flag changes for ops #1455

Closed

Fix 3/2 integer division in W3FLD1 #1431

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync develop -> dev/ufs-weather-model #1480

Sync develop -> dev/ufs-weather-model #1480
mingchen-NOAA merged 24 commits into
NOAA-EMC:dev/ufs-weather-modelfrom
JessicaMeixner-NOAA:syncdev2ufs_20250730

JessicaMeixner-NOAA commented Jul 31, 2025

Uh oh!

mingchen-NOAA commented Aug 1, 2025

Uh oh!

mingchen-NOAA commented Aug 4, 2025

Uh oh!

mingchen-NOAA commented Aug 4, 2025

Uh oh!

jkbk2004 commented Aug 19, 2025

Uh oh!

Uh oh!

mingchen-NOAA commented Aug 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

JessicaMeixner-NOAA commented Jul 31, 2025

Pull Request Summary

Description

Issue(s) addressed

Commit Message

Check list

Testing

Uh oh!

mingchen-NOAA commented Aug 1, 2025

Uh oh!

mingchen-NOAA commented Aug 4, 2025

Uh oh!

mingchen-NOAA commented Aug 4, 2025

Uh oh!

jkbk2004 commented Aug 19, 2025

Uh oh!

Uh oh!

mingchen-NOAA commented Aug 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants