develop: fix type conversions found w/ GNU+debug on Hera

[JessicaMeixner-NOAA]

Pull Request Summary

fix type conversions found w/ GNU+debug on Hera in the develop branch.

Description

The code changes were authored by @DeniseWorthen and full description can be found on the PR to the dev/ufs-weather-model branch: #1408 This PR just brings those change to the develop branch.

Issue(s) addressed

This PR is just merging an update that originally was pointing to dev/ufs-weather-model to the develop branch.

Commit Message

Define ETOT and FMEAN2 in double precision and use single precision CBJ in w3sdb1md to resolve type conversion warnings for GNU 13.3. Remove unused variables local to subroutine w3sdb1

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested? matrix
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) no
• Have the matrix regression tests been run (if yes, please note HPC and compiler)? hera intel
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  none
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (6 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (13 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (17 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

[sbanihash]

I have reviewed this PR and approve the changes. Regression tests have been done and the matrix files are attached.

matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt

[sbanihash]

I approve this PR to be merged.