correct field exchange for air density#1438
Merged
Merged
Conversation
Collaborator
JessicaMeixner-NOAA
left a comment
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
Should ww3_tp2.15/info also be updated?
| @@ -0,0 +1,117 @@ | |||
| function extract_AA_STE | |||
Collaborator
There was a problem hiding this comment.
Was this supposed to be added?
Collaborator
Author
|
I've updated the info and removed the unused matlab code |
JessicaMeixner-NOAA
requested changes
May 22, 2025
Collaborator
JessicaMeixner-NOAA
left a comment
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
Having some issues running the new tests with inp input.
| F F Currents | ||
| T F Winds | ||
| F F Ice concentrations | ||
| T H Atmospheric momentum |
Collaborator
There was a problem hiding this comment.
@mickaelaccensi - The ww3_tp2.15 tests are failing for me. Should these H's be Ts? Also you have a blank space below.
I'm assuming you ran this test with nml and not the inp? We are stilll running the inp and got some errors.
Collaborator
Author
There was a problem hiding this comment.
I've corrected the inp file. Now the test pass with inp. sorry for that
Collaborator
There was a problem hiding this comment.
Thanks for the updates!
Collaborator
There was a problem hiding this comment.
Regression tests
**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2 (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (16 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (18 files differ)
mww3_test_03/./work_PR1_MPI_d2 (12 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (18 files differ)
mww3_test_03/./work_PR1_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e (1 files differ)
mww3_test_09/./work_MPI_ASCII (0 files differ)
ww3_ta1/./work_UPD3_U_cap (2 files differ)
ww3_ta1/./work_UPD0F_O (2 files differ)
ww3_ta1/./work_UPD2_O (2 files differ)
ww3_ta1/./work_UPD3_U (2 files differ)
ww3_ta1/./work_UPD5_U_cap (2 files differ)
ww3_ta1/./work_UPD3_O (2 files differ)
ww3_ta1/./work_UPD6_O (2 files differ)
ww3_ta1/./work_UPD6_U_cap (2 files differ)
ww3_ta1/./work_UPD5_U (2 files differ)
ww3_ta1/./work_UPD6_U (2 files differ)
ww3_ta1/./work_UPD5_O (2 files differ)
ww3_ta1/./work_UPD2_U (2 files differ)
ww3_ta1/./work_UPD2_U_cap (2 files differ)
ww3_ta1/./work_UPD0F_U (2 files differ)
ww3_tp2.10/./work_MPI_OMPH (7 files differ)
ww3_tp2.16/./work_MPI_OMPH (4 files differ)
ww3_tp2.6/./work_ST4_ASCII (0 files differ)
ww3_ts1/./work_ST4_T700 (5 files differ)
ww3_ts1/./work_ST4_WRT (2 files differ)
ww3_ts1/./work_T707GQM (4 files differ)
ww3_ts1/./work_ST4 (2 files differ)
ww3_ts1/./work_ST4_T500 (2 files differ)
ww3_ts1/./work_T713GQM (4 files differ)
ww3_ts1/./work_Romero (4 files differ)
ww3_ts1/./work_ST4_TSA (2 files differ)
ww3_ts1/./work_ST4_CAP (2 files differ)
ww3_ts1/./work_T702 (4 files differ)
ww3_ts1/./work_T701 (4 files differ)
ww3_ts1/./work_ST4_GMD (2 files differ)
ww3_ufs1.3/./work_a (3 files differ)
mingchen-NOAA
approved these changes
May 29, 2025
Collaborator
mingchen-NOAA
left a comment
mingchen-NOAA
left a comment
There was a problem hiding this comment.
Regression tests were as expected:
********************* non-identical cases ****************************
mww3_test_03/./work_PR2_UQ_MPI_d2 (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (15 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (9 files differ)
mww3_test_03/./work_PR1_MPI_d2 (10 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c (1 files differ)
mww3_test_03/./work_PR1_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c (1 files differ)
mww3_test_09/./work_MPI_ASCII (0 files differ)
ww3_tp2.10/./work_MPI_OMPH (7 files differ)
ww3_tp2.16/./work_MPI_OMPH (4 files differ)
ww3_tp2.6/./work_ST4_ASCII (0 files differ)
ww3_ufs1.3/./work_a (3 files differ)
JessicaMeixner-NOAA
approved these changes
May 29, 2025
Collaborator
JessicaMeixner-NOAA
left a comment
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
Thanks for the updates @mickaelaccensi!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
correct field exchange for air density if provided as homogeneous input field
Description
add a test in w3fldh function to exchange scalar field with time interpolation
Issue(s) addressed
Commit Message
correct field exchange for air density if provided as homogeneous input field
Check list
Testing
matrixCompSummary.txt
matrixCompFull.txt