Skip to content

Upgrade WW3 to Spack-Stack 1.9.2#1462

Merged
JessicaMeixner-NOAA merged 3 commits into
NOAA-EMC:developfrom
mingchen-NOAA:ww3/ss192_upgrade
Jul 21, 2025
Merged

Upgrade WW3 to Spack-Stack 1.9.2#1462
JessicaMeixner-NOAA merged 3 commits into
NOAA-EMC:developfrom
mingchen-NOAA:ww3/ss192_upgrade

Conversation

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

@mingchen-NOAA mingchen-NOAA commented Jul 15, 2025 •
edited
Loading

Pull Request Summary

Upgrade WW3 to Spack‑Stack 1.9.2 on Hera, Orion, Hercules, and add support for Ursa.

Description

This PR upgrades WW3 to use Spack‑Stack 1.9.2 on Hera, Orion, and Hercules, and introduces support for the Ursa machine. The regtests/bin/matrix_cmake_ncep script has been updated with the latest module paths, library directories, and versions. In addition, a new configuration for the Ursa machine has been added.

The regression tests were performed on all machines for both Intel and GNU compiler. Results are:

  • Hera-Intel: no error, no unexpected differences
  • Hera-GNU: out-of-memory error
  • Orion-Intel: no error, no unexpected differences
  • Hercules-Intel: no error, no unexpected differences
  • Hercules-GNU: no error, unexpected differences found
  • Ursa-Intel: no error, unexpected differences found
  • Ursa-GNU: no error, unexpected differences found

Issue(s) addressed

Addresses: #1458 and #1459

Commit Message

Upgrade WW3 to Spack‑Stack 1.9.2 and add support for Ursa

Check list

Testing

  • How were these changes tested? matrix
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) New baseline created and compared
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    • Hera with Intel compiler
    • Hercules with Intel compiler
    • Hercules with GNU compiler
    • Orion with Intel compiler
    • Ursa with Intel compiler
    • Ursa with GNU compiler
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

New baseline was created and matrix comparison was performed

Hera-Intel: no unexpected difference:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

matrixCompFull.txt
matrixDiff.txt
matrixCompSummary.txt

Hercules-Intel: no unexpected difference:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (17 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

Orion-Intel: no unexpected difference:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_d                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (13 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

Hercules-GNU: unexpected differences were found for ww3_tp2.1, ww3_tp2.10, ww3_tp2.16, ww3_tp2.17. Surprisingly, no differences in cases ww3_tic1.4, ww3_tp2.21 and ww3_tp2.7

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (14 files differ)
mww3_test_05/./work_ST3_PR3_UQ_MPI                     (0 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.1/./work_PR2_UQ                     (1 files differ)
ww3_tp2.1/./work_PR2_UQ_MPI                     (1 files differ)
ww3_tp2.1/./work_PR3_UNO_MPI                     (1 files differ)
ww3_tp2.1/./work_PR3_UQ                     (1 files differ)
ww3_tp2.1/./work_PR3_UQ_MPI                     (1 files differ)
ww3_tp2.1/./work_PR2_UNO_MPI                     (1 files differ)
ww3_tp2.1/./work_PR1                     (1 files differ)
ww3_tp2.1/./work_PR2_UNO                     (1 files differ)
ww3_tp2.1/./work_PR1_MPI                     (1 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.17/./work_ma1                     (3 files differ)
ww3_tp2.17/./work_ma                     (3 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.1/./work_c_nth                     (9 files differ)
ww3_ufs1.1/./work_unstr_b                     (1 files differ)
ww3_ufs1.3/./work_a                     (28 files differ)

matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt

Ursa-Intel:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UNO_MPI_d_c                     (6 files differ)
mww3_test_03/./work_PR1_MPI_b                     (4 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR1_MPI_d                     (6 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (2 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d                     (6 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (22 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d                     (6 files differ)
mww3_test_03/./work_PR3_UNO_MPI_a_c                     (3 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_a                     (3 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (2 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (21 files differ)
mww3_test_03/./work_PR2_UNO_MPI_a                     (3 files differ)
mww3_test_03/./work_PR2_UNO_MPI_b                     (4 files differ)
mww3_test_03/./work_PR3_UQ_MPI_a                     (3 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (19 files differ)
mww3_test_03/./work_PR3_UQ_MPI_b_c                     (4 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d_c                     (6 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (22 files differ)
mww3_test_03/./work_PR3_UQ_MPI_a_c                     (3 files differ)
mww3_test_03/./work_PR3_UNO_MPI_b_c                     (4 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (2 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (22 files differ)
mww3_test_03/./work_PR1_MPI_a                     (3 files differ)
mww3_test_03/./work_PR1_MPI_e                     (2 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d                     (6 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (21 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (2 files differ)
mww3_test_03/./work_PR3_UQ_MPI_b                     (4 files differ)
mww3_test_03/./work_PR2_UQ_MPI_a                     (3 files differ)
mww3_test_03/./work_PR1_MPI_e                     (2 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d                     (6 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (21 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (2 files differ)
mww3_test_03/./work_PR3_UQ_MPI_b                     (4 files differ)
mww3_test_03/./work_PR2_UQ_MPI_a                     (3 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d                     (6 files differ)
mww3_test_04/./work_PR3_UNO_MPI_d_c                     (3 files differ)
mww3_test_04/./work_PR1_MPI_d                     (3 files differ)
mww3_test_04/./work_PR2_UNO_MPI_d                     (3 files differ)
mww3_test_04/./work_PR3_UNO_MPI_d                     (3 files differ)
mww3_test_04/./work_PR3_UQ_MPI_d_c                     (3 files differ)
mww3_test_04/./work_PR3_UQ_MPI_d                     (3 files differ)
mww3_test_04/./work_PR2_UQ_MPI_d                     (3 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.1/./work_c_npl                     (9 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

Ursa-GNU:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UNO_MPI_d2                     (6 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (9 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (12 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (13 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.1/./work_c_nth                     (9 files differ)
ww3_ufs1.3/./work_a                     (27 files differ)

@mingchen-NOAA mingchen-NOAA marked this pull request as ready for review July 16, 2025 00:39
@JessicaMeixner-NOAA JessicaMeixner-NOAA self-requested a review July 16, 2025 12:30
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request Jul 16, 2025
Merged
2 tasks
@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

JessicaMeixner-NOAA commented Jul 21, 2025

@mingchen-NOAA Please create issues for unexpected differences for each platform that it's relevant and the hera-gnu issues.

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator Author

mingchen-NOAA commented Jul 21, 2025

I will do. Thanks

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

JessicaMeixner-NOAA commented Jul 21, 2025

Confirming got the same/similiar as @mingchen-NOAA and @sbanihash

hera intel:
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

Hera Gnu: Has issues

Hercules- Intel:
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

I did get 1 file diff in ww3_tp2.14/./work_OASACM -- was a text file, it's not concerning but noting.

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (15 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.14/./work_OASACM                     (1 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

Hercules - Gnu:
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

Smaller set of diffs:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (13 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.1/./work_d                     (8 files differ)
ww3_ufs1.3/./work_a                     (28 files differ)

Orion-intel:
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

Ursa - Intel:

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

Ursa Gnu:
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

JessicaMeixner-NOAA commented Jul 21, 2025

This PR can be merged after issues have been made for the various things that need to be tracked.

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

JessicaMeixner-NOAA commented Jul 21, 2025

Issues are documented here:
hera gnu error (#1466)
hercules gnu unexpected differences (#1467)
Ursa Inter unexpected differences (#1468)

JessicaMeixner-NOAA
JessicaMeixner-NOAA approved these changes Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to latest spack-stack for NCEP tests.

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 1cca7c5 into NOAA-EMC:develop Jul 21, 2025
3 of 6 checks passed
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request Jul 22, 2025
Open
@mingchen-NOAA mingchen-NOAA deleted the ww3/ss192_upgrade branch January 13, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mingchen-NOAA @JessicaMeixner-NOAA @sbanihash