Skip to content

Bring in nco DEBUG flag changes for ops#1455

Closed
BrianCurtis-NOAA wants to merge 4 commits into
NOAA-EMC:dev/ufs-weather-modelfrom
BrianCurtis-NOAA:nco_debug_changes
Closed

Bring in nco DEBUG flag changes for ops#1455
BrianCurtis-NOAA wants to merge 4 commits into
NOAA-EMC:dev/ufs-weather-modelfrom
BrianCurtis-NOAA:nco_debug_changes

Conversation

@BrianCurtis-NOAA
Copy link
Copy Markdown
Contributor

Pull Request Summary

Bring in nco DEBUG flag changes for ops

Description

NCO pushes for the two flags -check all -ftrapuv to be in as many components that go into operations as possible. We've added -check noarg_temp_created as it makes the logs much smaller.

Issue(s) addressed

Commit Message

  • Add -check all -check noarg_temp_created -ftrapuv flags to intel DEBUG builds

Check list

Testing

  • How were these changes tested? UFSWM through building all compiles in their rt.conf
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.) No changes anticipated.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates @BrianCurtis-NOAA

@BrianCurtis-NOAA BrianCurtis-NOAA marked this pull request as draft June 26, 2025 18:38
@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA - Is there a reason this PR is a draft still? Are we unsure of the requirements or something else?

@BrianCurtis-NOAA
Copy link
Copy Markdown
Contributor Author

While testing there were baselines changes and I put it on the back burner trying to get some other higher priority things done. I hope to get back to this soon.

@BrianCurtis-NOAA
Copy link
Copy Markdown
Contributor Author

And to clarify, i hadn't identified where it was coming from. Probably unrelated to WW3

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA I confirmed this change alone is not changing answers in UFS so I'll make a PR to develop branch, which we'll then merge to dev/ufs-weather-model. I'll keep this PR open until that happens.

@BrianCurtis-NOAA
Copy link
Copy Markdown
Contributor Author

@BrianCurtis-NOAA I confirmed this change alone is not changing answers in UFS so I'll make a PR to develop branch, which we'll then merge to dev/ufs-weather-model. I'll keep this PR open until that happens.

OK, as long as it's tested in build and run, i'm OK with it going in.

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

This PR was merged with #1480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants