Fix issue in PR#1294 to correctly account for IC_NUMERICS option + regression test for this new ice numerics feature#1413
Conversation
|
@sbanihash thanks for finding and making a PR to fix this! |
| STEXU, STEYU, STEDU, IICEHMIN, IICEHINIT, IICEDISP, & | ||
| ICESCALES(1:4), CALTYPE, CMPRTRCK, IICEHFAC, IICEHDISP,& | ||
| IICEDDISP, IICEFDISP, BTBETA, & | ||
| IICEDDISP, IICEFDISP, BTBETA,IC_NUMERICS, & |
There was a problem hiding this comment.
@sbanihash can you add this new variable to: https://github.com/NOAA-EMC/WW3/blob/develop/model/inp/ww3_grid.inp#L456
There was a problem hiding this comment.
Thanks @JessicaMeixner-NOAA for your review. New variable is added.
|
Regression test output is consistent with @sbanihash results. New test: ww3_tic1.1/./work_IC4_M10_icenum + normal diffs + mod_def differences. |
|
@erinethomas @dabail10 The testing on our end is complete. Can you please test this branch within your coupled CESM and E3SM runs which was mentioned in the original PR and let us know if it works as expected? Thanks |
|
I have run these changes in my CESM3 sandbox and they are running as expected. |
|
This is also working as expected in E3SM! |
|
Thank you @erinethomas and @dabail10 for confirming. @JessicaMeixner-NOAA I think we are ready for this PR to be merged. |
Pull Request Summary
Adds IC_NUMERICS to the w3iogrmd.F90, plus addition of a regression test that uses the IC_NUMERICS option (ww3_tic1.1/IC4_M10_icenum)
Changes mod_def file which can be seen in matrix comparisons
Description
This PR addresses issue #1412 by adding the IC_NUMERICS to the w3iogrmd.F90 to make sure mod_def file accounts for the numerics option, and issue #1399 by adding a regression test (ww3_tic1.1/IC4_M10_icenum)
Issue(s) addressed
fixes issue #1412
addresses #1399
Commit Message
Bug fix for #1412 for IC_NUMERICS
Addition of regtest that turns on the IC_NUMERICS in IC4_M10 test case
Check list
Testing
How were these changes tested?
Matrix runs and comparisons for the changes made in w3iogrmd.F90 were conducted and results are attached.
Regtest for IC_NUMERICS has also been added as ww3_tic1.1/IC4_M10_icenum. (this additional test will also result in diffs in your matrix runs)
Are the changes covered by regression tests? Yes, see above
Have the matrix regression tests been run (if yes, please note HPC and compiler)?
yes, Hera intel.
Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
With expected mod_def file differences
matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt
Taking out all mod_def differences, these are the other known diffs we get: