correction lambda computation

[mickaelaccensi]

Pull Request Summary

correction of lambda computation

Description

in ST4 for the LAMBDA output with ROMERO version of ST4, we are not using the right phase speed

the breaking strength needed for Va should have a different power from that required energy dissipation (Deike et al. 2017).
I also changed the scale-dependent wave-breaking direction as presented at WISE, which fixes the issue reported by Alday and Ardhuin where the tail becomes unrealistic under misaligned winds and dominant waves. This also affects Hs in hurricanes.

Issue(s) addressed

• fixes lambda computation #1432

Commit Message

correction of lambda computation

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested? matrix
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) ww3_ta1 and ww3_ts1
• Have the matrix regression tests been run (if yes, please note HPC and compiler)? datarmor with intel compiler
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)ww3_ta1 and ww3_ts1
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
  matrixCompSummary.txt
  matrixCompFull.txt

[JessicaMeixner-NOAA]

@mickaelaccensi - The standalone ww3 regtests passed. We're working on running a couple of extra tests since there are changes to ST4 and we want to make sure we wont see changes in our operational set-ups since we're so close to a code freeze happening. If we don't have that info back today, we will have it on Tuesday (Monday is a holiday in the US).

[JessicaMeixner-NOAA]

matrixCompFull.txt
matrixCompSummary.txt

Full list of non b4b:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (12 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (13 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_ta1/./work_UPD0F_O                     (2 files differ)
ww3_ta1/./work_UPD0F_U                     (2 files differ)
ww3_ta1/./work_UPD2_U_cap                     (2 files differ)
ww3_ta1/./work_UPD3_U                     (2 files differ)
ww3_ta1/./work_UPD5_U_cap                     (2 files differ)
ww3_ta1/./work_UPD6_O                     (2 files differ)
ww3_ta1/./work_UPD2_U                     (2 files differ)
ww3_ta1/./work_UPD5_O                     (2 files differ)
ww3_ta1/./work_UPD5_U                     (2 files differ)
ww3_ta1/./work_UPD3_U_cap                     (2 files differ)
ww3_ta1/./work_UPD3_O                     (2 files differ)
ww3_ta1/./work_UPD6_U                     (2 files differ)
ww3_ta1/./work_UPD2_O                     (2 files differ)
ww3_ta1/./work_UPD6_U_cap                     (2 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ts1/./work_Romero                     (4 files differ)
ww3_ts1/./work_ST4_CAP                     (2 files differ)
ww3_ts1/./work_T701                     (4 files differ)
ww3_ts1/./work_ST4_WRT                     (2 files differ)
ww3_ts1/./work_ST4_GMD                     (2 files differ)
ww3_ts1/./work_ST4                     (2 files differ)
ww3_ts1/./work_ST4_TSA                     (2 files differ)
ww3_ts1/./work_ST4_T700                     (5 files differ)
ww3_ts1/./work_T702                     (4 files differ)
ww3_ts1/./work_ST4_T500                     (2 files differ)
ww3_ts1/./work_T707GQM                     (4 files differ)
ww3_ts1/./work_T713GQM                     (4 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

The test changes that are expected with this PR in ta1 and ts1:

ww3_ta1/./work_UPD0F_O                     (2 files differ)
ww3_ta1/./work_UPD0F_U                     (2 files differ)
ww3_ta1/./work_UPD2_U_cap                     (2 files differ)
ww3_ta1/./work_UPD3_U                     (2 files differ)
ww3_ta1/./work_UPD5_U_cap                     (2 files differ)
ww3_ta1/./work_UPD6_O                     (2 files differ)
ww3_ta1/./work_UPD2_U                     (2 files differ)
ww3_ta1/./work_UPD5_O                     (2 files differ)
ww3_ta1/./work_UPD5_U                     (2 files differ)
ww3_ta1/./work_UPD3_U_cap                     (2 files differ)
ww3_ta1/./work_UPD3_O                     (2 files differ)
ww3_ta1/./work_UPD6_U                     (2 files differ)
ww3_ta1/./work_UPD2_O                     (2 files differ)
ww3_ta1/./work_UPD6_U_cap                     (2 files differ)
ww3_ts1/./work_Romero                     (4 files differ)
ww3_ts1/./work_ST4_CAP                     (2 files differ)
ww3_ts1/./work_T701                     (4 files differ)
ww3_ts1/./work_ST4_WRT                     (2 files differ)
ww3_ts1/./work_ST4_GMD                     (2 files differ)
ww3_ts1/./work_ST4                     (2 files differ)
ww3_ts1/./work_ST4_TSA                     (2 files differ)
ww3_ts1/./work_ST4_T700                     (5 files differ)
ww3_ts1/./work_T702                     (4 files differ)
ww3_ts1/./work_ST4_T500                     (2 files differ)
ww3_ts1/./work_T707GQM                     (4 files differ)
ww3_ts1/./work_T713GQM                     (4 files differ)

[JessicaMeixner-NOAA]

For EMC records, this PR was merged into dev/ufs-weather-model and new mod_defs were created. wave related tests passed:
RegressionTests_hera.log