Skip to content

CMake: MPI flags always added when OASIS is compiled#1437

Merged
JessicaMeixner-NOAA merged 1 commit into
NOAA-EMC:developfrom
MHBalsmeier:cmake_mpi_flag_fix
May 22, 2025
Merged

CMake: MPI flags always added when OASIS is compiled#1437
JessicaMeixner-NOAA merged 1 commit into
NOAA-EMC:developfrom
MHBalsmeier:cmake_mpi_flag_fix

Conversation

@MHBalsmeier
Copy link
Copy Markdown
Contributor

@MHBalsmeier MHBalsmeier commented May 19, 2025

Pull Request Summary

When compiling with CMake and the OASIS flag is included, MPI is always included in the CMakeLists.txt.

Description

This PR makes sure that when OASIS is enabled, MPI flags are automatically added, since OASIS always needs it.

  • Mention any labels that should be added: bug
  • Are answer changes expected from this PR? no

Issue(s) addressed

Commit Message

MPI flags always added when OASIS is compiled

Testing

  • The compilation and execution of ww3_tp2.14 is successful now.

Copy link
Copy Markdown
Collaborator

@mickaelaccensi mickaelaccensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SOUNDS GOOD

Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

Tests were as expected:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (10 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (13 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 351119b into NOAA-EMC:develop May 22, 2025
@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake build for ww3_tp2.14 fails due to missing MPI flags

3 participants