develop: Fix hang bug by updating MPI bcast to be from 0 not IAPROC-1#1430
Merged
sbanihash merged 2 commits intoMay 19, 2025
Merged
Conversation
sbanihash
approved these changes
May 16, 2025
Collaborator
sbanihash
left a comment
There was a problem hiding this comment.
I have reviewed and tested this PR and approve the changes.

matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt
*will not merge since Ming is also testing this PR.
Collaborator
|
I have reviewed and tested this PR. |
mingchen-NOAA
approved these changes
May 19, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request Summary
This PR fixes the bcast call.
Description
When saving point for the unstructured grid, the bcast root was incorrectly IAPROC-1 instead of 0 as intended. This PR is a bug fix and the same bug fix for the dev/ufs-weather-model branch has corresponding PR #1426
Issue(s) addressed
Refs #1350
Commit Message
Fix hang bug by updating MPI bcast to be from 0 not IAPROC-1
Check list
Testing
only the expected non b4b
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt