test: bc full slash tests and partial slash state validation#1194
Merged
ypatil12 merged 6 commits intotest/slashing-integration-testingfrom Mar 4, 2025
Merged
Conversation
ypatil12
added
🗡️ Slashing Release
ypatil12
force-pushed
the
yash/additional-bc-state-validation
branch
from
e15dccc to
75338ce
Compare
nadir-akhtar
approved these changes
Mar 4, 2025
Collaborator
nadir-akhtar
left a comment
nadir-akhtar
left a comment
There was a problem hiding this comment.
LGTM, with one minor suggestion
eigenmikem
reviewed
Mar 4, 2025
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** Additional tests on beacon chain slashing **Modifications:** Full slash tests: - [x] testFuzz_proveValidator_checkpoint_queue_completeAsTokens - [x] test_fullSlash_Revert_Redeposit - [x] testFuzz_fullSlash_registerStakerAsOperator_Revert_Redeposit - [x] testFuzz_fullSlash_registerStakerAsOperator_delegate_undelegate_completeAsShares Partial Slash Tests: - [x] testFuzz_redeposit_queue_completeAsTokens - [x] testFuzz_redeposit_queue_completeAsShares Additionally: - Updated `_getExpectedTokenBalances` to factor in gwei rounding down for EigenPods - Updated `queuedWithdrawal` check when delegated or undelegated - Got rid of unnecessary checkpointing in `SlashedEigenPod.t.sol` **Result:** All single beacon chain slashing state validation complete.
This was referenced Mar 5, 2025
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** Additional tests on beacon chain slashing **Modifications:** Full slash tests: - [x] testFuzz_proveValidator_checkpoint_queue_completeAsTokens - [x] test_fullSlash_Revert_Redeposit - [x] testFuzz_fullSlash_registerStakerAsOperator_Revert_Redeposit - [x] testFuzz_fullSlash_registerStakerAsOperator_delegate_undelegate_completeAsShares Partial Slash Tests: - [x] testFuzz_redeposit_queue_completeAsTokens - [x] testFuzz_redeposit_queue_completeAsShares Additionally: - Updated `_getExpectedTokenBalances` to factor in gwei rounding down for EigenPods - Updated `queuedWithdrawal` check when delegated or undelegated - Got rid of unnecessary checkpointing in `SlashedEigenPod.t.sol` **Result:** All single beacon chain slashing state validation complete.
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** Slashing Integration Testing for Competition Audit **Modifications:** ***General State Validation*** - #1204 - #1198 - #1169 - #1158 ***Upgrade Tests*** - #1187 - #1171 - #1143 ***Dual Slash Tests*** - #1195 - #1153 ***Rounding Tests*** - #1178 ***EigenPod Tests*** - #1191 - #1188 - #1203 - #1194 - #1163 ***Invariants*** - #1201 - #1176 - #1192 - #1197 - #1175 - #1189 - #1150 - #1149 **Result:** Comprehensive Test Coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Additional tests on beacon chain slashing
Modifications:
Full slash tests:
Partial Slash Tests:
Additionally:
_getExpectedTokenBalancesto factor in gwei rounding down for EigenPodsqueuedWithdrawalcheck when delegated or undelegatedSlashedEigenPod.t.solResult:
All single beacon chain slashing state validation complete.