test: add more comprehensive dsf checks#1192
Merged
ypatil12 merged 4 commits intotest/slashing-integration-testingfrom Mar 3, 2025
Merged
test: add more comprehensive dsf checks#1192ypatil12 merged 4 commits intotest/slashing-integration-testingfrom
ypatil12 merged 4 commits intotest/slashing-integration-testingfrom
Conversation
ypatil12
added
🗡️ Slashing Release
ypatil12
changed the title
ypatil12
changed the title
8sunyuan
reviewed
Feb 28, 2025
ypatil12
force-pushed
the
yash/dsf-increase-invariants
branch
from
0b1daf8 to
eca4cff
Compare
0xClandestine
approved these changes
Mar 3, 2025
eigenmikem
reviewed
Mar 3, 2025
| } | ||
| } | ||
|
|
||
| /// @dev Used to assert that the DSF is either increased or unchanged, depending on the slashing factor, on a deposit |
Collaborator
There was a problem hiding this comment.
I've been trying to consolidate "withdrawal as shares" and "deposit" assertions since they should be the same thing, might make sense to do that here if you have time
Contributor
Author
There was a problem hiding this comment.
Think we can do it in a separate PR? Trying to get this in
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** We want to check the DSF on - Delegation (increase when non-WAD maxMag, else stay same) - Deposits (increase on non-WAD slashing factor, else stay same) - Completing withdrawals as shares (same as deposit) **Modifications:** Added `assert_Snap_DSF_State_Deposit`, `assert_Snap_DSF_State_Delegation`, `assert_Snap_DSF_State_CompleteAsShares` **Result:** Stricter DSF invariants
This was referenced Mar 5, 2025
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** We want to check the DSF on - Delegation (increase when non-WAD maxMag, else stay same) - Deposits (increase on non-WAD slashing factor, else stay same) - Completing withdrawals as shares (same as deposit) **Modifications:** Added `assert_Snap_DSF_State_Deposit`, `assert_Snap_DSF_State_Delegation`, `assert_Snap_DSF_State_CompleteAsShares` **Result:** Stricter DSF invariants
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** Slashing Integration Testing for Competition Audit **Modifications:** ***General State Validation*** - #1204 - #1198 - #1169 - #1158 ***Upgrade Tests*** - #1187 - #1171 - #1143 ***Dual Slash Tests*** - #1195 - #1153 ***Rounding Tests*** - #1178 ***EigenPod Tests*** - #1191 - #1188 - #1203 - #1194 - #1163 ***Invariants*** - #1201 - #1176 - #1192 - #1197 - #1175 - #1189 - #1150 - #1149 **Result:** Comprehensive Test Coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We want to check the DSF on
Modifications:
Added
assert_Snap_DSF_State_Deposit,assert_Snap_DSF_State_Delegation,assert_Snap_DSF_State_CompleteAsSharesResult:
Stricter DSF invariants