test: bc full and half slashes#1163
Merged
ypatil12 merged 3 commits intotest/slashing-integration-testingfrom Feb 25, 2025
Merged
test: bc full and half slashes#1163ypatil12 merged 3 commits intotest/slashing-integration-testingfrom
ypatil12 merged 3 commits intotest/slashing-integration-testingfrom
Conversation
ypatil12
changed the base branch from
dev
to
test/slashing-integration-testing
ypatil12
added
✨ Enhancement
0xClandestine
approved these changes
Feb 25, 2025
0xClandestine
changed the title
ypatil12
added a commit
that referenced
this pull request
Feb 27, 2025
**Motivation:** We need to test full slashes for EigenPods. **Modifications:** Added the `SlashType` enum which slashes either the normal amount (10 gwei), half the validators balance, or fully slashes the validator. This needs to be passed in on every call to `slashValidators` Tests: - [x] test_fullSlash_Delegate - [x] test_fullSlash_Revert_Redeposit **Result:** Expressive BC slashing. Note, delegation does not revert when the slashing factor of a staker is zero.
ypatil12
added a commit
that referenced
this pull request
Feb 27, 2025
**Motivation:** We need to test full slashes for EigenPods. **Modifications:** Added the `SlashType` enum which slashes either the normal amount (10 gwei), half the validators balance, or fully slashes the validator. This needs to be passed in on every call to `slashValidators` Tests: - [x] test_fullSlash_Delegate - [x] test_fullSlash_Revert_Redeposit **Result:** Expressive BC slashing. Note, delegation does not revert when the slashing factor of a staker is zero.
ypatil12
added a commit
that referenced
this pull request
Feb 27, 2025
**Motivation:** We need to test full slashes for EigenPods. **Modifications:** Added the `SlashType` enum which slashes either the normal amount (10 gwei), half the validators balance, or fully slashes the validator. This needs to be passed in on every call to `slashValidators` Tests: - [x] test_fullSlash_Delegate - [x] test_fullSlash_Revert_Redeposit **Result:** Expressive BC slashing. Note, delegation does not revert when the slashing factor of a staker is zero.
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** We need to test full slashes for EigenPods. **Modifications:** Added the `SlashType` enum which slashes either the normal amount (10 gwei), half the validators balance, or fully slashes the validator. This needs to be passed in on every call to `slashValidators` Tests: - [x] test_fullSlash_Delegate - [x] test_fullSlash_Revert_Redeposit **Result:** Expressive BC slashing. Note, delegation does not revert when the slashing factor of a staker is zero.
This was referenced Mar 5, 2025
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** We need to test full slashes for EigenPods. **Modifications:** Added the `SlashType` enum which slashes either the normal amount (10 gwei), half the validators balance, or fully slashes the validator. This needs to be passed in on every call to `slashValidators` Tests: - [x] test_fullSlash_Delegate - [x] test_fullSlash_Revert_Redeposit **Result:** Expressive BC slashing. Note, delegation does not revert when the slashing factor of a staker is zero.
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** Slashing Integration Testing for Competition Audit **Modifications:** ***General State Validation*** - #1204 - #1198 - #1169 - #1158 ***Upgrade Tests*** - #1187 - #1171 - #1143 ***Dual Slash Tests*** - #1195 - #1153 ***Rounding Tests*** - #1178 ***EigenPod Tests*** - #1191 - #1188 - #1203 - #1194 - #1163 ***Invariants*** - #1201 - #1176 - #1192 - #1197 - #1175 - #1189 - #1150 - #1149 **Result:** Comprehensive Test Coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to test full slashes for EigenPods.
Modifications:
Added the
SlashTypeenum which slashes either the normal amount (10 gwei), half the validators balance, or fully slashes the validator. This needs to be passed in on every call toslashValidatorsTests:
Result:
Expressive BC slashing.
Note, delegation does not revert when the slashing factor of a staker is zero.