test: slashing invariants#1150
Merged
eigenmikem merged 16 commits intotest/slashing-integration-testingfrom Feb 25, 2025
Merged
test: slashing invariants#1150eigenmikem merged 16 commits intotest/slashing-integration-testingfrom
eigenmikem merged 16 commits intotest/slashing-integration-testingfrom
Conversation
added 7 commits
February 19, 2025 15:22
…tegies on delegation
ypatil12
added
🗡️ Slashing Release
ypatil12
approved these changes
Feb 25, 2025
Contributor
ypatil12
left a comment
ypatil12
left a comment
There was a problem hiding this comment.
LGTM, seems like just the slashable shares in queue remaining?
eigenmikem
merged commit 0c55600
into
test/slashing-integration-testing
10 checks passed
ypatil12
pushed a commit
that referenced
this pull request
Feb 27, 2025
**Motivation:** Implement new slashing invariants and add existing ones to checks. **Modifications:** - Explicit calculation of expected withdrawable shares and dsf after delegation and on completion of full withdrawal - Add "unchanged dsf" assertion - Add increased/decreased minSlashableStake assertions - Overload minSlashableStake assertions to handle address input - Add assertions to slashing flow state checks - Fix `_choose` helper function **Result:** More complete coverage for slashing invariants --------- Co-authored-by: Michael <michael@Michaels-MacBook-Pro.local>
ypatil12
pushed a commit
that referenced
this pull request
Feb 27, 2025
**Motivation:** Implement new slashing invariants and add existing ones to checks. **Modifications:** - Explicit calculation of expected withdrawable shares and dsf after delegation and on completion of full withdrawal - Add "unchanged dsf" assertion - Add increased/decreased minSlashableStake assertions - Overload minSlashableStake assertions to handle address input - Add assertions to slashing flow state checks - Fix `_choose` helper function **Result:** More complete coverage for slashing invariants --------- Co-authored-by: Michael <michael@Michaels-MacBook-Pro.local>
ypatil12
pushed a commit
that referenced
this pull request
Feb 27, 2025
**Motivation:** Implement new slashing invariants and add existing ones to checks. **Modifications:** - Explicit calculation of expected withdrawable shares and dsf after delegation and on completion of full withdrawal - Add "unchanged dsf" assertion - Add increased/decreased minSlashableStake assertions - Overload minSlashableStake assertions to handle address input - Add assertions to slashing flow state checks - Fix `_choose` helper function **Result:** More complete coverage for slashing invariants --------- Co-authored-by: Michael <michael@Michaels-MacBook-Pro.local>
ypatil12
pushed a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** Implement new slashing invariants and add existing ones to checks. **Modifications:** - Explicit calculation of expected withdrawable shares and dsf after delegation and on completion of full withdrawal - Add "unchanged dsf" assertion - Add increased/decreased minSlashableStake assertions - Overload minSlashableStake assertions to handle address input - Add assertions to slashing flow state checks - Fix `_choose` helper function **Result:** More complete coverage for slashing invariants --------- Co-authored-by: Michael <michael@Michaels-MacBook-Pro.local>
This was referenced Mar 5, 2025
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** Slashing Integration Testing for Competition Audit **Modifications:** ***General State Validation*** - #1204 - #1198 - #1169 - #1158 ***Upgrade Tests*** - #1187 - #1171 - #1143 ***Dual Slash Tests*** - #1195 - #1153 ***Rounding Tests*** - #1178 ***EigenPod Tests*** - #1191 - #1188 - #1203 - #1194 - #1163 ***Invariants*** - #1201 - #1176 - #1192 - #1197 - #1175 - #1189 - #1150 - #1149 **Result:** Comprehensive Test Coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Implement new slashing invariants and add existing ones to checks.
Modifications:
_choosehelper functionResult:
More complete coverage for slashing invariants