Skip to content

test: bc/avs slash tests#1153

Merged
ypatil12 merged 19 commits intotest/slashing-integration-testingfrom
yash/bc-avs-ordering-tests
Feb 28, 2025
Merged

test: bc/avs slash tests#1153
ypatil12 merged 19 commits intotest/slashing-integration-testingfrom
yash/bc-avs-ordering-tests

Conversation

@ypatil12
Copy link
Copy Markdown
Contributor

@ypatil12 ypatil12 commented Feb 21, 2025

Motivation:

Tests that handle slashes by both the BC and AVS onto Native ETH.

Modifications:

Added assertions for BC/AVS slashings, no full slashed included

  • testFuzz_avsSlash_bcSlash_checkpoint
  • testFuzz_bcSlash_checkpoint_avsSlash
  • testFuzz_avsSlash_verifyValidator_bcSlash_checkpoint
  • testFuzz_avsSlash_bcSlash_verifyValidator_checkpoint
  • testFuzz_avsSlash_bcSlash_checkpoint_verifyValidator
  • testFuzz_avsSlash_bcSlash_balanceIncrease_checkpoint
  • testFuzz_avsSlash_bcSlash_checkpoint_balanceIncrease

Result:

Test coverage for BC/AVS edge cases.

Need to properly bound a lot of the AVS/BC slashing cases, but this is a start

@ypatil12 ypatil12 added 🗡️ Slashing Release Changes for the slashing release. 🧪 Test Test-related changes (unit, integration, etc.). labels Feb 21, 2025
@0xClandestine 0xClandestine force-pushed the yash/bc-avs-ordering-tests branch from 76877a7 to b97878a Compare February 21, 2025 19:40
@0xClandestine 0xClandestine marked this pull request as ready for review February 21, 2025 19:48
@0xClandestine 0xClandestine force-pushed the yash/bc-avs-ordering-tests branch from f1ec995 to b97878a Compare February 21, 2025 20:07
@bowenli86 bowenli86 force-pushed the yash/bc-avs-ordering-tests branch from e3db760 to b97878a Compare February 22, 2025 02:51
@0xClandestine
Copy link
Copy Markdown
Member

Cannot understand why ci is failing...

@ypatil12 ypatil12 force-pushed the yash/bc-avs-ordering-tests branch from afdef81 to b26a646 Compare February 25, 2025 00:05
@bowenli86
Copy link
Copy Markdown
Contributor

image
i'm getting the same error locally

@ypatil12 ypatil12 force-pushed the yash/bc-avs-ordering-tests branch from b0cbb0a to a4b7cfb Compare February 27, 2025 00:13
Copy link
Copy Markdown
Collaborator

@nadir-akhtar nadir-akhtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test logic overall looks solid -- had some comments for my own knowledge and to simplify some logic (as well as a few whitespace / typo nits) @ypatil12

@ypatil12 ypatil12 force-pushed the yash/bc-avs-ordering-tests branch from 0020780 to 26d8b13 Compare February 28, 2025 04:26
ypatil12 and others added 3 commits February 27, 2025 23:27
Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@nadir-akhtar nadir-akhtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ypatil12 ypatil12 merged commit 3217d1a into test/slashing-integration-testing Feb 28, 2025
10 checks passed
@ypatil12 ypatil12 deleted the yash/bc-avs-ordering-tests branch February 28, 2025 18:00
ypatil12 added a commit that referenced this pull request Mar 5, 2025
**Motivation:**

Tests that handle slashes by both the BC and AVS onto Native ETH. 

**Modifications:**

Added assertions for BC/AVS slashings, no full slashed included

- [x] testFuzz_avsSlash_bcSlash_checkpoint
- [x] testFuzz_bcSlash_checkpoint_avsSlash
- [x] testFuzz_avsSlash_verifyValidator_bcSlash_checkpoint
- [x] testFuzz_avsSlash_bcSlash_verifyValidator_checkpoint
- [x] testFuzz_avsSlash_bcSlash_checkpoint_verifyValidator
- [x] testFuzz_avsSlash_bcSlash_balanceIncrease_checkpoint
- [x] testFuzz_avsSlash_bcSlash_checkpoint_balanceIncrease


**Result:**

Test coverage for BC/AVS edge cases. 

Need to properly bound a lot of the AVS/BC slashing cases, but this is a
start

---------

Co-authored-by: Michael <michael@Michaels-MacBook-Pro.local>
Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
ypatil12 added a commit that referenced this pull request Mar 5, 2025
**Motivation:**

Tests that handle slashes by both the BC and AVS onto Native ETH. 

**Modifications:**

Added assertions for BC/AVS slashings, no full slashed included

- [x] testFuzz_avsSlash_bcSlash_checkpoint
- [x] testFuzz_bcSlash_checkpoint_avsSlash
- [x] testFuzz_avsSlash_verifyValidator_bcSlash_checkpoint
- [x] testFuzz_avsSlash_bcSlash_verifyValidator_checkpoint
- [x] testFuzz_avsSlash_bcSlash_checkpoint_verifyValidator
- [x] testFuzz_avsSlash_bcSlash_balanceIncrease_checkpoint
- [x] testFuzz_avsSlash_bcSlash_checkpoint_balanceIncrease


**Result:**

Test coverage for BC/AVS edge cases. 

Need to properly bound a lot of the AVS/BC slashing cases, but this is a
start

---------

Co-authored-by: Michael <michael@Michaels-MacBook-Pro.local>
Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
ypatil12 added a commit that referenced this pull request Mar 5, 2025
**Motivation:**

Slashing Integration Testing for Competition Audit

**Modifications:**

***General State Validation***
- #1204
- #1198
- #1169
- #1158

***Upgrade Tests***
- #1187
- #1171
- #1143

***Dual Slash Tests***
- #1195
- #1153

***Rounding Tests***
- #1178

***EigenPod Tests***
- #1191
- #1188
- #1203
- #1194
- #1163

***Invariants***
- #1201
- #1176
- #1192
- #1197
- #1175
- #1189
- #1150
- #1149

**Result:**

Comprehensive Test Coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗡️ Slashing Release Changes for the slashing release. 🧪 Test Test-related changes (unit, integration, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants