chore: update undelegate/redelegate checks for 0 deposit shares#1189
Merged
ypatil12 merged 1 commit intotest/slashing-integration-testingfrom Feb 28, 2025
Merged
Conversation
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** On undelegation, deposit shares should be zero, there is no need to check the diff. **Modifications:** Added `assert_RemovedAll_Staker_DepositShares` and updated `assert_Snap_RemovedAll_Staker_WithdrawableShares` to be non-snap. **Result:** Stricter undelegate/redelegate invariants
This was referenced Mar 5, 2025
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** On undelegation, deposit shares should be zero, there is no need to check the diff. **Modifications:** Added `assert_RemovedAll_Staker_DepositShares` and updated `assert_Snap_RemovedAll_Staker_WithdrawableShares` to be non-snap. **Result:** Stricter undelegate/redelegate invariants
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** Slashing Integration Testing for Competition Audit **Modifications:** ***General State Validation*** - #1204 - #1198 - #1169 - #1158 ***Upgrade Tests*** - #1187 - #1171 - #1143 ***Dual Slash Tests*** - #1195 - #1153 ***Rounding Tests*** - #1178 ***EigenPod Tests*** - #1191 - #1188 - #1203 - #1194 - #1163 ***Invariants*** - #1201 - #1176 - #1192 - #1197 - #1175 - #1189 - #1150 - #1149 **Result:** Comprehensive Test Coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
On undelegation, deposit shares should be zero, there is no need to check the diff.
Modifications:
Added
assert_RemovedAll_Staker_DepositSharesand updatedassert_Snap_RemovedAll_Staker_WithdrawableSharesto be non-snap.Result:
Stricter undelegate/redelegate invariants