test: timing integration tests#1158
Merged
nadir-akhtar merged 8 commits intotest/slashing-integration-testingfrom Feb 27, 2025
Merged
test: timing integration tests#1158nadir-akhtar merged 8 commits intotest/slashing-integration-testingfrom
nadir-akhtar merged 8 commits intotest/slashing-integration-testingfrom
Conversation
nadir-akhtar
changed the base branch from
dev
to
test/slashing-integration-testing
ypatil12
added
🗡️ Slashing Release
0xClandestine
force-pushed
the
nadir/timing-integration-tests
branch
from
1588107 to
40ce5d1
Compare
nadir-akhtar
force-pushed
the
nadir/timing-integration-tests
branch
4 times, most recently
from
9041e1e to
34bd2e2
Compare
ypatil12
reviewed
Feb 27, 2025
Contributor
ypatil12
left a comment
ypatil12
left a comment
There was a problem hiding this comment.
Looks good, couple minor comments
nadir-akhtar
force-pushed
the
nadir/timing-integration-tests
branch
from
34bd2e2 to
6bdbf08
Compare
* Removes duplicative check checking for completed withdrawals * Replaces deregistration logic with deallocation logic in deallocation tests * Removes unnecessary recalculation from total withdrawal -> slash after delay test
ypatil12
approved these changes
Feb 27, 2025
nadir-akhtar
merged commit a15c202
into
test/slashing-integration-testing
10 checks passed
ypatil12
pushed a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** These tests cover scenarios that specifically validate correct behavior on the cusp of a delay completing. **Modifications:** This PR adds test that perform a slash on the following critical timing scenarios: * Before/after a partial/total withdrawal is no longer slashable * Before/after an operator fully deallocates * Before/after an operator completes deregistration from an operator set * Before/after an operator completes an allocation **Result:** These timing tests ensure that the correct behavior happens on either side of critical delays --------- Co-authored-by: Michael <michael@Michaels-MacBook-Pro.local>
This was referenced Mar 5, 2025
ypatil12
pushed a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** These tests cover scenarios that specifically validate correct behavior on the cusp of a delay completing. **Modifications:** This PR adds test that perform a slash on the following critical timing scenarios: * Before/after a partial/total withdrawal is no longer slashable * Before/after an operator fully deallocates * Before/after an operator completes deregistration from an operator set * Before/after an operator completes an allocation **Result:** These timing tests ensure that the correct behavior happens on either side of critical delays --------- Co-authored-by: Michael <michael@Michaels-MacBook-Pro.local>
ypatil12
added a commit
that referenced
this pull request
Mar 5, 2025
**Motivation:** Slashing Integration Testing for Competition Audit **Modifications:** ***General State Validation*** - #1204 - #1198 - #1169 - #1158 ***Upgrade Tests*** - #1187 - #1171 - #1143 ***Dual Slash Tests*** - #1195 - #1153 ***Rounding Tests*** - #1178 ***EigenPod Tests*** - #1191 - #1188 - #1203 - #1194 - #1163 ***Invariants*** - #1201 - #1176 - #1192 - #1197 - #1175 - #1189 - #1150 - #1149 **Result:** Comprehensive Test Coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
These tests cover scenarios that specifically validate correct behavior on the cusp of a delay completing.
Modifications:
This PR adds tests that perform a slash on the following critical timing scenarios:
Result:
These timing tests ensure that the correct behavior happens on either side of critical delays