test: more slashing state validation by 0xClandestine · Pull Request #1169 · Layr-Labs/eigenlayer-contracts

0xClandestine · 2025-02-25T20:40:10Z

Motivation:

We want to increase coverage for integration state validation.

Modifications:

Added new test cases:
- testFuzz_deposit_delegate_allocate_partialSlash_redeposit_queue_complete
- testFuzz_deposit_delegate_undelegate_partialSlash_complete
- testFuzz_deposit_delegate_deallocate_partialSlash_queue_complete
- testFuzz_deposit_delegate_deregister_partialSlash_queue_complete
- testFuzz_delegate_zeroShares_partialSlash_deposit_undelegate_complete
- testFuzz_deposit_delegate_allocate_partialSlash_deallocate

Result:

Move coverage.

0xClandestine · 2025-02-26T01:03:51Z

Curious what state validation we're looking to do, the doc didn't specify? @ypatil12

src/test/integration/tests/upgrade/Delegate_Upgrade_Allocate.t.sol

ypatil12 · 2025-02-27T16:29:24Z

src/test/integration/IntegrationBase.t.sol

        // For each strategy, check (prev - removed == cur)
        for (uint i = 0; i < strategies.length; i++) {
-            assertEq(prevShares[i] + addedShares[i], curShares[i], err);
+            assertApproxEqAbs(prevShares[i] + addedShares[i], curShares[i], 1, err);


What case is causing the need for this?

testFuzz_deposit_delegate_allocate_partialSlash_redeposit_queue_complete

@eigenmikem Shouldn't we just be recalculating on this one?

Yea, elsewhere we've always been depositing before delegating when interacting with a slashed operator so this was never hit. @0xClandestine take a look at the assert_Snap_Expected functions to see explicit calculation, or I can push a commit to change this

src/test/integration/tests/Deposit_Delegate_Allocate_Slash_Queue_Redeposit.t.sol

- Add TestState struct to manage test state consistently - Extract setup into _init_ and _setupAllocation functions - Add test stubs for various slashing paths: * Partial slash with redeposit * Undelegate with partial slash * Deallocate with partial slash * Deregister with partial slash

ypatil12

Checks look good, minor comments

src/test/integration/IntegrationChecks.t.sol

ypatil12 · 2025-02-28T18:24:21Z

src/test/integration/IntegrationBase.t.sol

        // For each strategy, check (prev - removed == cur)
        for (uint i = 0; i < strategies.length; i++) {
-            assertEq(prevShares[i] + addedShares[i], curShares[i], err);
+            assertApproxEqAbs(prevShares[i] + addedShares[i], curShares[i], 1, err);


@eigenmikem Shouldn't we just be recalculating on this one?

src/test/integration/tests/Deposit_Delegate_Allocate_Slash_Queue_Redeposit.t.sol

**Motivation:** We want to increase coverage for integration state validation. **Modifications:** - Added new test cases: - `testFuzz_deposit_delegate_allocate_partialSlash_redeposit_queue_complete` - `testFuzz_deposit_delegate_undelegate_partialSlash_complete` - `testFuzz_deposit_delegate_deallocate_partialSlash_queue_complete` - `testFuzz_deposit_delegate_deregister_partialSlash_queue_complete` - `testFuzz_delegate_zeroShares_partialSlash_deposit_undelegate_complete` - `testFuzz_deposit_delegate_allocate_partialSlash_deallocate` **Result:** Move coverage. --------- Co-authored-by: Michael <michael@Michaels-MacBook-Pro.local>

**Motivation:** Slashing Integration Testing for Competition Audit **Modifications:** ***General State Validation*** - #1204 - #1198 - #1169 - #1158 ***Upgrade Tests*** - #1187 - #1171 - #1143 ***Dual Slash Tests*** - #1195 - #1153 ***Rounding Tests*** - #1178 ***EigenPod Tests*** - #1191 - #1188 - #1203 - #1194 - #1163 ***Invariants*** - #1201 - #1176 - #1192 - #1197 - #1175 - #1189 - #1150 - #1149 **Result:** Comprehensive Test Coverage

0xClandestine added 🗡️ Slashing Release Changes for the slashing release. 🧪 Test Test-related changes (unit, integration, etc.). labels Feb 25, 2025

0xClandestine changed the title ~~test: upgrade integration testing~~ test: state validation integration testing Feb 25, 2025

0xClandestine marked this pull request as draft February 25, 2025 20:48

0xClandestine force-pushed the 0xclandestine/slashing-integration-testing-2 branch from 5ae42b2 to e7189ef Compare February 26, 2025 00:38

0xClandestine marked this pull request as ready for review February 26, 2025 01:03

0xClandestine requested review from eigenmikem and ypatil12 February 26, 2025 01:11

eigenmikem requested changes Feb 27, 2025

View reviewed changes

src/test/integration/tests/upgrade/Delegate_Upgrade_Allocate.t.sol Show resolved Hide resolved

ypatil12 suggested changes Feb 27, 2025

View reviewed changes

ypatil12 reviewed Feb 27, 2025

View reviewed changes

0xClandestine requested review from eigenmikem and ypatil12 February 28, 2025 16:44

0xClandestine added 16 commits February 28, 2025 11:48

test: T-83 -> T-86

fefffe3

fix: ci passing

319364f

fix: ci passing

5aa1b0a

fix: ci passing

abc6fd0

test: T-95 -> T-96

a84cbf7

test: more checks

e5c8b11

refactor: review changes

62d9a3b

refactor: review changes

a77070b

fix: failing test

4b5847a

refactor: remove asserts

3cb2d33

refactor: review changes

e120452

refactor: cleanup

0d47814

revert: wrong file changes

0ecbd9b

test: more checks

c153c0e

refactor: cleanup

737f0cc

0xClandestine added 3 commits February 28, 2025 11:50

test: mostly passing

13549fd

test: passing

cc6224b

test: check undelegate

6b4612f

0xClandestine force-pushed the 0xclandestine/slashing-integration-testing-2 branch from 342301b to 6b4612f Compare February 28, 2025 16:50

0xClandestine added 3 commits February 28, 2025 12:01

fix: rebase

435b23e

fix: compile warnings

6ee735b

test: missing check

32700fc

0xClandestine changed the title ~~test: state validation integration testing~~ test: more slashing state validation Feb 28, 2025

ypatil12 reviewed Feb 28, 2025

View reviewed changes

refactor: review changes

110c504

0xClandestine requested a review from ypatil12 February 28, 2025 19:08

Michael added 2 commits February 28, 2025 16:04

refactor: refactor expected withdrawable shares logic

5ef8e08

refactor: apply changes to partial deposit state check

a3209d2

eigenmikem approved these changes Feb 28, 2025

View reviewed changes

ypatil12 approved these changes Feb 28, 2025

View reviewed changes

0xClandestine merged commit 98b0b3d into test/slashing-integration-testing Feb 28, 2025
10 checks passed

0xClandestine deleted the 0xclandestine/slashing-integration-testing-2 branch February 28, 2025 22:35

This was referenced Mar 5, 2025

test: slashing integration testing #1210

Closed

test: slashing integration testing #1211

Merged

Conversation

0xClandestine commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xClandestine commented Feb 26, 2025

Uh oh!

Uh oh!

ypatil12 Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

0xClandestine Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

ypatil12 Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

eigenmikem Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ypatil12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ypatil12 Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

0xClandestine commented Feb 25, 2025 •

edited

Loading