Skip to content

test: remaining upgrade tests#1187

Merged
ypatil12 merged 8 commits intotest/slashing-integration-testingfrom
yash/remaining-upgrade-tests
Mar 4, 2025
Merged

test: remaining upgrade tests#1187
ypatil12 merged 8 commits intotest/slashing-integration-testingfrom
yash/remaining-upgrade-tests

Conversation

@ypatil12
Copy link
Copy Markdown
Contributor

@ypatil12 ypatil12 commented Feb 27, 2025

Motivation:

Final upgrade tests, focusing on completing withdrawals after an operator has been slashed.

Modifications:

2 tests are failing. Dependent on #1176

  • testFuzz_delegate_deposit_queue_upgrade_slashFully_completeAsTokens
  • testFuzz_delegate_deposit_queue_upgrade_slashFully_revertCompleteAsShares
  • testFuzz_delegate_deposit_queue_upgrade_slash_completeAsTokens
  • testFuzz_delegate_deposit_queue_upgrade_slash_completeAsShares

Result:

Upgrade tests complete

@0xClandestine 0xClandestine added 🗡️ Slashing Release Changes for the slashing release. 🧪 Test Test-related changes (unit, integration, etc.). labels Feb 28, 2025
@ypatil12 ypatil12 marked this pull request as ready for review March 1, 2025 18:23
@ypatil12 ypatil12 force-pushed the yash/remaining-upgrade-tests branch from 0b600d8 to ef9e640 Compare March 3, 2025 21:47
}

function _init_(uint24 randomness, bool withOperator, bool withDelegation) internal returns (TestState memory state) {
function _init_(uint24 randomness, bool withOperator, bool withDelegation) internal virtual returns (TestState memory state) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably just use the randomness library and do _randBool() instead of pasing in the bools in the init functions. Don't need to change though its no biggie

@ypatil12 ypatil12 merged commit b3978ee into test/slashing-integration-testing Mar 4, 2025
10 checks passed
@ypatil12 ypatil12 deleted the yash/remaining-upgrade-tests branch March 4, 2025 14:53
ypatil12 added a commit that referenced this pull request Mar 5, 2025
**Motivation:**

Final upgrade tests, focusing on completing withdrawals after an
operator has been slashed.

**Modifications:**

2 tests are failing. Dependent on
#1176

- [x]
testFuzz_delegate_deposit_queue_upgrade_slashFully_completeAsTokens
- [x]
testFuzz_delegate_deposit_queue_upgrade_slashFully_revertCompleteAsShares
- [x] testFuzz_delegate_deposit_queue_upgrade_slash_completeAsTokens
- [x] testFuzz_delegate_deposit_queue_upgrade_slash_completeAsShares

**Result:**

Upgrade tests complete
ypatil12 added a commit that referenced this pull request Mar 5, 2025
**Motivation:**

Final upgrade tests, focusing on completing withdrawals after an
operator has been slashed.

**Modifications:**

2 tests are failing. Dependent on
#1176

- [x]
testFuzz_delegate_deposit_queue_upgrade_slashFully_completeAsTokens
- [x]
testFuzz_delegate_deposit_queue_upgrade_slashFully_revertCompleteAsShares
- [x] testFuzz_delegate_deposit_queue_upgrade_slash_completeAsTokens
- [x] testFuzz_delegate_deposit_queue_upgrade_slash_completeAsShares

**Result:**

Upgrade tests complete
ypatil12 added a commit that referenced this pull request Mar 5, 2025
**Motivation:**

Slashing Integration Testing for Competition Audit

**Modifications:**

***General State Validation***
- #1204
- #1198
- #1169
- #1158

***Upgrade Tests***
- #1187
- #1171
- #1143

***Dual Slash Tests***
- #1195
- #1153

***Rounding Tests***
- #1178

***EigenPod Tests***
- #1191
- #1188
- #1203
- #1194
- #1163

***Invariants***
- #1201
- #1176
- #1192
- #1197
- #1175
- #1189
- #1150
- #1149

**Result:**

Comprehensive Test Coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗡️ Slashing Release Changes for the slashing release. 🧪 Test Test-related changes (unit, integration, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants