Skip to content

test: bc upgrade tests#1171

Merged
0xClandestine merged 4 commits intotest/slashing-integration-testingfrom
yash/bc-upgrade-tests
Feb 26, 2025
Merged

test: bc upgrade tests#1171
0xClandestine merged 4 commits intotest/slashing-integration-testingfrom
yash/bc-upgrade-tests

Conversation

@ypatil12
Copy link
Copy Markdown
Contributor

@ypatil12 ypatil12 commented Feb 25, 2025

Motivation:

Add additional upgrade tests for beacon chain
Modifications:

Describe the modifications you've done.

  • testFuzz_deposit_upgrade_slash_completeCheckpoint
  • testFuzz_deposit_fullSlash_upgrade_delegate
  • testFuzz_deposit_fullSlash_upgrade_deposit_delegate
  • testFuzz_slash_migrate

Move negative share tests into EigenPod.t.sol. Also consolidated migration file.

Result:

BC upgrade tests complete :)

@0xClandestine 0xClandestine added 🗡️ Slashing Release Changes for the slashing release. 🧪 Test Test-related changes (unit, integration, etc.). labels Feb 25, 2025
Copy link
Copy Markdown
Member

@0xClandestine 0xClandestine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clean

function testFuzz_deposit_upgrade_slash_completeCheckpoint(uint24 _rand) public rand(_rand) {
uint64 initBeaconBalanceGwei = uint64(tokenBalances[0] / GWEI_TO_WEI);

/// 2. Upgrade contracts
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: numbers are weird with comments

@0xClandestine 0xClandestine merged commit 617e154 into test/slashing-integration-testing Feb 26, 2025
10 checks passed
@0xClandestine 0xClandestine deleted the yash/bc-upgrade-tests branch February 26, 2025 19:59
ypatil12 added a commit that referenced this pull request Feb 27, 2025
**Motivation:**

Add additional upgrade tests for beacon chain
**Modifications:**

*Describe the modifications you've done.*

- [x] testFuzz_deposit_upgrade_slash_completeCheckpoint
- [x] testFuzz_deposit_fullSlash_upgrade_delegate
- [x] testFuzz_deposit_fullSlash_upgrade_deposit_delegate
- [x] testFuzz_slash_migrate

Move negative share tests into `EigenPod.t.sol`. Also consolidated
migration file.

**Result:**

BC upgrade tests complete :)
ypatil12 added a commit that referenced this pull request Feb 27, 2025
**Motivation:**

Add additional upgrade tests for beacon chain
**Modifications:**

*Describe the modifications you've done.*

- [x] testFuzz_deposit_upgrade_slash_completeCheckpoint
- [x] testFuzz_deposit_fullSlash_upgrade_delegate
- [x] testFuzz_deposit_fullSlash_upgrade_deposit_delegate
- [x] testFuzz_slash_migrate

Move negative share tests into `EigenPod.t.sol`. Also consolidated
migration file.

**Result:**

BC upgrade tests complete :)
ypatil12 added a commit that referenced this pull request Feb 27, 2025
**Motivation:**

Add additional upgrade tests for beacon chain
**Modifications:**

*Describe the modifications you've done.*

- [x] testFuzz_deposit_upgrade_slash_completeCheckpoint
- [x] testFuzz_deposit_fullSlash_upgrade_delegate
- [x] testFuzz_deposit_fullSlash_upgrade_deposit_delegate
- [x] testFuzz_slash_migrate

Move negative share tests into `EigenPod.t.sol`. Also consolidated
migration file.

**Result:**

BC upgrade tests complete :)
ypatil12 added a commit that referenced this pull request Mar 5, 2025
**Motivation:**

Add additional upgrade tests for beacon chain
**Modifications:**

*Describe the modifications you've done.*

- [x] testFuzz_deposit_upgrade_slash_completeCheckpoint
- [x] testFuzz_deposit_fullSlash_upgrade_delegate
- [x] testFuzz_deposit_fullSlash_upgrade_deposit_delegate
- [x] testFuzz_slash_migrate

Move negative share tests into `EigenPod.t.sol`. Also consolidated
migration file.

**Result:**

BC upgrade tests complete :)
ypatil12 added a commit that referenced this pull request Mar 5, 2025
**Motivation:**

Add additional upgrade tests for beacon chain
**Modifications:**

*Describe the modifications you've done.*

- [x] testFuzz_deposit_upgrade_slash_completeCheckpoint
- [x] testFuzz_deposit_fullSlash_upgrade_delegate
- [x] testFuzz_deposit_fullSlash_upgrade_deposit_delegate
- [x] testFuzz_slash_migrate

Move negative share tests into `EigenPod.t.sol`. Also consolidated
migration file.

**Result:**

BC upgrade tests complete :)
ypatil12 added a commit that referenced this pull request Mar 5, 2025
**Motivation:**

Slashing Integration Testing for Competition Audit

**Modifications:**

***General State Validation***
- #1204
- #1198
- #1169
- #1158

***Upgrade Tests***
- #1187
- #1171
- #1143

***Dual Slash Tests***
- #1195
- #1153

***Rounding Tests***
- #1178

***EigenPod Tests***
- #1191
- #1188
- #1203
- #1194
- #1163

***Invariants***
- #1201
- #1176
- #1192
- #1197
- #1175
- #1189
- #1150
- #1149

**Result:**

Comprehensive Test Coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗡️ Slashing Release Changes for the slashing release. 🧪 Test Test-related changes (unit, integration, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants