feat(reports): persist leftover-map coordinates (v2.24.0) - #782
Conversation
Name leftover-map coordinates ξ_{1:2} and ζ_{1:2} on leftover
post–criterion pairs (ADR 0267, migration 0245). After make seed,
closest and farthest leftover pairs sit above the member list with
ξ (x, y) ζ (x, y) next to leftover-map distance d; click opens that
post. Rank-0 unused axes store 0.0. When coordinates, reconstruction,
and distance are finite, R̂ = ξ · ζ and d = ‖ξ − ζ‖. Never invent a
leftover score. Never invent a theta.
Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping
unobserved item–respondent interactions: A latent space item response
model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with
application to principal component analysis. Biometrika, 58(3), 453–467.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (22)
🚧 Files skipped from review as they are similar to previous changes (11)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough잔여 맵 person/item 좌표를 저장하고 API와 프론트엔드 플롯에 전달합니다. 플롯은 persisted 좌표, 축 공유율, 좌표 눈금, persisted 거리 Changes잔여 맵 좌표 저장 및 API
Leftover-map 그래픽 표시
계약 및 릴리스 문서
Estimated code review effort: 4 (Complex) | ~60 minutes Merge Risk: 🟡 Moderate · up to The change can present ambiguous coordinate labels in the leftover-map view, and an incorrectly ordered rollout or rollback could make report reads unavailable. These bounded correctness and availability risks should be fixed or explicitly accepted before merging. Sequence Diagram(s)sequenceDiagram
participant Seed
participant LeftoverPairs
participant Database
participant ReportsAPI
participant ReportsPanel
participant LeftoverPairList
participant LeftoverMapPlot
Seed->>LeftoverPairs: leftover pair 생성
LeftoverPairs->>Database: 좌표 4개 저장
ReportsAPI->>Database: leftover pair 및 축 정보 조회
Database-->>ReportsAPI: 좌표, 거리, 축 공유율 반환
ReportsPanel->>LeftoverPairList: report 데이터 전달
LeftoverPairList->>LeftoverMapPlot: pairs와 leftoverMapAxes 전달
LeftoverMapPlot-->>ReportsPanel: 좌표 눈금, 거리 캡션, 게시물 마커 표시
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 62.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 56 functions across 24 files. (15 skipped: 15 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Independent review required on exact head This is leftover-map coordinates ξ/ζ (ADR 0267 / migration 0245 / v2.24.0) onto |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Exact-head ownership audit: this candidate is not merge-ready under accepted ADR 0208. The buyer projection is useful, but residual-map coordinates are owned by fast-mlsirm Rust; its current |
|
Cycle retry 2026-08-28 16:05 KST. Exact head Required tests, frontend, ontology, Semgrep, OSV, Trivy, Scorecard, PROV-O, and Noema are green on this head. Strix failed closed (job Independent APPROVE is still required. No self-approval, admin bypass, or force push. Squash-merge only after independent APPROVE plus exact-head required success. Next buyer increment after this lands: leftover-map graphic display (Gabriel 1971 biplot of persisted |
|
Cycle retry 2026-08-28T16:05 KST on exact head Gate inventory (do not merge):
Next leftover increment (not this PR): leftover-map graphic display (Gabriel 1971 biplot of already-persisted ξ/ζ). UI-only; no new columns ( Requesting Copilot review again on this exact head. |
|
Stacked leftover-map graphic display is now #783 ( |
* feat(reports): leftover-map graphic display (v2.25.0) Draw persisted leftover-map coordinates ξ and ζ as a Gabriel biplot above leftover pair buttons (ADR 0268). Click a post marker to open that post. Omit the plot when coordinates are missing. No new columns. Never invent a leftover score or a theta. * fix(reports): preserve leftover-map distances Signed-off-by: Codex <codex@localhost> * fix(reports): keep plot labels readable Signed-off-by: Codex <codex@localhost> * docs(reports): correct leftover plot omission rule --------- Signed-off-by: Codex <codex@localhost> Co-authored-by: Codex <codex@localhost>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Write probe 2026-08-28 cycle: leftover-map graphic display (v2.25.0) is on this head ( |
…787) Caption leftover-map plot axes with persisted ADR 0148 leftover-map axis share σ_k² / Σ_j σ_j² (ADR 0269). Rank-0 zero-share axes still name 0%. A missing or non-finite share omits that axis badge and keeps the existing leftover-map axis text. Click a post marker to open that post. No new columns. Never invent a leftover score or a theta.
|
Stacked #787 leftover-map axis share on the graphic display (ADR 0269 / v2.26.0) squash-composed into this head ( |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Codex <codex@localhost>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Cycle write probe 2026-08-29T01:01KST: confirming comment write access. No self-approval. Independent review remains required for leftover-map coordinates. |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Cycle 2026-08-29: independent APPROVE still required. No self-approval. Auto-merge squash armed if policy allows.
|
Cycle overlay 2026-08-29 13:15 KST. Exact head remains Independent APPROVE is still required. Copilot / CodeRabbit / Devin COMMENT is not APPROVE. Do not self-approve. Do not mix leftover-map coordinate ticks (ADR 0270 / v2.27.0) into this PR — that increment stacks onto |
1 participant
Summary
ξ_{1:2}andζ_{1:2}on leftover post–criterion pairs after two-axis Gabriel reconstruction (ADR 0267, migration 0245).make seed, closest and farthest leftover pairs sit above the member list withξ (x, y) ζ (x, y)next to leftover-map distanced; click opens that post.0.0. A non-finite coordinate omits all four. When coordinates, reconstruction, and distance are finite,R̂ = ξ · ζandd = ‖ξ − ζ‖.Verification
tests/test_leftover_pairs.py,tests/test_documentation_hygiene.py(30 passed)tests/test_schema.pyandtests/test_period_report.pywere not executed here (no PostgreSQL /fast_mlsirmin this sandbox)Evidence boundary
Authenticated PostgreSQL API and k6 runtime acceptance are not claimed. No real records or credentials. Synthetic fixtures only.
Independent approval is required. No self-approval, admin bypass, or force push.
Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.
Summary by CodeRabbit
새로운 기능
문서