feat(reports): leftover-map axis share on leftover-axis ticks independently of leftover-map singular values (v2.91.0) - #875
Conversation
…dently of leftover-map singular values (v2.91.0) Caption leftover-axis ticks with persisted leftover-map axis share through leftoverMapAxisTickBadge independently of leftover-map singular values (ADR 0334). Share and singular omit independently. Rank-0 unused axes still name leftover-map axis share 0%. Do not invent leftover-map axis share from σ_k. Do not invent σ_k from leftover-map axis share. UI-only; no SQL; never invent a leftover score or a theta.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Leave #875 open for independent APPROVE. Do not squash-merge. Do not self-approve. Stacked onto leftover-map comparison leftover-axis tick leftover-map axis share ( |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Retry GitHub writes this cycle. Leave #875 open for independent APPROVE. Devin Review COMMENTED (trailing blank line in leftoverMapPlotAxisSingular.test.ts) is not APPROVE. Copilot/Devin COMMENT is not independent APPROVE. Do not squash-merge. Do not self-approve. Stacked onto leftover-map comparison leftover-axis tick leftover-map axis share ( |
|
Cycle 2026-08-31 15:53 KST: leftover-axis ticks leftover-map axis share independently of leftover-map singular values (ADR 0334 / v2.91.0) is this PR at 8fa6042, stacked onto leftover-map comparison leftover-axis tick leftover-map axis share (#874 @ ba58c21). Local parallel 423ca26 is the same increment; do not overwrite this head. Frontend oxlint 0, tsc -b, leftover-map + App + i18n green. Devin/CodeRabbit COMMENT is not independent APPROVE. Leave open for independent APPROVE. Do not self-approve. Do not squash-merge onto the unprotected leftover base. After independent review, retarget leftover-map stack onto leftover-coordinates ( |
…tover-axis tick share tests git diff --check reported a new blank line at EOF in leftoverMapPlotAxisSingular.test.ts on leftover-map comparison leftover-axis tick leftover-map axis share distinctness. Keep a single terminating newline. No leftover-map caption change.
|
Cycle 2026-08-31 15:56 KST: pushed d19f1fd on this branch to drop the trailing blank line Devin flagged in leftoverMapPlotAxisSingular.test.ts ( |
|
Leave open for independent APPROVE. Do not squash-merge. Do not self-approve. Devin COMMENTED is not APPROVE. Stacked leftover-map increment: leftover-axis ticks leftover-map axis share independently of leftover-map singular values (v2.91.0 / ADR 0334). Next leftover-map increment stacks onto this head. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. |
|
Retry GitHub writes this cycle (2026-08-31 15:45 KST). Leave #875 open for independent APPROVE on exact head |
|
Retry GitHub writes this cycle (2026-08-31 16:25 KST). Leave #875 open for independent APPROVE on exact head |
|
Leave #875 open for independent APPROVE. Do not squash-merge. Do not self-approve. Devin COMMENT is not APPROVE. Next leftover-map increment stacked onto this head ( |
1 participant
Summary
make seed, leftover-axis ticks name persisted leftover-map axis share when leftoverMapAxisTickBadge returns a usable leftover-axis tick leftover-map axis share caption even when leftover-map singular values are omitted; click a leftover pair opens that post.leftover axis {k} tick {value} {share}%when leftover-map axis share is finite andσ_komits, andleftover axis {k} tick {value} σ {singular} {share}%when both are finite so they stay distinct from leftover-map graphic leftover-map axis ticksleftover-map axis {k} tick {value} σ {singular} {share}%(ADR 0332), from leftover-map comparison graphic leftover-map axis ticksleftover map comparison graphic leftover-map axis {k} tick {value} σ {singular} {share}%(ADR 0331), from leftover-map comparison leftover-axis ticksleftover map comparison leftover axis {k} tick {value} σ {singular} {share}%(ADR 0333), from leftover-axisleftover axis {k} {share}%(ADR 0325), from comparison leftover-axisleftover map comparison leftover axis {k} {share}%(ADR 0323), and from leftover-axis ticksleftover axis {k} tick {value} σ {singular}(ADR 0330).leftover axis {k} tick {value}orleftover axis {k} tick {value} σ {singular}. Rank-0 unused axes still name leftover-map axis share0%. Share and singular value omit independently. Do not invent leftover-map axis share fromσ_k. Do not inventσ_kfrom leftover-map axis share.feat/leftover-map-compare-axis-tick-share-badge-v2900/ feat(reports): leftover-map axis share on leftover-map comparison leftover-axis ticks independently of leftover-map singular values (v2.90.0) #874 @ba58c21). Leave this PR open for independent review. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240/ feat(reports): persist leftover-map coordinates (v2.24.0) #782) rather than squash-merging here. Issues Milestone 2: port verified direct-PostgreSQL analysis into the protected product architecture #79 and Milestone 2.1: add normalized runtime-analysis schema bridge after v0.77 #87 stay open. Do not merge revert: undo #782 squash until independent APPROVE #808 without independent APPROVE.Test plan
leftoverMapAxisBadge.test.tsleftoverMapAxisTickBadge names 82%/18% with σ 1.84/0.86, share-only when σ omits, rank-0 share 0%, omits NaN/null share independently of σ, does not invent share from σ or σ from share, distinct from leftoverMapCompareAxisTickBadge / leftoverMapPlotTickAxisBadge / leftoverMapComparePlotTickAxisBadge / leftoverMapAxisBadge / leftoverMapCompareAxisBadgeApp.test.tsxleftover-axis tickleftover axis 1 tick +0.50 σ 1.84 82%; grouping comparison leftover-axis ticks stayleftover map comparison leftover axis 1 tick +0.50 σ 1.84 82%i18n.test.tsko/zh/ja/vi share and singular-share leftover-axis tick keystsc -b+ vitest leftover-map + App (718 passed)