Skip to content

feat(reports): leftover-map singular values on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map axis share (v2.85.0) - #869

Open
seonghobae wants to merge 1 commit into
feat/leftover-map-plot-tick-axis-badge-v2840from
feat/leftover-map-compare-plot-tick-axis-badge-v2850
Open

feat(reports): leftover-map singular values on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map axis share (v2.85.0)#869
seonghobae wants to merge 1 commit into
feat/leftover-map-plot-tick-axis-badge-v2840from
feat/leftover-map-compare-plot-tick-axis-badge-v2850

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Caption leftover-map comparison graphic leftover-map axis ticks with persisted leftover-map singular values σ_k through leftoverMapComparePlotTickAxisBadge independently of leftover-map axis share (ADR 0328 / v2.85.0).
  • After make seed, leftover-map comparison graphic leftover-map axis ticks name persisted leftover-map singular values when leftoverMapComparePlotTickAxisBadge returns a usable leftover-map axis tick σ caption even when leftover-map axis share is omitted; click a leftover pair opens that post.
  • Leftover-map comparison graphic leftover-map axis ticks stay leftover map comparison graphic leftover-map axis {k} tick {value} σ {singular} when σ_k is finite so they stay distinct from leftover-map graphic leftover-map axis ticks leftover-map axis {k} tick {value} σ {singular} (ADR 0327), from leftover-map graphic leftover-map axis leftover-map axis {k} σ {value} (ADR 0324), from leftover-axis leftover axis {k} σ {value} (ADR 0325), from comparison leftover-axis leftover map comparison leftover axis {k} σ {value} (ADR 0323), from comparison graphic leftover-map axis leftover map comparison graphic leftover-map axis {k} σ {value} (ADR 0326), and from comparison graphic leftover-map axis ticks leftover map comparison graphic leftover-map axis {k} tick {value} (ADR 0320).
  • A missing, non-finite, or negative singular value omits that σ tick caption and keeps leftover map comparison graphic leftover-map axis {k} tick {value}. Rank-0 unused axes still name σ 0.00. Leftover-map comparison graphic leftover-map axis ticks never name leftover-map axis share. Do not invent σ_k from leftover-map axis share. Do not invent leftover-map axis share from σ_k.
  • UI-only; no SQL; no new columns. Never invent a leftover score. Never invent a theta. Do not persist leftover-map inner product, cosine, or length. This increment does not change leftover-map graphic leftover-map axis ticks.
  • Stacked onto leftover-map graphic leftover-map axis tick leftover-map singular values as leftoverMapPlotTickAxisBadge (feat/leftover-map-plot-tick-axis-badge-v2840 / feat(reports): leftover-map singular values on leftover-map graphic leftover-map axis ticks independently of leftover-map axis share (v2.84.0) #868 @ 5218a5c). Leave this PR open for independent review. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240 / feat(reports): persist leftover-map coordinates (v2.24.0) #782) rather than squash-merging here. Issues Milestone 2: port verified direct-PostgreSQL analysis into the protected product architecture #79 and Milestone 2.1: add normalized runtime-analysis schema bridge after v0.77 #87 stay open. Do not merge revert: undo #782 squash until independent APPROVE #808 without independent APPROVE.

Test plan

  • leftoverMapPlotAxisSingular.test.ts leftoverMapComparePlotTickAxisBadge reads 1.84/0.86 on +0.50/−0.02, names rank-0 0, omit NaN/Infinity/null/negative independently of share, σ copy leftover map comparison graphic leftover-map axis {axis} tick {value} σ {singular}, never names leftover-map axis share, do not invent σ from leftover-map axis share or share from σ, stay distinct from leftoverMapPlotTickAxisBadge / leftoverMapPlotAxisBadge / leftoverMapComparePlotAxisBadge / leftoverMapCompareAxisBadge / leftoverMapAxisBadge
  • LeftoverMapPlot.test.tsx leftover-map comparison graphic leftover-map axis 1 tick +0.50 σ 1.84 / leftover-map axis 2 tick −0.02 σ 0.86; rank-0 leftover-map axis 1 tick 0.00 σ 0.00; σ-only leftover-map axis 1 tick +0.50 σ 1.84 when share is omitted; leftover-map graphic ticks stay leftover-map axis 1 tick +0.50 σ 1.84
  • i18n.test.ts required keys for leftover-map comparison graphic leftover-map axis tick σ in ko/zh/ja/vi (잔여 지도 비교 그림 축 1 눈금 +0.50 σ 1.84 / 残差地图比较图形轴 1 刻度 +0.50 σ 1.84 / 残差マップの比較図軸 1 目盛 +0.50 σ 1.84 / vạch trục đồ họa so sánh bản đồ phần dư 1 +0.50 σ 1.84)
  • frontend oxlint on changed files: 0 warnings, 0 errors
  • frontend tsc -b passed
  • frontend vitest: leftover-map suites 517 + App 103 passed
  • CI Full test suite and Frontend lint, test, build on this exact head
  • After make seed, leftover-map comparison graphic leftover-map axis ticks name leftover-map singular values even when leftover-map axis share is omitted; click opens that post.

Evidence boundary

Authenticated PostgreSQL API and k6 runtime acceptance are not claimed. No real records or credentials. Synthetic fixtures only.

Independent approval is required. No self-approval, admin bypass, or force push.

Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.

Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.


Devin Review

…n graphic leftover-map axis ticks independently of leftover-map axis share (v2.85.0)

Caption leftover-map comparison graphic leftover-map axis ticks with persisted leftover-map singular values σ_k through leftoverMapComparePlotTickAxisBadge independently of leftover-map axis share (ADR 0328). A missing, non-finite, or negative singular value omits that σ tick caption. Rank-0 unused axes still name σ 0.00. Do not invent σ_k from leftover-map axis share.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 48f745c5-2a22-45d0-a2b6-9133de506a32

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Independent review required on exact head 98a29e4. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Stacked onto #868 @ 5218a5c. Devin Review on #868 is COMMENTED, not APPROVE — do not merge #868 or this PR without independent APPROVE plus GitHub Checks on the exact SHA. Issues #79 and #87 stay open.

Buyer-facing copy: leftover-map comparison graphic leftover-map axis ticks name persisted leftover-map singular values as leftoverMapComparePlotTickAxisBadge. leftover map comparison graphic leftover-map axis {k} tick {value} σ {singular} when σ_k is finite; omit independently of leftover-map axis share. Rank-0 still names σ 0.00. Never invent σ_k from leftover-map axis share.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T13:09 KST: exact head 98a29e4 Frontend lint/test/build + Full test suite required-success. Devin Review COMMENTED (no issues) is not independent APPROVE. Leave #869 open. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240 / #782). Issues #79 and #87 stay open. Next buyer-visible increment is leftover-map comparison leftover-axis ticks with persisted leftover-map singular values independently of leftover-map axis share (ADR 0329 / v2.86.0), stacked onto this head — not mixed into #782.

Copy link
Copy Markdown
Contributor Author

Cycle write probe 2026-08-31T04:10Z: confirming comment scope on leftover-map stack tip #869 (v2.85.0). Independent APPROVE required; no self-approve.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T13:17 KST: GitHub writes live as seonghobae. Exact head 98a29e4 has required-success Checks; Devin Review COMMENTED is not independent APPROVE. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Leave #869 open. Issues #79 and #87 stay open.

Next buyer-visible increment: leftover-map comparison leftover-axis ticks with persisted leftover-map singular values independently of leftover-map axis share (ADR 0329 / v2.86.0), stacked onto this PR — grouping comparison strip leftover-axis surface, not leftover-map comparison graphic leftover-map axis ticks (0328).

Copy link
Copy Markdown
Contributor Author

Exact-head loop 2026-08-31T13:20 KST: Frontend lint/test/build success and Full test suite success on 98a29e4. Devin Review commented no issues; that is not independent APPROVE. Leave this PR open. Do not squash-merge onto the unprotected leftover base. Do not self-approve. Do not merge #808 without independent APPROVE. Issues #79 and #87 stay open. Next buyer gap ships as a stacked increment (leftover-map comparison graphic leftover-map axis ticks name leftover-map axis share independently of leftover-map singular values) and will not mix into this head.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T13:27 KST: leftover-map comparison leftover-axis ticks (ADR 0329 / v2.86.0) opened as #870 stacked onto this PR @ 98a29e4. Leave #869 open. Independent APPROVE still required on this exact head. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T13:53 KST: GitHub writes live as seonghobae. Exact head 98a29e4 has required-success Checks; Devin Review COMMENTED is not independent APPROVE. Do not self-approve. Do not squash-merge. Leave #869/#870/#871 open. Next buyer gap is leftover-map axis share on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map singular values, stacked after #871.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant