feat(reports): leftover-map axis share on leftover-map graphic leftover-map axis ticks independently of leftover-map singular values (v2.89.0) - #873
Conversation
…er-map axis ticks independently of leftover-map singular values (v2.89.0) Caption leftover-map graphic leftover-map axis ticks with persisted leftover-map axis share through leftoverMapPlotTickAxisBadge independently of leftover-map singular values (ADR 0332). Share and σ omit independently. Rank-0 unused axes still name leftover-map axis share 0%. Leftover-map comparison leftover-axis ticks and leftover-axis ticks stay σ-only. Do not invent leftover-map axis share from σ_k. Do not invent σ_k from leftover-map axis share. Never invent a leftover score or a theta. No new columns.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Leave open for independent APPROVE. Do not self-approve. Frontend lint and leftover-map + App tests are green (677 passed, oxlint 0, tsc -b). After independent review, retarget onto leftover-coordinates rather than squash-merging onto the leftover base. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| leftoverShare?: number | null, | ||
| ): LeftoverMapCompareAxisBadge { | ||
| const singular = formatLeftoverMapPlotAxisSingular(leftoverSingular); | ||
| if (singular === null) { | ||
| const percent = formatLeftoverMapPlotAxisShare(leftoverShare); | ||
| if (singular === null && percent === null) { |
There was a problem hiding this comment.
📝 Info: Existing callers preserve old labels
An omitted leftoverShare formats as null. Existing three-argument calls therefore retain coordinate-only or singular-only labels.
Was this helpful? React with 👍 or 👎 to provide feedback.
| ); | ||
| return tf(badge.key, badge.values); | ||
| } | ||
| const badge = leftoverMapPlotTickAxisBadge(axisIndex, tickLabel, leftoverSingular); | ||
| const badge = leftoverMapPlotTickAxisBadge(axisIndex, tickLabel, leftoverSingular, leftoverShare); |
There was a problem hiding this comment.
📝 Info: Comparison labels remain isolated
The comparison branch still uses leftoverMapComparePlotTickAxisBadge. Only report plots pass the share into leftoverMapPlotTickAxisBadge.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
| const singular = formatLeftoverMapPlotAxisSingular(leftoverSingular); | ||
| if (singular === null) { | ||
| const percent = formatLeftoverMapPlotAxisShare(leftoverShare); | ||
| if (singular === null && percent === null) { | ||
| return { key: LEFTOVER_MAP_PLOT_TICK, values: { axis: axisIndex, value: tickLabel } }; | ||
| } | ||
| if (singular === null && percent !== null) { | ||
| return { | ||
| key: LEFTOVER_MAP_PLOT_TICK_SHARE, | ||
| values: { axis: axisIndex, value: tickLabel, share: percent }, |
There was a problem hiding this comment.
📝 Info: Zero share remains visible
The shared formatter rejects only null and non-finite values. A persisted zero therefore renders as 0% instead of disappearing.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Cycle 2026-08-31T05:35Z: writes retry on #873. Devin's three notes (omitted leftoverShare keeps 3-arg σ-only labels; comparison ticks stay leftoverMapComparePlotTickAxisBadge; rank-0 share 0% remains visible) match ADR 0332 and are not defects. Independent APPROVE still required. Do not self-approve. Do not squash leftover stack onto unprotected leftover base. Next stacked increment is leftover-map comparison leftover-axis ticks with leftover-map axis share independently of leftover-map singular values (leftoverMapCompareAxisTickBadge, v2.90.0 / ADR 0333) onto this head. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Leave open for independent APPROVE. Do not self-approve. Devin infos match ADR 0332 (share omits independently; comparison ticks stay on leftoverMapComparePlotTickAxisBadge; rank-0 share 0% remains). After independent review, retarget onto leftover-coordinates rather than squash-merging onto the leftover base. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE.
|
Cycle 2026-08-31 14:40 KST: leftover-map graphic leftover-map axis tick leftover-map axis share (ADR 0332 / v2.89.0) remains MERGEABLE at 923bcfe with Frontend lint SUCCESS and Full test suite SUCCESS. Independent APPROVE still required. Do not self-approve. Do not squash-merge. #874 (v2.90.0) is stacked on this head. Issues #79 and #87 stay open. Do not merge #808. |
|
Cycle 2026-08-31 15:24 KST: leave open for independent APPROVE. Devin COMMENT is not independent APPROVE. Do not self-approve. Do not squash-merge. Stacked #874 (ADR 0333) remains MERGEABLE at ba58c21. Next increment ADR 0334 names leftover-axis ticks leftover-map axis share as leftoverMapAxisTickBadge independently of leftover-map singular values. Issues #79 and #87 stay open. |
|
Cycle note (2026-08-31 15:24 KST): stacked leftover-map PRs stay open. #874 (v2.90.0 / ADR 0333) is green with Devin COMMENT only — not independent APPROVE. Next increment ADR 0334 leftover-axis ticks leftover-map axis share as leftoverMapAxisTickBadge stacks onto #874. Do not self-approve. Do not squash-merge. |
1 participant
Summary
make seed, leftover-map graphic leftover-map axis ticks name persisted leftover-map axis share when leftoverMapPlotTickAxisBadge returns a usable leftover-map axis tick leftover-map axis share caption even when leftover-map singular values are omitted; click a leftover pair opens that post.leftover-map axis {k} tick {value} {share}%when leftover-map axis share is finite andσ_komits, andleftover-map axis {k} tick {value} σ {singular} {share}%when both are finite so they stay distinct from leftover-map comparison graphic leftover-map axis ticksleftover map comparison graphic leftover-map axis {k} tick {value} σ {singular} {share}%(ADR 0331), from leftover-map graphic leftover-map axisleftover-map axis {k} σ {value} ({share}%)(ADR 0324), from leftover-axisleftover axis {k} {share}%(ADR 0325), from comparison leftover-axisleftover map comparison leftover axis {k} {share}%(ADR 0323), from comparison graphic leftover-map axisleftover map comparison graphic leftover-map axis {k} σ {value} ({share}%)(ADR 0326), from comparison leftover-axis ticksleftover map comparison leftover axis {k} tick {value} σ {singular}(ADR 0329), from leftover-axis ticksleftover axis {k} tick {value} σ {singular}(ADR 0330), and from leftover-map graphic leftover-map axis ticksleftover-map axis {k} tick {value} σ {singular}(ADR 0327).leftover-map axis {k} tick {value}orleftover-map axis {k} tick {value} σ {singular}. Rank-0 unused axes still name leftover-map axis share0%. Share and singular value omit independently. Do not invent leftover-map axis share fromσ_k. Do not inventσ_kfrom leftover-map axis share.feat/leftover-map-compare-plot-tick-share-badge-v2880/ feat(reports): leftover-map axis share on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map singular values (v2.88.0) #872 @7bdc562). Leave this PR open for independent review. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240/ feat(reports): persist leftover-map coordinates (v2.24.0) #782) rather than squash-merging here. Issues Milestone 2: port verified direct-PostgreSQL analysis into the protected product architecture #79 and Milestone 2.1: add normalized runtime-analysis schema bridge after v0.77 #87 stay open. Do not merge revert: undo #782 squash until independent APPROVE #808 without independent APPROVE.Test plan
leftoverMapPlotAxisSingular.test.tsleftoverMapPlotTickAxisBadge names 82%/18% with σ 1.84/0.86, share-only when σ omits, rank-0 share 0%, omits NaN/null share independently of σ, does not invent share from σ or σ from share, leftover-map comparison leftover-axis ticks and leftover-axis ticks stay σ-onlyLeftoverMapPlot.test.tsxleftover-map graphic ticks with share presenttick +0.50 σ 1.84 82%/tick −0.02 σ 0.86 18%/ rank-0tick 0.00 σ 0.00 0%; σ-omitted+share-present share-onlytick +0.50 82%; NaN-share still σ-only; comparison ticks stay distinctApp.test.tsxleftover-map graphic tickleftover-map axis 1 tick +0.50 σ 1.84 82%i18n.test.tsko/zh/ja/vi share and singular-share tick keystsc -b+ vitest leftover-map + App (677 passed)