feat(reports): leftover-map item coordinates on leftover-map graphic leftover-map criterion markers independently of leftover-map post ξ markers (v2.92.0) - #876
Conversation
…leftover-map criterion markers independently of leftover-map post ξ markers (v2.92.0) Caption leftover-map graphic leftover-map criterion markers with persisted leftover-map item coordinates through leftoverMapPlotCriterionBadge independently of leftover-map post ξ markers (ADR 0335). Rank-0 unused axes still name leftover-map item coordinates (0.00, 0.00). A missing or non-finite leftover-map item coordinate pair omits independently of leftover-map post ξ. Do not invent leftover-map item coordinates from leftover-map post ξ. UI-only; no SQL; never invent a leftover score or a theta.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Leave #876 open for independent APPROVE on exact head |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
📝 Info: Deduplication keeps labels aligned
Criterion deduplication retains one marker object. Its position and accessible caption use that object's coordinates, preventing cross-row coordinate mixing.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
| const badge = leftoverMapPlotCriterionBadge(marker.label, marker.axis1, marker.axis2); | ||
| if (badge === null) { | ||
| return `${t("Criterion ζ")} ${marker.label}`; | ||
| } | ||
| return tf(badge.key, badge.values); |
There was a problem hiding this comment.
📝 Info: Marker labels retain plotted coordinates
layoutLeftoverMapPlot validates coordinates before creating markers. The new badge formats the same item coordinates used for placement, without deriving replacements.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Summary
make seed, leftover-map graphic leftover-map criterion markers name persisted leftover-map item coordinates when leftoverMapPlotCriterionBadge returns a usable leftover-map criterion leftover-map item coordinate caption; click a leftover pair or a leftover-map post marker opens that post.leftover-map criterion {label} at ζ {item}when leftover-map item coordinates are finite so they stay distinct from leftover-map post markersOpen leftover-map post {title} at ξ {person}and from leftover-map comparison graphic leftover-map criterion markersCriterion ζ {label}.Criterion ζ {label}. Rank-0 unused axes still name leftover-map item coordinates(0.00, 0.00). Do not invent leftover-map item coordinates from leftover-map postξ. Do not invent leftover-map postξfrom leftover-map item coordinates.feat/leftover-map-axis-tick-share-badge-v2910/ feat(reports): leftover-map axis share on leftover-axis ticks independently of leftover-map singular values (v2.91.0) #875 @d19f1fd). Leave this PR open for independent review. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget leftover-map stack onto leftover-coordinates (feat/leftover-map-coordinates-v2240/ feat(reports): persist leftover-map coordinates (v2.24.0) #782, already merged to main) rather than squash-merging here. Issues Milestone 2: port verified direct-PostgreSQL analysis into the protected product architecture #79 and Milestone 2.1: add normalized runtime-analysis schema bridge after v0.77 #87 stay open. Do not merge revert: undo #782 squash until independent APPROVE #808 without independent APPROVE.Test plan
leftoverMapPlotLayout.test.tsleftoverMapPlotCriterionBadge namesζ (+0.50, −0.02)/ζ (−0.70, −0.40), rank-0ζ (0.00, 0.00), omits null/NaN/∞ independently of leftover-map post ξ, distinct from leftover-map post action and leftover-map comparison graphic leftover-map criterionLeftoverMapPlot.test.tsxleftover-map graphic leftover-map criterionleftover-map criterion sales-lead at ζ (+0.50, −0.02); grouping comparison leftover-map criterion staysCriterion ζ sales-leadApp.test.tsxleftover-map graphic leftover-map criterionleftover-map criterion sales-lead at ζ (+0.50, −0.02); grouping comparison leftover-map criterion staysCriterion ζ sales-leadi18n.test.tsko/zh/ja/vi leftover-map graphic leftover-map criterion ζ keystsc -b+ vitest leftover-map + App + i18n (731 passed)