Skip to content

feat(reports): leftover-map singular values on leftover-axis report badges independently of leftover-map axis share (v2.82.0) - #866

Open
seonghobae wants to merge 1 commit into
feat/leftover-map-plot-axis-singular-v2810from
feat/leftover-map-axis-singular-only-v2820
Open

feat(reports): leftover-map singular values on leftover-axis report badges independently of leftover-map axis share (v2.82.0)#866
seonghobae wants to merge 1 commit into
feat/leftover-map-plot-axis-singular-v2810from
feat/leftover-map-axis-singular-only-v2820

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Caption leftover-axis report badges with persisted leftover-map singular values σ_k independently of leftover-map axis share (ADR 0325 / v2.82.0).
  • After make seed, leftover-axis report badges name persisted leftover-map singular values when finite even when leftover-map axis share is omitted; click a leftover pair opens that post.
  • Leftover-axis report badges stay leftover axis {k} σ {value} when share is omitted so they stay distinct from leftover-axis leftover axis {k} σ {value} {share}% (ADR 0322), from hyphen leftover-map axis {k} σ {value} (ADR 0324), from comparison leftover-axis leftover map comparison leftover axis {k} σ {value} (ADR 0323), and from comparison graphic leftover map comparison graphic leftover-map axis {k} σ {value} (ADR 0321).
  • A missing or non-finite leftover-map axis share omits that share caption and keeps leftover axis {k} σ {value}. A missing, non-finite, or negative singular value omits that σ badge and keeps leftover axis {k} {share}%. Rank-0 unused axes still name σ 0.00. Do not invent σ_k from leftover-map axis share. Do not invent leftover-map axis share from σ_k.
  • UI-only; no SQL; no new columns. Never invent a leftover score. Never invent a theta. Do not persist leftover-map inner product, cosine, or length. This increment does not change leftover-map singular values on leftover-map graphic-display axes or on leftover-axis report badges on the grouping comparison strip.
  • Stacked onto leftover-map singular values on leftover-map graphic-display axes (feat/leftover-map-plot-axis-singular-v2810 / feat(reports): leftover-map singular values on leftover-map graphic-display axes (v2.81.0) #865 @ a3613ac). Leave this PR open for independent review. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240 / feat(reports): persist leftover-map coordinates (v2.24.0) #782) rather than squash-merging here. Issues Milestone 2: port verified direct-PostgreSQL analysis into the protected product architecture #79 and Milestone 2.1: add normalized runtime-analysis schema bridge after v0.77 #87 stay open. Do not merge revert: undo #782 squash until independent APPROVE #808 without independent APPROVE.

Test plan

  • leftoverMapAxisBadge.test.ts leftover-axis badges read 1.84/0.82, name rank-0 0, omit NaN/Infinity/null/negative independently of share, σ-only copy leftover axis {axis} σ {value}, do not invent σ from leftover-map axis share or share from σ, stay distinct from leftover-map graphic / comparison leftover-axis / comparison graphic copy
  • App.test.tsx period leftover-axis names leftover axis 1 σ 1.84 82% / leftover axis 2 σ 0.86 18%; σ-only leftover axis 1 σ 1.84 is absent when share is present; grouping comparison keeps leftover map comparison leftover axis 1 σ 1.84 82% and leftover-map graphic leftover-map axis 1 σ 1.84 (82%)
  • leftoverMapPlotAxisSingular.test.ts leftover-map graphic and comparison leftover-axis stay distinct from leftover axis {axis} σ {value}
  • leftoverMapPlotLayout.test.ts leftover-map graphic ticks stay distinct from leftover axis {axis} σ {value}
  • i18n.test.ts required keys for leftover-axis σ-only in ko/zh/ja/vi (잔차 축 1 σ 1.84 / 残差轴 1 σ 1.84 / 残差軸 1 σ 1.84 / trục phần dư 1 σ 1.84)
  • frontend oxlint on changed files: 0 warnings, 0 errors
  • frontend tsc -b passed
  • frontend vitest: 514 tests passed (App, i18n, leftoverMapAxisBadge, leftoverMapPlotAxisSingular, leftoverMapPlotLayout)
  • CI Full test suite and Frontend lint, test, build on this exact head
  • After make seed, leftover-axis report badges name leftover-map singular values even when leftover-map axis share is omitted; click opens that post.

Evidence boundary

Authenticated PostgreSQL API and k6 runtime acceptance are not claimed. No real records or credentials. Synthetic fixtures only.

Independent approval is required. No self-approval, admin bypass, or force push.

Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.

Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.


Devin Review

…adges independently of leftover-map axis share (v2.82.0)

Caption leftover-axis report badges with persisted leftover-map singular
values σ_k independently of leftover-map axis share (ADR 0325). Period
leftover-axis copy stays leftover axis {k} σ {value} when share is omitted
so it stays distinct from leftover-axis leftover axis {k} σ {value} {share}%,
from hyphen leftover-map axis {k} σ {value}, from comparison leftover-axis
leftover map comparison leftover axis {k} σ {value}, and from comparison
graphic leftover map comparison graphic leftover-map axis {k} σ {value}.
Rank-0 unused axes still name σ 0.00. Share and singular value omit
independently. Do not invent σ_k from leftover-map axis share. Do not invent
leftover-map axis share from σ_k. Never invent a leftover score. Never invent
a theta.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 754d3fa3-1ae9-4391-aeb9-8e9931c49c84

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31 11:16 KST. Writes work as seonghobae. Exact head 593b8d8 (v2.82.0 / ADR 0325). Caption leftover-axis report badges with persisted leftover-map singular values σ_k independently of leftover-map axis share. Distinct copy leftover axis {k} σ {value} when share is omitted. Rank-0 unused axes still name σ 0.00. Share and singular omit independently. Do not invent σ_k from leftover-map axis share. Do not invent leftover-map axis share from σ_k. Independent APPROVE required. Do not self-approve. Leave stacked leftover PRs open. Do not squash-merge onto the unprotected leftover base. After independent review, retarget onto leftover-coordinates (#782, MERGED). Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. Synthetic fixtures only.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31 11:16 KST. Writes work. Exact head 593b8d8 (v2.82.0 / ADR 0325). Frontend oxlint 0/0, tsc -b, vitest 514 passed locally. Do not wait on Checks. Devin/Copilot COMMENTED is not independent APPROVE. Leave #866 open. Do not squash-merge. Do not self-approve. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. Independent APPROVE required on this exact head.

Next buyer increment after this stacked σ_k surface: leftover-map comparison graphic leftover-map axis leftover-map singular values as leftoverMapComparePlotAxisBadge (named helper matching leftoverMapPlotAxisBadge / leftoverMapCompareAxisBadge / leftoverMapAxisBadge), or leftover-map graphic leftover-map axis ticks naming persisted σ_k independently of leftover-map axis share, or the next already-persisted leftover-map quantity that still has no buyer caption. Do not persist leftover-map inner product, cosine, or length. Synthetic fixtures only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant