feat(reports): leftover-map item coverage on grouping comparison graphic (v2.64.0) - #846
Conversation
…hic (v2.64.0) Caption leftover-map item complete-case coverage on the grouping comparison leftover-map graphic from already-named leftover_map_coverage (ADR 0307). Distinct accessible name Leftover map comparison graphic item coverage. Omit incomplete notes on that comparison plot. Never invent a leftover score or a theta.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Write probe after open. Independent APPROVE is required. This comment is not a review. The only repository collaborator is seonghobae, so an independent reviewer cannot be requested this cycle. Copilot/Devin COMMENT is not independent APPROVE. Leave open. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (#782) rather than squash-merging here. |
There was a problem hiding this comment.
📝 Info: Coverage validation remains independent
leftoverMapCoverageCounts and leftoverMapItemCoverageCounts validate separate fields. A malformed count suppresses only its own comparison-graphic caption.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
📝 Info: Captions cannot outlive the graphic
layoutLeftoverMapPlot gates the entire figure before coverage rendering. Missing plottable coordinates omit both the comparison graphic and its item caption.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Stacked next increment opened as leftover-map incomplete post coverage on the grouping comparison leftover-map graphic (ADR 0308 / v2.65.0) on |
Summary
make seed, closest and farthest leftover pairs sit above the member list with the Gabriel biplot of already-named coordinates, leftover-map axis share when finite, leftover-map complete-case coverage when leftoverMapCoverageCounts returns usable complete-case integers, and leftover map used N of M scored criteria (complete-case) on that comparison graphic when leftoverMapItemCoverageCounts returns usable complete-case integers; click a post marker or a pair button opens that post.Leftover map comparison graphic item coverageso it stays distinct from hyphenLeftover-map graphic item coverageon the period-report graphic and from stripLeftover map comparison item coverage. A missing, non-integer, negative-used, non-positive-scored, or used-greater-than-scored item coverage omits that leftover-map comparison graphic item coverage caption and keeps leftover-map comparison graphic coverage when leftoverMapCoverageCounts returns usable complete-case integers. Coverage0 of Mis shown when that persisted used count is a non-negative integer. Rank-0 origin cells still name item coverage when that item coverage is persisted.feat/leftover-map-compare-plot-coverage-v2630/ feat(reports): leftover-map coverage on grouping comparison graphic (v2.63.0) #845 @7c026df). Leave this PR open for independent review. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240/ feat(reports): persist leftover-map coordinates (v2.24.0) #782) rather than squash-merging here.Verification
pnpm exec vitest run src/App.test.tsx src/components/LeftoverPairList.test.tsx src/components/LeftoverMapPlot.test.tsx src/leftoverMapPlotLayout.test.ts src/leftoverMapPlotAxisShare.test.ts src/leftoverMapCoverage.test.ts src/leftoverMapCoordinates.test.ts src/i18n.test.ts: 470 tests passed.pnpm exec oxlinton changed frontend files: 0 warnings, 0 errors.python3 -m py_compile backend/app/report_ingestion.py backend/tests/test_api.py: ok.Evidence boundary
Authenticated PostgreSQL API and k6 runtime acceptance are not claimed. No real records or credentials. Synthetic fixtures only.
Independent approval is required. No self-approval, admin bypass, or force push.
Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.