Skip to content

feat(reports): leftover-map singular values on leftover-axis ticks independently of leftover-map axis share (v2.87.0) - #871

Open
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-axis-tick-badge-v2860from
feat/leftover-map-axis-tick-badge-v2870
Open

feat(reports): leftover-map singular values on leftover-axis ticks independently of leftover-map axis share (v2.87.0)#871
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-axis-tick-badge-v2860from
feat/leftover-map-axis-tick-badge-v2870

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Caption leftover-axis ticks with persisted leftover-map singular values σ_k through leftoverMapAxisTickBadge independently of leftover-map axis share (ADR 0330 / v2.87.0).
  • After make seed, leftover-axis ticks name persisted leftover-map singular values when leftoverMapAxisTickBadge returns a usable leftover-axis tick σ caption even when leftover-map axis share is omitted; click a leftover pair opens that post.
  • Leftover-axis ticks stay leftover axis {k} tick {value} σ {singular} when σ_k is finite so they stay distinct from leftover-map comparison leftover-axis ticks leftover map comparison leftover axis {k} tick {value} σ {singular} (ADR 0329), from leftover-map comparison graphic leftover-map axis ticks leftover map comparison graphic leftover-map axis {k} tick {value} σ {singular} (ADR 0328), from leftover-map graphic leftover-map axis ticks leftover-map axis {k} tick {value} σ {singular} (ADR 0327), from leftover-axis leftover axis {k} σ {value} (ADR 0325), and from leftover-map graphic leftover-map axis leftover-map axis {k} σ {value} (ADR 0324).
  • A missing, non-finite, or negative singular value omits that σ tick caption and keeps leftover axis {k} tick {value}. Rank-0 unused axes still name σ 0.00. Leftover-axis ticks never name leftover-map axis share. Do not invent σ_k from leftover-map axis share. Do not invent leftover-map axis share from σ_k.
  • UI-only; no SQL; no new columns. Never invent a leftover score. Never invent a theta. Do not persist leftover-map inner product, cosine, or length. This increment does not change leftover-map comparison leftover-axis ticks.
  • Stacked onto leftover-map comparison leftover-axis tick leftover-map singular values as leftoverMapCompareAxisTickBadge (feat/leftover-map-compare-axis-tick-badge-v2860 / feat(reports): leftover-map singular values on leftover-map comparison leftover-axis ticks independently of leftover-map axis share (v2.86.0) #870 @ b086d97). Leave this PR open for independent review. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240 / feat(reports): persist leftover-map coordinates (v2.24.0) #782) rather than squash-merging here. Issues Milestone 2: port verified direct-PostgreSQL analysis into the protected product architecture #79 and Milestone 2.1: add normalized runtime-analysis schema bridge after v0.77 #87 stay open. Do not merge revert: undo #782 squash until independent APPROVE #808 without independent APPROVE.

Test plan

  • leftoverMapAxisBadge.test.ts leftoverMapAxisTickBadge reads 1.84/0.86 on +0.50/−0.02, names rank-0 0, omit NaN/Infinity/null/negative independently of share, σ copy leftover axis {axis} tick {value} σ {singular}, never names leftover-map axis share, do not invent σ from leftover-map axis share or share from σ, stay distinct from leftoverMapCompareAxisTickBadge / leftoverMapPlotTickAxisBadge / leftoverMapComparePlotTickAxisBadge / leftoverMapAxisBadge
  • App.test.tsx pair-list leftover-axis ticks leftover axis 1 tick +0.50 σ 1.84 / leftover axis 2 tick −0.02 σ 0.86 / leftover axis 1 tick 0.00 σ 1.84; grouping comparison leftover-axis ticks stay leftover map comparison leftover axis 1 tick +0.50 σ 1.84
  • LeftoverMapPlot.test.tsx leftover-axis tick copy is absent from the leftover-map graphic
  • i18n.test.ts required keys for leftover-axis tick σ in ko/zh/ja/vi (잔차 축 1 눈금 +0.50 σ 1.84 / 残差轴 1 刻度 +0.50 σ 1.84 / 残差軸 1 目盛 +0.50 σ 1.84 / vạch trục phần dư 1 +0.50 σ 1.84)
  • frontend oxlint on changed files: 0 warnings, 0 errors
  • frontend tsc -b passed
  • frontend vitest: leftover-map suites + App 642 passed
  • CI Full test suite and Frontend lint, test, build on this exact head
  • After make seed, leftover-axis ticks name leftover-map singular values even when leftover-map axis share is omitted; click opens that post.

Evidence boundary

Authenticated PostgreSQL API and k6 runtime acceptance are not claimed. No real records or credentials. Synthetic fixtures only.

Independent approval is required. No self-approval, admin bypass, or force push.

Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.

Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.


Devin Review

…dependently of leftover-map axis share (v2.87.0)

Caption leftover-axis ticks with persisted leftover-map singular values σ_k through leftoverMapAxisTickBadge independently of leftover-map axis share (ADR 0330). A missing, non-finite, or negative singular value omits that σ tick caption. Rank-0 unused axes still name σ 0.00. Do not invent σ_k from leftover-map axis share.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7ca384a6-3b84-4988-9dde-af065b7ab926

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Independent review required on exact head e9e4c2a. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Stacked onto #870 @ b086d97. Leave #869 and #870 open. Independent APPROVE is required on each exact SHA. Issues #79 and #87 stay open.

Buyer-facing copy: leftover-axis ticks stay leftover axis {k} tick {value} σ {singular} when σ is finite, independently of leftover-map axis share. Origin 0.00 plus unique finite ξ/ζ projections match the leftover-map graphic. Comparison leftover-axis ticks stay ADR 0329.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T13:54 KST: exact head e9e4c2a Frontend lint/test/build success; Full test suite was in progress at last poll. Devin Review COMMENTED (no issues) is not independent APPROVE. Leave #871 open. Do not self-approve. Do not squash-merge. Next buyer gap stacks leftover-map axis share on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map singular values after this head.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T14:04 KST: leftover-map comparison graphic leftover-map axis tick leftover-map axis share independently of leftover-map singular values (ADR 0331 / v2.88.0) opened as #872 stacked onto this PR @ e9e4c2a. Leave #871 open. Independent APPROVE still required on this exact head. Do not self-approve. Do not squash-merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant